Skip to content

Commit 9baae9c

Browse files
author
Daniel Jacinto
authored
[A11y Bug] Remove focus from non-interactive elements on TFM badge and table. (#9108)
1 parent bc0338e commit 9baae9c

3 files changed

Lines changed: 12 additions & 12 deletions

File tree

src/NuGetGallery/Views/Packages/DisplayPackage.cshtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,10 +241,10 @@
241241
src="@(PackageHelper.ShouldRenderUrl(Model.IconUrl) && Model.ShowDetailsAndLinks ? Model.IconUrl : Url.Absolute("~/Content/gallery/img/default-package-icon.svg"))"
242242
@ViewHelpers.ImageFallback(Url.Absolute("~/Content/gallery/img/default-package-icon-256x256.png")) />
243243
</span>
244-
<span class="title" tabindex="0">
244+
<span class="title">
245245
@Html.BreakWord(Model.Id)
246246
</span>
247-
<span class="version-title" tabindex="0">
247+
<span class="version-title">
248248
@Model.Version
249249
</span>
250250
@if (Model.IsVerified.HasValue && Model.IsVerified.Value)

src/NuGetGallery/Views/Packages/_SupportedFrameworksBadges.cshtml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,39 +6,39 @@
66
@if (Model.Net != null)
77
{
88
<!-- .NET cannot be an empty version since the lowest version for this framework is "net5.0", if the package contains just "net" framework it will fall into .NET Framework badge instead.' -->
9-
<span class="framework-badge-asset" tabindex="0" aria-label="@String.SupportedFrameworks_Tooltip" data-content="@String.SupportedFrameworks_Tooltip">.NET @Model.Net.GetBadgeVersion()</span>
9+
<span class="framework-badge-asset" aria-label="@String.SupportedFrameworks_Tooltip" data-content="@String.SupportedFrameworks_Tooltip">.NET @Model.Net.GetBadgeVersion()</span>
1010
}
1111
@if (Model.NetCore != null)
1212
{
1313
if (Model.NetCore.GetBadgeVersion().IsEmpty())
1414
{
15-
<span class="framework-badge-asset" tabindex="0" aria-label="@String.SupportedFrameworks_EmptyVersionTooltip" data-content="@String.SupportedFrameworks_EmptyVersionTooltip">.NET Core</span>
15+
<span class="framework-badge-asset" aria-label="@String.SupportedFrameworks_EmptyVersionTooltip" data-content="@String.SupportedFrameworks_EmptyVersionTooltip">.NET Core</span>
1616
}
1717
else
1818
{
19-
<span class="framework-badge-asset" tabindex="0" aria-label="@String.SupportedFrameworks_Tooltip" data-content="@String.SupportedFrameworks_Tooltip">.NET Core @Model.NetCore.GetBadgeVersion()</span>
19+
<span class="framework-badge-asset" aria-label="@String.SupportedFrameworks_Tooltip" data-content="@String.SupportedFrameworks_Tooltip">.NET Core @Model.NetCore.GetBadgeVersion()</span>
2020
}
2121
}
2222
@if (Model.NetStandard != null)
2323
{
2424
if (Model.NetStandard.GetBadgeVersion().IsEmpty())
2525
{
26-
<span class="framework-badge-asset" tabindex="0" aria-label="@String.SupportedFrameworks_EmptyVersionTooltip" data-content="@String.SupportedFrameworks_EmptyVersionTooltip">.NET Standard</span>
26+
<span class="framework-badge-asset" aria-label="@String.SupportedFrameworks_EmptyVersionTooltip" data-content="@String.SupportedFrameworks_EmptyVersionTooltip">.NET Standard</span>
2727
}
2828
else
2929
{
30-
<span class="framework-badge-asset" tabindex="0" aria-label="@String.SupportedFrameworks_Tooltip" data-content="@String.SupportedFrameworks_Tooltip">.NET Standard @Model.NetStandard.GetBadgeVersion()</span>
30+
<span class="framework-badge-asset" aria-label="@String.SupportedFrameworks_Tooltip" data-content="@String.SupportedFrameworks_Tooltip">.NET Standard @Model.NetStandard.GetBadgeVersion()</span>
3131
}
3232
}
3333
@if (Model.NetFramework != null)
3434
{
3535
if (Model.NetFramework.GetBadgeVersion().IsEmpty())
3636
{
37-
<span class="framework-badge-asset" tabindex="0" aria-label="@String.SupportedFrameworks_EmptyVersionTooltip" data-content="@String.SupportedFrameworks_EmptyVersionTooltip">.NET Framework</span>
37+
<span class="framework-badge-asset" aria-label="@String.SupportedFrameworks_EmptyVersionTooltip" data-content="@String.SupportedFrameworks_EmptyVersionTooltip">.NET Framework</span>
3838
}
3939
else
4040
{
41-
<span class="framework-badge-asset" tabindex="0" aria-label="@String.SupportedFrameworks_Tooltip" data-content="@String.SupportedFrameworks_Tooltip">.NET Framework @Model.NetFramework.GetBadgeVersion()</span>
41+
<span class="framework-badge-asset" aria-label="@String.SupportedFrameworks_Tooltip" data-content="@String.SupportedFrameworks_Tooltip">.NET Framework @Model.NetFramework.GetBadgeVersion()</span>
4242
}
4343
}
4444
</div>

src/NuGetGallery/Views/Packages/_SupportedFrameworksTable.cshtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
if (compatibilityFramework.Value.Count > 0)
1313
{
1414
<tr>
15-
<td class="framework-table-product" tabindex="0">
15+
<td class="framework-table-product">
1616
@compatibilityFramework.Key
1717
</td>
1818

@@ -21,11 +21,11 @@
2121
{
2222
if (frameworkVersion.IsComputed)
2323
{
24-
<span class="framework-badge-computed framework-table-margin" tabindex="0">@frameworkVersion.Framework.GetShortFolderName()</span>
24+
<span class="framework-badge-computed framework-table-margin">@frameworkVersion.Framework.GetShortFolderName()</span>
2525
}
2626
else
2727
{
28-
<span class="framework-badge-asset framework-table-margin" tabindex="0">@frameworkVersion.Framework.GetShortFolderName()</span>
28+
<span class="framework-badge-asset framework-table-margin">@frameworkVersion.Framework.GetShortFolderName()</span>
2929
}
3030
}
3131
</td>

0 commit comments

Comments
 (0)