UI should return Forbidden when symbols feature flag is disabled (#7162)

Author: Scott Bommarito

src/NuGetGallery/Controllers/PackagesController.cs

@@ -2520,7 +2520,7 @@ private JsonResult GetJsonResultOrNull(SymbolPackageValidationResult validationR
                     httpStatusCode = HttpStatusCode.Conflict;
                     break;
                 case SymbolPackageValidationResultType.UserNotAllowedToUpload:
-                    httpStatusCode = HttpStatusCode.Unauthorized;
+                    httpStatusCode = HttpStatusCode.Forbidden;
                     break;
                 default:
                     throw new NotImplementedException($"The symbol package validation result type {validationResult.Type} is not supported.");

src/NuGetGallery/Scripts/gallery/async-file-upload.js

@@ -216,7 +216,7 @@
         }
 
         function displayErrors(errors) {
-            if (errors == null || errors.length < 1) {
+            if (!errors || errors.length < 1) {
                 return;
             }
 

tests/NuGetGallery.Facts/Controllers/PackagesControllerFacts.cs

@@ -5613,6 +5613,43 @@ public async Task WillPreventSymbolsUploadIfOriginalPackageIsLocked()
                 Assert.Equal(string.Format(Strings.PackageIsLocked, packageId), (result.Data as JsonValidationMessage[])[0].PlainTextMessage);
             }
 
+            [Fact]
+            public async Task WillPreventSymbolsUploadIfUserNotAllowedToUpload()
+            {
+                var packageId = "theId";
+                var package = new Package()
+                {
+                    PackageRegistration = new PackageRegistration()
+                    {
+                        Id = packageId,
+                        Owners = new List<User>() { TestUtility.FakeUser },
+                        IsLocked = true
+                    }
+                };
+
+                var fakeUploadedFile = new Mock<HttpPostedFileBase>();
+                fakeUploadedFile.Setup(x => x.FileName).Returns("theFile.snupkg");
+                var fakeFileStream = TestPackage.CreateTestSymbolPackageStream("theId", "1.0.0");
+                fakeUploadedFile.Setup(x => x.InputStream).Returns(fakeFileStream);
+                var symbolPackageUploadService = new Mock<ISymbolPackageUploadService>();
+                var message = "message";
+                symbolPackageUploadService
+                    .Setup(x => x.ValidateUploadedSymbolsPackage(It.IsAny<Stream>(), It.IsAny<User>()))
+                    .ReturnsAsync(SymbolPackageValidationResult.UserNotAllowedToUpload(message));
+
+                var controller = CreateController(
+                    GetConfigurationService(),
+                    fakeNuGetPackage: fakeFileStream,
+                    symbolPackageUploadService: symbolPackageUploadService);
+                controller.SetCurrentUser(TestUtility.FakeUser);
+
+                var result = await controller.UploadPackage(fakeUploadedFile.Object) as JsonResult;
+
+                Assert.NotNull(result);
+                Assert.Equal((int)HttpStatusCode.Forbidden, controller.Response.StatusCode);
+                Assert.Equal(message, (result.Data as JsonValidationMessage[])[0].PlainTextMessage);
+            }
+
             public static IEnumerable<object[]> SymbolValidationResultTypes => Enum
                 .GetValues(typeof(SymbolPackageValidationResultType))
                 .Cast<SymbolPackageValidationResultType>()