Update Service Bus libraries from ServerCommon (#8420)

Author: loic-sharma

src/DatabaseMigrationTools/DatabaseMigrationTools.csproj

@@ -65,7 +65,7 @@
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Validation">
-      <Version>2.84.0</Version>
+      <Version>2.86.0</Version>
     </PackageReference>
   </ItemGroup>
   <ItemGroup>

src/GitHubVulnerabilities2Db/GitHubVulnerabilities2Db.csproj

@@ -89,7 +89,7 @@
       <Version>4.3.0-dev-3612825</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Cursor">
-      <Version>2.84.0</Version>
+      <Version>2.86.0</Version>
     </PackageReference>
   </ItemGroup>
   <ItemGroup>

src/NuGetGallery.Core/NuGetGallery.Core.csproj

@@ -47,7 +47,7 @@
       <Version>5.9.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.FeatureFlags">
-      <Version>2.84.0</Version>
+      <Version>2.86.0</Version>
     </PackageReference>
     <PackageReference Include="WindowsAzure.Storage">
       <Version>9.3.3</Version>
@@ -56,13 +56,13 @@
 
   <ItemGroup Condition="'$(TargetFramework)' == 'net472'">
     <PackageReference Include="NuGet.Services.Messaging.Email">
-      <Version>2.84.0</Version>
+      <Version>2.86.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Validation">
-      <Version>2.84.0</Version>
+      <Version>2.86.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Validation.Issues">
-      <Version>2.84.0</Version>
+      <Version>2.86.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.StrongName.elmah.corelibrary">
       <Version>1.2.2</Version>

src/NuGetGallery.Services/NuGetGallery.Services.csproj

@@ -309,10 +309,10 @@
       <Version>5.9.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Configuration">
-      <Version>2.84.0</Version>
+      <Version>2.86.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Logging">
-      <Version>2.84.0</Version>
+      <Version>2.86.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.StrongName.WebBackgrounder">
       <Version>0.2.0</Version>

src/NuGetGallery/NuGetGallery.csproj

@@ -2243,13 +2243,13 @@
       <Version>5.9.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Licenses">
-      <Version>2.84.0</Version>
+      <Version>2.86.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Owin">
-      <Version>2.84.0</Version>
+      <Version>2.86.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Sql">
-      <Version>2.84.0</Version>
+      <Version>2.86.0</Version>
     </PackageReference>
     <PackageReference Include="Owin">
       <Version>1.0.0</Version>
@@ -2293,9 +2293,6 @@
     <PackageReference Include="WindowsAzure.Caching">
       <Version>1.7.0</Version>
     </PackageReference>
-    <PackageReference Include="WindowsAzure.ServiceBus">
-      <Version>4.1.3</Version>
-    </PackageReference>
     <PackageReference Include="WindowsAzure.Storage">
       <Version>9.3.3</Version>
     </PackageReference>

tests/NuGetGallery.Facts/Services/AsynchronousDeleteAccountServiceFacts.cs

@@ -184,6 +184,12 @@ public TestTopicClient(bool shouldFail = false)
             }
 
             public Task SendAsync(IBrokeredMessage message)
+            {
+                Send(message);
+                return Task.CompletedTask;
+            }
+
+            public void Send(IBrokeredMessage message)
             {
                 ++SendAsyncCallCount;
                 if (ShouldFail)
@@ -192,8 +198,10 @@ public Task SendAsync(IBrokeredMessage message)
                 }
 
                 LastSentMessage = message;
-                return Task.FromResult(0);
             }
+
+            public void Close() => throw new NotImplementedException();
+            public Task CloseAsync() => throw new NotImplementedException();
         }
 
         [Schema(Name = AccountDeleteMessageSchemaName, Version = 1)]