Update to the latest version of moment.js to resolve CG (#9212)

Author: joelverhagen

.eslintignore

@@ -5,4 +5,4 @@
 # on specific relative paths.
 **/Scripts/gallery/jquery-3.4.1.js
 **/Scripts/gallery/knockout-3.5.1.js
-**/Scripts/gallery/moment-2.29.2.js
+**/Scripts/gallery/moment-2.29.4.js

src/NuGetGallery/App_Start/AppActivator.cs

@@ -134,7 +134,7 @@ private static void BundlingPostStart()
                 .Include("~/Scripts/gallery/jquery.validate.unobtrusive-3.2.6.js")
                 .Include("~/Scripts/gallery/knockout-3.5.1.js")
                 .Include("~/Scripts/gallery/bootstrap.js")
-                .Include("~/Scripts/gallery/moment-2.29.2.js")
+                .Include("~/Scripts/gallery/moment-2.29.4.js")
                 .Include("~/Scripts/gallery/common.js")
                 .Include("~/Scripts/gallery/autocomplete.js");
             BundleTable.Bundles.Add(scriptBundle);

src/NuGetGallery/NuGetGallery.csproj

@@ -1706,6 +1706,7 @@
     <Content Include="App_Data\Files\Content\Symbols-Configuration.json" />
     <Content Include="Scripts\gallery\instrumentation.js" />
     <Content Include="Scripts\gallery\knockout-3.5.1.js" />
+    <Content Include="Scripts\gallery\moment-2.29.4.js" />
     <Content Include="Scripts\gallery\page-list-packages.js" />
     <Content Include="Scripts\gallery\syntaxhighlight.js" />
     <Content Include="Views\Shared\SiteMenu.cshtml">
@@ -1863,7 +1864,6 @@
     <Content Include="Scripts\gallery\jquery.validate.unobtrusive-3.2.6.js" />
     <Content Include="Scripts\gallery\knockout-projections.js" />
     <Content Include="Scripts\gallery\md5.js" />
-    <Content Include="Scripts\gallery\moment-2.29.2.js" />
     <Content Include="Scripts\gallery\page-about.js" />
     <Content Include="Scripts\gallery\page-account.js" />
     <Content Include="Scripts\gallery\page-add-organization.js" />
@@ -2271,7 +2271,7 @@
       <Version>2.8.3</Version>
     </PackageReference>
     <PackageReference Include="Moment.js">
-      <Version>2.29.2</Version>
+      <Version>2.29.4</Version>
     </PackageReference>
     <PackageReference Include="MvcTreeView">
       <Version>1.4.0</Version>

…Gallery/Scripts/gallery/moment-2.29.2.js …Gallery/Scripts/gallery/moment-2.29.4.jssrc/NuGetGallery/Scripts/gallery/moment-2.29.2.js renamed to src/NuGetGallery/Scripts/gallery/moment-2.29.4.js src/NuGetGallery/Scripts/gallery/moment-2.29.2.js renamed to src/NuGetGallery/Scripts/gallery/moment-2.29.4.js

@@ -1,5 +1,5 @@
 //! moment.js
-//! version : 2.29.2
+//! version : 2.29.4
 //! authors : Tim Wood, Iskren Chernev, Moment.js contributors
 //! license : MIT
 //! momentjs.com
@@ -2454,7 +2454,7 @@
     function preprocessRFC2822(s) {
         // Remove comments and folding whitespace and replace multiple-spaces with a single space
         return s
-            .replace(/\([^)]*\)|[\n\t]/g, ' ')
+            .replace(/\([^()]*\)|[\n\t]/g, ' ')
             .replace(/(\s\s+)/g, ' ')
             .replace(/^\s\s*/, '')
             .replace(/\s\s*$/, '');
@@ -5635,7 +5635,7 @@
 
     //! moment.js
 
-    hooks.version = '2.29.2';
+    hooks.version = '2.29.4';
 
     setHookCallback(createLocal);
 

tests/NuGetGallery.FunctionalTests/StaticAssets/StaticAssetsTests.cs

@@ -67,7 +67,7 @@ public StaticAssetsTests(ITestOutputHelper testOutputHelper) : base(testOutputHe
                     "Scripts/gallery/jquery.validate.unobtrusive-3.2.6.js",
                     "Scripts/gallery/knockout-3.4.2.js",
                     "Scripts/gallery/bootstrap.js",
-                    "Scripts/gallery/moment-2.29.2.js",
+                    "Scripts/gallery/moment-2.29.4.js",
                     "Scripts/gallery/common.js",
                     "Scripts/gallery/autocomplete.js",
                 }