Give the manage packages page its own pva flag (perf concerns) (#8451)

Author: drewgillies

src/NuGetGallery.Services/Configuration/FeatureFlagService.cs

@@ -27,6 +27,7 @@ public class FeatureFlagService : IFeatureFlagService
         private const string ManageDeprecationForManyVersionsFeatureName = GalleryPrefix + "ManageDeprecationMany";
         private const string ManageDeprecationApiFeatureName = GalleryPrefix + "ManageDeprecationApi";
         private const string DisplayVulnerabilitiesFeatureName = GalleryPrefix + "DisplayVulnerabilities";
+        private const string ManagePackagesVulnerabilitiesFeatureName = GalleryPrefix + "ManagePackagesVulnerabilities";
         private const string DisplayFuGetLinksFeatureName = GalleryPrefix + "DisplayFuGetLinks";
         private const string ODataReadOnlyDatabaseFeatureName = GalleryPrefix + "ODataReadOnlyDatabase";
         private const string PackagesAtomFeedFeatureName = GalleryPrefix + "PackagesAtomFeed";
@@ -141,6 +142,11 @@ public bool IsDisplayVulnerabilitiesEnabled()
             return _client.IsEnabled(DisplayVulnerabilitiesFeatureName, defaultValue: false);
         }
 
+        public bool IsManagePackagesVulnerabilitiesEnabled()
+        {
+            return _client.IsEnabled(ManagePackagesVulnerabilitiesFeatureName, defaultValue: false);
+        }
+
         public bool IsDisplayFuGetLinksEnabled()
         {
             return _client.IsEnabled(DisplayFuGetLinksFeatureName, defaultValue: false);

src/NuGetGallery.Services/Configuration/IFeatureFlagService.cs

@@ -67,6 +67,11 @@ public interface IFeatureFlagService
         /// </summary>
         bool IsDisplayVulnerabilitiesEnabled();
 
+        /// <summary>
+        /// Whether or not a package owner can view vulnerability advisory information on the Manage Packages page.
+        /// </summary>
+        bool IsManagePackagesVulnerabilitiesEnabled();
+
         /// <summary>
         /// Whether or not a fuget.org link is visible on a package's details page.
         /// </summary>

src/NuGetGallery.Services/PackageManagement/PackageService.cs

@@ -463,7 +463,7 @@ private IEnumerable<Package> GetPackagesForOwners(IEnumerable<int> ownerKeys, bo
                 .Include(p => p.PackageRegistration.Owners)
                 .Include(p => p.PackageRegistration.RequiredSigners);
 
-            if (includeVulnerabilities)
+            if (includeVulnerabilities && _featureFlagService.IsManagePackagesVulnerabilitiesEnabled())
             {
                 result = result.Include($"{nameof(Package.VulnerablePackageRanges)}.{nameof(VulnerablePackageVersionRange.Vulnerability)}");
             }

src/NuGetGallery/App_Data/Files/Content/flags.json

@@ -23,6 +23,7 @@
     "NuGetGallery.ODataV2SearchNonHijacked": "Enabled",
     "NuGetGallery.ODataV2SearchCountNonHijacked": "Enabled",
     "NuGetGallery.DisplayVulnerabilities": "Enabled",
+    "NuGetGallery.ManagePackagesVulnerabilities": "Enabled",
     "NuGetGallery.DisplayFuGetLinks": "Enabled",
     "NuGetGallery.PatternSetTfmHeuristics": "Enabled"
   },

src/NuGetGallery/Controllers/UsersController.cs

@@ -566,7 +566,7 @@ public virtual ActionResult Packages()
                 ReservedNamespaces = reservedPrefixes,
                 WasMultiFactorAuthenticated = User.WasMultiFactorAuthenticated(),
                 IsCertificatesUIEnabled = ContentObjectService.CertificatesConfiguration?.IsUIEnabledForUser(currentUser) ?? false,
-                IsPackageVulnerabilitiesEnabled = _featureFlagService.IsDisplayVulnerabilitiesEnabled()
+                IsManagePackagesVulnerabilitiesEnabled = _featureFlagService.IsManagePackagesVulnerabilitiesEnabled()
             };
 
             return View(model);

src/NuGetGallery/ViewModels/ManagePackagesViewModel.cs

@@ -24,6 +24,6 @@ public class ManagePackagesViewModel
 
         public bool IsCertificatesUIEnabled { get; set; }
 
-        public bool IsPackageVulnerabilitiesEnabled { get; set; }
+        public bool IsManagePackagesVulnerabilitiesEnabled { get; set; }
     }
 }

src/NuGetGallery/Views/Users/Packages.cshtml

@@ -120,7 +120,7 @@
                     }
                         <th class="sortable">Downloads</th>
                         <th class="sortable">Latest Version</th>
-                    @if (Model.IsPackageVulnerabilitiesEnabled)
+                    @if (Model.IsManagePackagesVulnerabilitiesEnabled)
                     {
                         <th><span class="hidden">Package warnings</span></th>
                     }
@@ -175,7 +175,7 @@
                         <td class="align-middle text-nowrap" data-bind="attr: { 'data-sortby': VersionSortOrder }">
                             <span data-bind="text: LatestVersion"></span>
                         </td>
-                    @if (Model.IsPackageVulnerabilitiesEnabled)
+                    @if (Model.IsManagePackagesVulnerabilitiesEnabled)
                     {
                         <td class="package-icon-cell">
                             <i class="ms-Icon ms-Icon--Warning package-icon" data-bind="visible: IsVulnerable" title="This version has at least one known vulnerability. Click on the package name for details."></i>

src/VerifyMicrosoftPackage/Fakes/FakeFeatureFlagService.cs

@@ -33,6 +33,8 @@ public class FakeFeatureFlagService : IFeatureFlagService
 
         public bool IsDisplayVulnerabilitiesEnabled() => throw new NotImplementedException();
 
+        public bool IsManagePackagesVulnerabilitiesEnabled() => throw new NotImplementedException();
+
         public bool IsDisplayFuGetLinksEnabled() => throw new NotImplementedException();
 
         public bool AreEmbeddedIconsEnabled(User user) => throw new NotImplementedException();