Search page A11y fixes (#9387)

* TFM tab has display: 'none' when collapsed + removed unused viewModel property

* removed aria-expanded

Author: advay26

src/Bootstrap/dist/css/bootstrap-theme.css

@@ -121,6 +121,7 @@
     }
 
     .tfmTab {
+      display: none;
       max-height: 0;
       overflow: hidden;
       transition: max-height 0.1s ease-out;

src/Bootstrap/less/theme/page-list-packages.less

@@ -1366,8 +1366,6 @@ public virtual async Task<ActionResult> ListPackages(PackageListSearchViewModel
 
             // If the experience hasn't been cached, it means it's not the default experienced, therefore, show the panel
             viewModel.IsAdvancedSearchFlightEnabled = searchService.SupportsAdvancedSearch && isAdvancedSearchFlightEnabled;
-            viewModel.ShouldDisplayAdvancedSearchPanel = !shouldCacheAdvancedSearch || !includePrerelease;
-
             viewModel.IsFrameworkFilteringEnabled = isFrameworkFilteringEnabled;
 
             ViewBag.SearchTerm = q;

src/NuGetGallery/Controllers/PackagesController.cs

@@ -59,20 +59,12 @@ $(function() {
         expandButton.classList.toggle('ms-Icon--ChevronUp');
 
         if (this.classList.contains('active')) {
+            dataTab.style.display = 'block';
             dataTab.style.maxHeight = dataTab.scrollHeight + "px";
-
-            for (const tfm of tfmCheckboxes) {
-                tfm.setAttribute('tabindex', '0');
-                tfm.tabindex = "0";
-            }
         }
         else {
+            dataTab.style.display = 'none';
             dataTab.style.maxHeight = 0;
-
-            for (const tfm of tfmCheckboxes) {
-                tfm.setAttribute('tabindex', '-1');
-                tfm.tabindex = "-1";
-            }
         }
     }
 

src/NuGetGallery/Scripts/gallery/page-list-packages.js

@@ -78,8 +78,6 @@ public PackageListViewModel(
 
         public string SortBy { get; set; }
 
-        public bool ShouldDisplayAdvancedSearchPanel { get; set; }
-
         public bool IsAdvancedSearchFlightEnabled { get; set; }
 
         public bool IsFrameworkFilteringEnabled {  get; set; }

src/NuGetGallery/ViewModels/PackageListViewModel.cs

@@ -37,9 +37,10 @@
         </button>
         <div class="tfmTab" id="@(frameworkShortName)tab">
             <ul>
-                @foreach (var tfm in tfms) {
+                @foreach (var tfm in tfms)
+                {
                     <li>
-                        <input type="checkbox" id="@(tfm)" class="tfm" tabindex="-1" parent="@(frameworkShortName)">
+                        <input type="checkbox" id="@(tfm)" class="tfm" parent="@(frameworkShortName)">
                         <label for="@(tfm)">@(tfm)</label>
                     </li>
                 }
@@ -195,7 +196,7 @@
                 {
                     <div class="row">
                         <div class="col-xs-12 clearfix">
-                            <div class="panel panel-default" aria-expanded="true">
+                            <div class="panel panel-default">
                                 <div class="panel-body">
                                     NuGet package search works the same on nuget.org, from the NuGet CLI, and within the NuGet Package Manager extension in Visual Studio. <br />
                                     Check out our <strong><a href="https://docs.microsoft.com/nuget/consume-packages/finding-and-choosing-packages#search-syntax">Search Syntax</a></strong>.