[GH Usage] Moved sorting logic to NuGetPackage info class

Author: mogah

src/NuGetGallery.Core/GitHub/GitHubUsageConfiguration.cs

@@ -6,7 +6,6 @@ namespace NuGetGallery.GitHub
 {
     public class GitHubUsageConfiguration : IGitHubUsageConfiguration
     {
-        public const int ReposPerPackage = 10;
         private readonly Dictionary<string, NuGetPackageGitHubInformation> _nuGetPackagesGitHubDependencies;
 
         public GitHubUsageConfiguration(IReadOnlyList<RepositoryInformation> repositories)
@@ -56,9 +55,7 @@ private static Dictionary<string, NuGetPackageGitHubInformation> GetNuGetPackage
                     entry => entry.Key,
                     entry => new NuGetPackageGitHubInformation(
                              entry.Value.Count,
-                             entry.Value
-                                  .OrderByDescending(x => x.Stars)
-                                  .ThenBy(x => x.Id).Take(ReposPerPackage).ToList()),
+                             entry.Value),
                     StringComparer.InvariantCultureIgnoreCase);
         }
     }

src/NuGetGallery.Core/GitHub/NuGetPackageGitHubInformation.cs

@@ -6,6 +6,8 @@ namespace NuGetGallery.GitHub
 {
     public class NuGetPackageGitHubInformation
     {
+        public const int ReposPerPackage = 10;
+
         public readonly static NuGetPackageGitHubInformation Empty = new NuGetPackageGitHubInformation(
                                                             0,
                                                             new List<RepositoryInformation>());
@@ -17,8 +19,17 @@ public NuGetPackageGitHubInformation(int totalRepos, IReadOnlyList<RepositoryInf
                 throw new IndexOutOfRangeException(string.Format("{0} cannot have a negative value!", nameof(totalRepos)));
             }
 
+            if( repos == null)
+            {
+                throw new ArgumentNullException(nameof(repos));
+            }
+
             TotalRepos = totalRepos;
-            Repos = repos ?? throw new ArgumentNullException(nameof(repos));
+            Repos = repos
+                .OrderByDescending(x => x.Stars)
+                .ThenBy(x => x.Id)
+                .Take(ReposPerPackage)
+                .ToList();
         }
 
         public int TotalRepos { get; }

src/NuGetGallery.Core/GitHub/RepositoryInformation.cs

@@ -26,7 +26,7 @@ public RepositoryInformation(
             }
             else
             {
-                throw new ArgumentException(string.Format("{0} has an invalid format! It should be \"owner/repositoryName\", instead it is: {1}", nameof(Id), Id));
+                throw new ArgumentException(string.Format("{0} has an invalid format! It should be \"owner/repositoryName\"!", nameof(Id)));
             }
 
             Url = url ?? throw new ArgumentNullException(nameof(url));

src/NuGetGallery/Views/Packages/DisplayPackage.cshtml

@@ -522,7 +522,7 @@
                             @(Model.Id), including the following:
                         </p>
 
-                        @foreach (var dep in Model.GitHubDependenciesInformation.Repos.Take(10))
+                        @foreach (var dep in Model.GitHubDependenciesInformation.Repos)
                         {
                             <div class="row top-buffer">
                                 <div class="col-xs-12">

tests/NuGetGallery.Core.Facts/GitHub/GitHubUsageConfigurationFacts.cs

@@ -20,6 +20,7 @@ private static GitHubUsageConfiguration GenConfig(params RepositoryInformation[]
         {
             return new GitHubUsageConfiguration(repos);
         }
+
         public class TheConstructor
         {
             [Fact]
@@ -31,7 +32,6 @@ public void InvalidRepoCache()
 
         public class TheGetPackageInformationMethod
         {
-
             [Fact]
             public void EmptyRepoCache()
             {
@@ -106,7 +106,7 @@ public void MultiReposSameDependencyOrderedByStarCount()
                 var gh = GenConfig(expectedRepos);
                 var nupkgInformation = gh.GetPackageInformation("nupkg1");
 
-                Assert.Equal(Math.Min(expectedRepos.Length, GitHubUsageConfiguration.ReposPerPackage), nupkgInformation.Repos.Count);
+                Assert.Equal(Math.Min(expectedRepos.Length, NuGetPackageGitHubInformation.ReposPerPackage), nupkgInformation.Repos.Count);
                 Assert.Equal(expectedRepos.Length, nupkgInformation.TotalRepos);
 
                 // Make sure they're ordered by descending order of stars
@@ -140,7 +140,7 @@ public void OrderedByStarCountThenByIdThenTrimmed()
                 var gh = GenConfig(expectedRepos);
                 var nupkgInformation = gh.GetPackageInformation("nupkg1");
 
-                Assert.Equal(Math.Min(expectedRepos.Length, GitHubUsageConfiguration.ReposPerPackage), nupkgInformation.Repos.Count);
+                Assert.Equal(Math.Min(expectedRepos.Length, NuGetPackageGitHubInformation.ReposPerPackage), nupkgInformation.Repos.Count);
                 Assert.Equal(expectedRepos.Length, nupkgInformation.TotalRepos);
 
                 Assert.Equal(