Remove dependency on RazorEngine in tests to fix Component Governance error (#9050)

Author: joelverhagen

tests/NuGetGallery.Facts/NuGetGallery.Facts.csproj

@@ -364,9 +364,6 @@
     <PackageReference Include="Moq">
       <Version>4.8.2</Version>
     </PackageReference>
-    <PackageReference Include="RazorEngine">
-      <Version>3.10.0</Version>
-    </PackageReference>
     <PackageReference Include="xunit.abstractions">
       <Version>2.0.1</Version>
     </PackageReference>

tests/NuGetGallery.Facts/Views/Packages/ValidationIssueFacts.cs

@@ -3,12 +3,11 @@
 
 using System;
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
 using System.Text.RegularExpressions;
 using NuGet.Services.Validation;
 using NuGet.Services.Validation.Issues;
-using RazorEngine.Configuration;
-using RazorEngine.Templating;
 using Xunit;
 using Xunit.Abstractions;
 
@@ -24,25 +23,26 @@ public ValidationIssueFacts(ITestOutputHelper output)
             _output = output;
         }
 
+        [Theory]
         [MemberData(nameof(HasACaseForAllIssueTypesTestData))]
         public void HasACaseForAllIssueTypes(ValidationIssue issue)
         {
             // Arrange & Act
-            var html = CompileView(issue);
+            var template = GetTemplate();
 
             // Assert
-            Assert.DoesNotContain(UnknownIssueMessage, html);
+            Assert.Contains("case ValidationIssueCode." + issue.IssueCode.ToString(), template);
         }
 
         [Theory]
         [MemberData(nameof(HasExpectedMessageForUnknownIssueTestData))]
         public void HasExpectedMessageForUnknownIssue(ValidationIssue issue)
         {
             // Arrange & Act
-            var html = CompileView(issue);
+            var template = GetTemplate();
 
             // Assert
-            Assert.Equal(UnknownIssueMessage, html);
+            Assert.DoesNotContain(issue.IssueCode.ToString(), template);
         }
 
         [Theory]
@@ -57,34 +57,13 @@ public void AllIssueCodesAreHandled(ValidationIssueCode issueCode)
             Assert.Contains(issueCode, issueCodes);
         }
 
-        private string CompileView(ValidationIssue issue)
+        private string GetTemplate()
         {
-            // Arrange
-            var config = new TemplateServiceConfiguration
-            {
-                TemplateManager = new EmbeddedResourceTemplateManager(GetType()),
-                DisableTempFileLocking = true,
-            };
-
-            using (var razorEngine = RazorEngineService.Create(config))
+            using (var stream = GetType().Assembly.GetManifestResourceStream("NuGetGallery.Views.Packages._ValidationIssue.cshtml"))
+            using (var streamReader = new StreamReader(stream))
             {
-                _output.WriteLine($"Issue code: {issue.IssueCode}");
-                _output.WriteLine($"Serialized: {issue.Serialize()}");
-
-                // Act
-                var html = CollapseWhitespace(razorEngine.RunCompile("_ValidationIssue", model: issue))
-                    .Trim();
-
-                _output.WriteLine($"HTML:");
-                _output.WriteLine(html);
-
-                return html;
-            }   
-        }
-
-        private string CollapseWhitespace(string input)
-        {
-            return Regex.Replace(input, @"\s+", " ");
+                return streamReader.ReadToEnd();
+            }
         }
 
         public static IEnumerable<ValidationIssue> KnownValidationIssues