[NuGet Symbol Server] Gallery upload for Symbols package (#6503)

Author: shishirx34

src/NuGetGallery.Core/PackageMetadataExtensions.cs

@@ -21,7 +21,7 @@ public static class PackageMetadataExtensions
         /// </summary>
         /// <param name="metadata"><see cref="PackageMetadata"/> for package</param>
         /// <returns>True if the package is a symbols package</returns>
-        public static bool IsSymbolPackage(this PackageMetadata metadata)
+        public static bool IsSymbolsPackage(this PackageMetadata metadata)
         {
             var packageTypes = metadata.GetPackageTypes();
             return packageTypes.Any()

src/NuGetGallery/Controllers/PackagesController.cs

@@ -116,6 +116,7 @@ public VerifyPackageRequest(PackageMetadata packageMetadata, IEnumerable<User> p
         public string Summary { get; set; }
         public string Tags { get; set; }
         public string Title { get; set; }
+        public bool IsSymbolsPackage { get; set; }
 
         public List<string> Warnings { get; set; } = new List<string>();
 

src/NuGetGallery/RequestModels/VerifyPackageRequest.cs

@@ -84,7 +84,7 @@
         };
 
         function resetFileSelectFeedback() {
-            $('#file-select-feedback').attr('value', 'Browse or Drop files to select a package...');
+            $('#file-select-feedback').attr('value', 'Browse or Drop files to select a package or symbols package...');
         }
 
         function prepareUploadFormData() {
@@ -290,7 +290,9 @@
                 window.nuget.configureExpanderHeading("submit-package-form");
             }
 
-            bindReadMeData(model);
+            if (model === null || !model.IsSymbolsPackage) {
+                bindReadMeData(model);
+            }
 
             document.getElementById("validation-failure-container").scrollIntoView();
         }

src/NuGetGallery/Scripts/gallery/async-file-upload.js

@@ -155,7 +155,9 @@
                 submitAsync(navigateToPage);
             });
 
-            bindReadMeData(model);
+            if (model === null || !model.IsSymbolsPackage) {
+                bindReadMeData(model);
+            }
         }
     };
 }());

src/NuGetGallery/Scripts/gallery/page-edit-readme.js

@@ -59,7 +59,7 @@ public async Task EnsureValidAsync(PackageArchiveReader symbolPackageArchiveRead
                     symbolPackageArchiveReader.GetNuspecReader(),
                     strict: true);
 
-                if (!packageMetadata.IsSymbolPackage())
+                if (!packageMetadata.IsSymbolsPackage())
                 {
                     throw new InvalidPackageException(Strings.SymbolsPackage_NotSymbolPackage);
                 }

src/NuGetGallery/Services/SymbolPackageService.cs

@@ -990,4 +990,7 @@ Policy violations: {0}</value>
     <value>The uploaded package's id is too similar to the already existing packages: {0} </value>
     <comment>{0} is the existing collision Ids compared with the uploaded package Id.</comment>
   </data>
+  <data name="SymbolsPackage_UploadSuccessful" xml:space="preserve">
+    <value>Successfully uploaded the symbols package for package with ID {0} and version {1}.</value>
+  </data>
 </root>

src/NuGetGallery/Strings.Designer.cs

@@ -27,7 +27,7 @@
                         @Html.AntiForgeryToken()
 
                         <div class="input-group">
-                            <input type="text" class="form-control" id="file-select-feedback" value="Browse or Drop files to select a package..." aria-label="Upload Your Package" readonly />
+                            <input type="text" class="form-control" id="file-select-feedback" value="Browse or Drop files to select a package or symbols package..." aria-label="Upload Your Package" readonly />
                             <label for="input-select-file" id="PackageFileLabel" class="input-group-btn">
                                 <span id="browse-for-package-button" class="btn btn-primary form-control" tabindex="0" aria-label="Browse for package" role="button">
                                     Browse&hellip;<input type="file" name="UploadFile" accept=".nupkg,.snupkg" aria-labelledby="PackageFileLabel" id="input-select-file" style="display:none;" />

src/NuGetGallery/Strings.resx

@@ -52,7 +52,7 @@
                                     <li><span data-bind="text: $data"></span></li>
                                 </ul>
                                 We recommend that you fix these issues and upload a new package.
-                                    <a href="https://docs.microsoft.com/en-us/nuget/policies/nuget-faq#managing-packages-on-nugetorg" alt="Read more">Read more</a><br />
+                                <a href="https://docs.microsoft.com/en-us/nuget/policies/nuget-faq#managing-packages-on-nugetorg" alt="Read more">Read more</a><br />
                             </span>)
             <!-- /ko -->
 
@@ -89,6 +89,7 @@
             </div>
             <!-- /ko -->
 
+            <!-- ko ifnot: $data.IsSymbolsPackage -->
             <div class="verify-package-field">
                 <label class="verify-package-field-heading">Minimum NuGet Client Version</label>
                 <div data-bind="template: { name: 'display-data-or-default', data: { DisplayText: $data.MinClientVersionDisplay }}"></div>
@@ -118,6 +119,7 @@
                 <p><i>(none specified)</i></p>
                 <!-- /ko -->
             </div>
+            <!-- /ko -->
 
             <div class="verify-package-field">
                 <label class="verify-package-field-heading">Title</label>
@@ -134,6 +136,7 @@
                 <div data-bind="template: { name: 'display-data-or-default', data: { DisplayText: $data.Summary }}"></div>
             </div>
 
+            <!-- ko ifnot: $data.IsSymbolsPackage -->
             <div class="verify-package-field">
                 <div class="verify-package-field-heading"><label>Release Notes</label> (for this version)</div>
                 <div data-bind="template: { name: 'display-data-or-default', data: { DisplayText: $data.ReleaseNotes }}"></div>
@@ -202,6 +205,7 @@
                 </div>
             </div>
             <!-- /ko -->
+            <!-- /ko -->
         </div>
 
         <!-- ko if: $data.IsSemVer2 -->