Skip to content

Commit 7c0f54d

Browse files
[A11y][ScreenReader] Prevent Screen Reader from reading non-header elements (#9181)
* A11y Ignore Extra Heading * Moved prefix reserved out of H1 tag * edit less file to generate css * remove display inline
1 parent 67598fb commit 7c0f54d

3 files changed

Lines changed: 36 additions & 35 deletions

File tree

src/Bootstrap/dist/css/bootstrap-theme.css

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Bootstrap/less/theme/page-display-package.less

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -42,27 +42,28 @@
4242
margin-right: 12px;
4343
}
4444

45-
.prefix-reserve-title {
46-
background-color: #F3F2F1;
47-
display: inline-flex;
48-
align-items: center;
49-
border-radius: 100px;
50-
vertical-align: middle;
45+
}
5146

52-
.reserved-indicator {
53-
width: 18px;
54-
margin-right: 5px;
55-
margin-left: 2px;
56-
}
47+
.prefix-reserve-title {
48+
background-color: #F3F2F1;
49+
display: inline-flex;
50+
align-items: center;
51+
border-radius: 100px;
52+
vertical-align: middle;
5753

58-
.prefix-reserve-label {
59-
font-size: 14px;
60-
font-weight: 400;
61-
color: #2F6FA7;
62-
margin-top: 2px;
63-
margin-bottom: 2px;
64-
margin-right: 10px;
65-
}
54+
.reserved-indicator {
55+
width: 18px;
56+
margin-right: 5px;
57+
margin-left: 2px;
58+
}
59+
60+
.prefix-reserve-label {
61+
font-size: 14px;
62+
font-weight: 400;
63+
color: #2F6FA7;
64+
margin-top: 2px;
65+
margin-bottom: 2px;
66+
margin-right: 10px;
6667
}
6768
}
6869

src/NuGetGallery/Views/Packages/DisplayPackage.cshtml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -250,20 +250,20 @@
250250
<span class="version-title">
251251
@Model.Version
252252
</span>
253-
@if (Model.IsVerified.HasValue && Model.IsVerified.Value)
254-
{
255-
<span class="prefix-reserve-title">
256-
<img class="reserved-indicator"
257-
src="~/Content/gallery/img/reserved-indicator.svg"
258-
@ViewHelpers.ImageFallback(Url.Absolute("~/Content/gallery/img/reserved-indicator-25x25.png"))
259-
data-content="@Strings.ReservedNamespace_ReservedIndicatorTooltip" tabindex="0"
260-
alt="@Strings.ReservedNamespace_ReservedIndicatorTooltip"/>
261-
<a href="https://docs.microsoft.com/en-us/nuget/nuget-org/id-prefix-reservation" class="prefix-reserve-label">
262-
Prefix Reserved
263-
</a>
264-
</span>
265-
}
266253
</h1>
254+
@if (Model.IsVerified.HasValue && Model.IsVerified.Value)
255+
{
256+
<span class="prefix-reserve-title" aria-hidden="true">
257+
<img class="reserved-indicator" aria-hidden="true"
258+
src="~/Content/gallery/img/reserved-indicator.svg"
259+
@ViewHelpers.ImageFallback(Url.Absolute("~/Content/gallery/img/reserved-indicator-25x25.png"))
260+
data-content="@Strings.ReservedNamespace_ReservedIndicatorTooltip" tabindex="0"
261+
alt="@Strings.ReservedNamespace_ReservedIndicatorTooltip"/>
262+
<a href="https://docs.microsoft.com/en-us/nuget/nuget-org/id-prefix-reservation" class="prefix-reserve-label" ari-hidden="true">
263+
Prefix Reserved
264+
</a>
265+
</span>
266+
}
267267
</div>
268268

269269
@if (Model.CanDisplayTargetFrameworks())

0 commit comments

Comments
 (0)