Transform HTTP to HTTPS for known domains in readme.md (#6710)

Author: skofman1

src/NuGetGallery/Services/ReadMeService.cs

@@ -212,13 +212,15 @@ internal static string GetReadMeHtml(string readMeMd)
                     var inline = node.Inline;
                     if (inline != null && inline.Tag == InlineTag.Link)
                     {
-                        // Allow only http or https links in markdown.
-                        Uri targetUri;
-                        if (!(Uri.TryCreate(inline.TargetUrl, UriKind.Absolute, out targetUri)
-                            && (targetUri.Scheme == Uri.UriSchemeHttp || targetUri.Scheme == Uri.UriSchemeHttps)))
+                        // Allow only http or https links in markdown. Transform link to https for known domains.
+                        if (!PackageHelper.TryPrepareUrlForRendering(inline.TargetUrl, out string readyUriString))
                         {
                             inline.TargetUrl = string.Empty;
                         }
+                        else
+                        {
+                            inline.TargetUrl = readyUriString;
+                        }
                     }
                 }
             }

tests/NuGetGallery.Facts/Services/ReadMeServiceFacts.cs

@@ -264,9 +264,11 @@ public void EncodesHtmlInMarkdown(string originalMd, string expectedHtml)
             [Theory]
             [InlineData("# Heading", "<h2>Heading</h2>")]
             [InlineData("- List", "<ul><li>List</li></ul>")]
-            [InlineData("[text](http://www.test.com)", "<p><a href=\"http://www.test.com\" rel=\"nofollow\">text</a></p>")]
+            [InlineData("[text](http://www.test.com)", "<p><a href=\"http://www.test.com/\" rel=\"nofollow\">text</a></p>")]
             [InlineData("[text](javascript:alert('hi'))", "<p><a href=\"\" rel=\"nofollow\">text</a></p>")]
             [InlineData("> <text>Blockquote</text>", "<blockquote><p>&lt;text&gt;Blockquote&lt;/text&gt;</p></blockquote>")]
+            [InlineData("[text](http://www.asp.net)", "<p><a href=\"https://www.asp.net/\" rel=\"nofollow\">text</a></p>")]
+            [InlineData("[text](badurl://www.asp.net)", "<p><a href=\"\" rel=\"nofollow\">text</a></p>")]
             public void ConvertsMarkdownToHtml(string originalMd, string expectedHtml)
             {
                 Assert.Equal(expectedHtml, StripNewLines(ReadMeService.GetReadMeHtml(originalMd)));