Skip to content

Commit 7766bc7

Browse files
authored
[A11y] Call out the 'select scopes' field label (#8252)
Update the API key form to call out the `select scopes` label after tabbing to inputs within that field group. Addresses #8182
1 parent af7a465 commit 7766bc7

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

src/NuGetGallery/Views/Users/ApiKeys.cshtml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -335,16 +335,16 @@
335335

336336
<div class="row">
337337
<div class="col-sm-12 form-group">
338-
<b class="ms-fontSize-xl">Select Scopes</b>
338+
<b id="select-scopes" class="ms-fontSize-xl">Select Scopes</b>
339339
<br />
340340
<span class="has-error">
341341
<span class="help-block" data-bind="text: ScopesError" aria-live="polite" role="alert"></span>
342342
</span>
343343
<ul role="presentation">
344344
<li>
345345
<div class="checkbox">
346-
<label>
347-
<input type="checkbox" data-bind="checked: PushEnabled, enable: PushAnyEnabled" />
346+
<label id="select-scopes-push">
347+
<input type="checkbox" data-bind="checked: PushEnabled, enable: PushAnyEnabled" aria-labelledby="select-scopes-push select-scopes" />
348348
Push
349349
</label>
350350
</div>
@@ -353,10 +353,11 @@
353353
<div class="radio">
354354
<div class="label-sibling">
355355
<input name="PushScope" type="radio" value="@NuGetScopes.PackagePush"
356+
aria-labelledby="select-scopes-push-package select-scopes"
356357
data-bind="checked: PushScope, enable: PushNewEnabled,
357358
attr: { id: PackagePushId }" />
358359
</div>
359-
<label data-bind="attr: { for: PackagePushId }">
360+
<label id="select-scopes-push-package" data-bind="attr: { for: PackagePushId }">
360361
@NuGetScopes.Describe(NuGetScopes.PackagePush)
361362
</label>
362363
</div>
@@ -365,10 +366,11 @@
365366
<div class="radio">
366367
<div class="label-sibling">
367368
<input name="PushScope" type="radio" value="@NuGetScopes.PackagePushVersion"
369+
aria-labelledby="select-scopes-push-package-version select-scopes"
368370
data-bind="checked: PushScope, enable: PushExistingEnabled,
369371
attr: { id: PackagePushVersionId }" />
370372
</div>
371-
<label data-bind="attr: { for: PackagePushVersionId }">
373+
<label id="select-scopes-push-package-version" data-bind="attr: { for: PackagePushVersionId }">
372374
@NuGetScopes.Describe(NuGetScopes.PackagePushVersion)
373375
</label>
374376
</div>
@@ -377,8 +379,9 @@
377379
</li>
378380
<li>
379381
<div class="checkbox">
380-
<label>
382+
<label id="select-scopes-unlist">
381383
<input type="checkbox" value="@NuGetScopes.PackageUnlist"
384+
aria-labelledby="select-scopes-unlist select-scopes"
382385
data-bind="checked: UnlistScopeChecked, enable: UnlistEnabled" />
383386
@NuGetScopes.Describe(NuGetScopes.PackageUnlist)
384387
</label>

0 commit comments

Comments
 (0)