Merge pull request #8804 from NuGet/dev

[2021-09-14]RI of dev to main

Author: shishirx34

src/AccountDeleter/AccountDeleter.csproj

@@ -84,6 +84,7 @@
     <Compile Include="Program.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Properties\AssemblyInfo.*.cs" />
+    <Compile Include="Providers\AccountDeleteUrlHelper.cs" />
     <Compile Include="Telemetry\IAccountDeleteTelemetryService.cs" />
     <Compile Include="Telemetry\AccountDeleteTelemetryService.cs" />
   </ItemGroup>

src/AccountDeleter/Job.cs

@@ -140,6 +140,8 @@ protected void ConfigureGalleryServices(IServiceCollection services)
                 services.AddScoped<ICoreFileStorageService, CloudBlobFileStorageService>();
                 services.AddScoped<ICloudBlobContainerInformationProvider, GalleryCloudBlobContainerInformationProvider>();
 
+                services.AddScoped<IUrlHelper, AccountDeleteUrlHelper>();
+
                 services.AddScoped<IIndexingService, EmptyIndexingService>();
                 services.AddScoped<ICredentialBuilder, CredentialBuilder>();
                 services.AddScoped<ICredentialValidator, CredentialValidator>();

src/AccountDeleter/Providers/AccountDeleteUrlHelper.cs

@@ -0,0 +1,30 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System;
+
+namespace NuGetGallery.AccountDeleter
+{
+    public class AccountDeleteUrlHelper : IUrlHelper
+    {
+        public string ConfirmPendingOwnershipRequest(string id, string username, string confirmationCode, bool relativeUrl)
+        {
+            throw new NotImplementedException();
+        }
+
+        public string ManagePackageOwnership(string id, bool relativeUrl)
+        {
+            throw new NotImplementedException();
+        }
+
+        public string Package(string id, string version, bool relativeUrl)
+        {
+            throw new NotImplementedException();
+        }
+
+        public string RejectPendingOwnershipRequest(string id, string username, string confirmationCode, bool relativeUrl)
+        {
+            throw new NotImplementedException();
+        }
+    }
+}

src/Bootstrap/dist/css/bootstrap-theme.css

@@ -274,25 +274,14 @@
     font-size: 14px;
     color: #333333;
     margin: 4px 0 0 0;
-    width: auto;
-    overflow: hidden;
-    text-overflow: ellipsis;
-    display: -webkit-box;
     line-height: 16px;
-    /* fallback */
-    max-height: 32px;
-    /* fallback */
-    -webkit-line-clamp: 2;
-    /* number of lines to show */
-    -webkit-box-orient: vertical;
   }
 
   .used-by-link {
     font-family: @font-family-base;
     font-size: 16px;
     line-height: 19px;
     color: @brand-primary;
-    width: auto;
   }
 
   .gh-link, .ngp-link {

src/Bootstrap/less/theme/page-display-package-v2.less

@@ -29,7 +29,11 @@ public interface ICorePackageService
         Task UpdatePackageStatusAsync(Package package, PackageStatus newPackageStatus, bool commitChanges = true);
 
         /// <summary>
-        /// Gets the package with the given ID and version when exists; otherwise <c>null</c>.
+        /// Gets the package with the given ID and version when exists; otherwise <c>null</c>. Note that this method
+        /// can return a soft deleted package. This will be indicated by <see cref="PackageStatus.Deleted"/> on the
+        /// <see cref="Package.PackageStatusKey"/> property. Hard deleted packages will be returned as null because no
+        /// record of the package exists. Consider checking for a null package and a soft deleted depending on your
+        /// desired behavior for non-existent and deleted packages.
         /// </summary>
         /// <param name="id">The package ID.</param>
         /// <param name="version">The package version.</param>