remove some redundant scoped variables (#10009)

Author: SimonCropp

src/NuGetGallery.Services/AccountManagement/DeleteAccountService.cs

@@ -373,7 +373,7 @@ private async Task<DeleteAccountStatus> RunAccountDeletionTask(Func<Task> getTas
                 await _featureFlagService.RemoveUserAsync(userToBeDeleted);
                 await RemoveSupportRequests(userToBeDeleted);
 
-                using (var strategy = new SuspendDbExecutionStrategy())
+                using (new SuspendDbExecutionStrategy())
                 using (var transaction = _entitiesContext.GetDatabase().BeginTransaction())
                 {
                     await getTask();

src/NuGetGallery.Services/PackageManagement/PackageOwnershipManagementService.cs

@@ -77,7 +77,7 @@ public async Task AddPackageOwnerAsync(PackageRegistration packageRegistration,
 
             if (commitChanges)
             {
-                using (var strategy = new SuspendDbExecutionStrategy())
+                using (new SuspendDbExecutionStrategy())
                 using (var transaction = _entitiesContext.GetDatabase().BeginTransaction())
                 {
                     await AddPackageOwnerTask(packageRegistration, user, commitChanges);
@@ -288,7 +288,7 @@ private async Task RemovePackageOwnerAsync(
             {
                 if (commitChanges)
                 {
-                    using (var strategy = new SuspendDbExecutionStrategy())
+                    using (new SuspendDbExecutionStrategy())
                     using (var transaction = _entitiesContext.GetDatabase().BeginTransaction())
                     {
                         await RemovePackageOwnerImplAsync(packageRegistration, ownerToBeRemoved);

src/NuGetGallery.Services/PackageManagement/PackageUpdateService.cs

@@ -58,7 +58,7 @@ public async Task UpdateListedInBulkAsync(IReadOnlyList<Package> packages, bool
                 throw new ArgumentException("All packages to change the listing status of must have the same ID.", nameof(packages));
             }
 
-            using (var strategy = new SuspendDbExecutionStrategy())
+            using (new SuspendDbExecutionStrategy())
             using (var transaction = _entitiesContext.GetDatabase().BeginTransaction())
             {
                 foreach (var package in packages)

src/NuGetGallery.Services/PackageManagement/PackageVulnerabilitiesManagementService.cs

@@ -58,7 +58,7 @@ public async Task UpdateVulnerabilityAsync(PackageVulnerability vulnerability, b
                 throw new ArgumentNullException(nameof(vulnerability));
             }
 
-            using (var strategy = new SuspendDbExecutionStrategy())
+            using (new SuspendDbExecutionStrategy())
             using (var transaction = _entitiesContext.GetDatabase().BeginTransaction())
             {
                 var packagesToUpdate = UpdateVulnerabilityInternal(vulnerability, withdrawn);

src/NuGetGallery.Services/PackageManagement/ReservedNamespaceService.cs

@@ -87,7 +87,7 @@ public async Task DeleteReservedNamespaceAsync(string existingNamespace)
                 throw new ArgumentException(ServicesStrings.ReservedNamespace_InvalidNamespace);
             }
 
-            using (var strategy = new SuspendDbExecutionStrategy())
+            using (new SuspendDbExecutionStrategy())
             using (var transaction = EntitiesContext.GetDatabase().BeginTransaction())
             {
                 var namespaceToDelete = FindReservedNamespaceForPrefix(existingNamespace)
@@ -199,7 +199,7 @@ public async Task DeleteOwnerFromReservedNamespaceAsync(string prefix, string us
             List<PackageRegistration> packageRegistrationsToMarkUnverified;
             if (commitChanges)
             {
-                using (var strategy = new SuspendDbExecutionStrategy())
+                using (new SuspendDbExecutionStrategy())
                 using (var transaction = EntitiesContext.GetDatabase().BeginTransaction())
                 {
                     packageRegistrationsToMarkUnverified = await DeleteOwnerFromReservedNamespaceImplAsync(prefix, username, namespaceToModify);

src/NuGetGallery/Controllers/AccountsController.cs

@@ -496,7 +496,7 @@ public virtual async Task<JsonResult> AddCertificate(string accountName, HttpPos
 
             try
             {
-                using (var uploadStream = uploadFile.InputStream)
+                using (uploadFile.InputStream)
                 {
                     certificate = await CertificateService.AddCertificateAsync(uploadFile);
                 }

src/NuGetGallery/Services/PackageDeleteService.cs

@@ -252,7 +252,7 @@ private async Task<bool> AreStatisticsStaleAsync()
 
         public async Task SoftDeletePackagesAsync(IEnumerable<Package> packages, User deletedBy, string reason, string signature)
         {
-            using (var strategy = new SuspendDbExecutionStrategy())
+            using (new SuspendDbExecutionStrategy())
             using (var transaction = _entitiesContext.GetDatabase().BeginTransaction())
             {
                 // Increase command timeout
@@ -322,7 +322,7 @@ await _symbolPackageService.UpdateStatusAsync(
 
         public async Task HardDeletePackagesAsync(IEnumerable<Package> packages, User deletedBy, string reason, string signature, bool deleteEmptyPackageRegistration)
         {
-            using (var strategy = new SuspendDbExecutionStrategy())
+            using (new SuspendDbExecutionStrategy())
             using (var transaction = _entitiesContext.GetDatabase().BeginTransaction())
             {
                 // Increase command timeout

src/NuGetGallery/Services/PackageDeprecationService.cs

@@ -153,7 +153,7 @@ public async Task UpdateDeprecation(
 
             if (_entitiesContext.HasChanges)
             {
-                using (var strategy = new SuspendDbExecutionStrategy())
+                using (new SuspendDbExecutionStrategy())
                 using (var transaction = _entitiesContext.GetDatabase().BeginTransaction())
                 {
                     await _entitiesContext.SaveChangesAsync();