Skip to content

Commit 5276638

Browse files
committed
Remove Atom feed functional tests that depend on 3rd party package (#6929)
This behavior is asserted by unit tests so a functional test is not strictly necessary
1 parent 651381b commit 5276638

1 file changed

Lines changed: 0 additions & 59 deletions

File tree

tests/NuGetGallery.FunctionalTests/AtomFeed/AtomFeedTests.cs

Lines changed: 0 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,11 @@
22
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
33

44
using System;
5-
using System.Linq;
65
using System.Net;
76
using System.Net.Http;
87
using System.ServiceModel.Syndication;
98
using System.Threading.Tasks;
109
using System.Xml;
11-
using NuGet.Versioning;
1210
using Xunit;
1311
using Xunit.Abstractions;
1412

@@ -47,63 +45,6 @@ public async Task IsParsableForAvailablePackage()
4745
}
4846
}
4947

50-
[Theory]
51-
[Priority(2)]
52-
[Category("P2Tests")]
53-
[InlineData(false)]
54-
[InlineData(true)]
55-
public async Task ObservesPrerelParameter(bool prerel)
56-
{
57-
// Arrange
58-
var feedUrl = new Uri(new Uri(UrlHelper.BaseUrl), $"/packages/Newtonsoft.Json/atom.xml?prerel={prerel}");
59-
60-
// Act
61-
using (var httpClient = new HttpClient())
62-
using (var response = await httpClient.GetAsync(feedUrl))
63-
{
64-
// Assert
65-
var feed = await ReadFeedAsync(response);
66-
foreach (var item in feed.Items)
67-
{
68-
var version = item.Title.Text.Split(' ').Last();
69-
Assert.True(NuGetVersion.TryParse(version, out var parsedVersion), $"The version '{version}' is not parsable.");
70-
if (!prerel)
71-
{
72-
Assert.False(parsedVersion.IsPrerelease, $"The version '{version}' should not be included since it is prerelease.");
73-
}
74-
}
75-
}
76-
}
77-
78-
[Fact]
79-
[Priority(2)]
80-
[Category("P2Tests")]
81-
public async Task DefaultsToIncludingPrerel()
82-
{
83-
// Arrange
84-
var feedUrl = new Uri(new Uri(UrlHelper.BaseUrl), $"/packages/Newtonsoft.Json/atom.xml");
85-
86-
// Act
87-
using (var httpClient = new HttpClient())
88-
using (var response = await httpClient.GetAsync(feedUrl))
89-
{
90-
// Assert
91-
var feed = await ReadFeedAsync(response);
92-
var prerelCount = 0;
93-
foreach (var item in feed.Items)
94-
{
95-
var version = item.Title.Text.Split(' ').Last();
96-
Assert.True(NuGetVersion.TryParse(version, out var parsedVersion), $"The version '{version}' is not parsable.");
97-
if (parsedVersion.IsPrerelease)
98-
{
99-
prerelCount++;
100-
}
101-
}
102-
103-
Assert.InRange(prerelCount, 1, feed.Items.Count());
104-
}
105-
}
106-
10748
[Fact]
10849
[Priority(2)]
10950
[Category("P2Tests")]

0 commit comments

Comments
 (0)