Address PR feedback: use case-insensitive Id sorting and simplify framework comparer

Co-authored-by: joelverhagen <[email protected]>

Author: Copilot

src/NuGetGallery/ViewModels/DependencySetsViewModel.cs

@@ -44,21 +44,12 @@ public DependencySetsViewModel(IEnumerable<PackageDependency> packageDependencie
                         friendlyName = framework.ToFriendlyName();
                     }
 
-                    var dependencies = dependencySet.OrderBy(x => x.Id).Select(d => d.Id == null ? null : new DependencyViewModel(d.Id, d.VersionSpec));
+                    var dependencies = dependencySet.OrderBy(x => x.Id, StringComparer.OrdinalIgnoreCase).Select(d => d.Id == null ? null : new DependencyViewModel(d.Id, d.VersionSpec));
                     frameworkGroups.Add((tfmString, framework, friendlyName, dependencies));
                 }
 
                 // Sort by framework using NuGetFrameworkSorter, with null frameworks (All Frameworks) first
-                var sortedGroups = frameworkGroups.OrderBy(g => g.framework, 
-                    Comparer<NuGetFramework>.Create((a, b) =>
-                    {
-                        // Put "All Frameworks" (null) first
-                        if (a == null && b == null) return 0;
-                        if (a == null) return -1;
-                        if (b == null) return 1;
-                        // Use NuGetFrameworkSorter for actual frameworks
-                        return NuGetFrameworkSorter.Instance.Compare(a, b);
-                    }));
+                var sortedGroups = frameworkGroups.OrderBy(g => g.framework, new NullableFrameworkComparer());
 
                 // Build the final dictionary with friendly names
                 foreach (var group in sortedGroups)
@@ -101,5 +92,18 @@ public DependencyViewModel(string id, string versionSpec)
             public string VersionSpec { get; private set; }
             public string PackageUrl { get; private set; }
         }
+
+        private class NullableFrameworkComparer : IComparer<NuGetFramework>
+        {
+            public int Compare(NuGetFramework x, NuGetFramework y)
+            {
+                // Put "All Frameworks" (null) first
+                if (x == null && y == null) return 0;
+                if (x == null) return -1;
+                if (y == null) return 1;
+                // Use NuGetFrameworkSorter for actual frameworks
+                return NuGetFrameworkSorter.Instance.Compare(x, y);
+            }
+        }
     }
 }

tests/NuGetGallery.Facts/ViewModels/DependencySetsViewModelFacts.cs

@@ -92,6 +92,32 @@ public void GivenAListOfDependenciesPackageIdsWillBeOrdered()
                 Assert.Equal("def", dependencyViewModels[3].Id);
             }
 
+            [Fact]
+            public void GivenAListOfDependenciesPackageIdsWillBeOrderedCaseInsensitively()
+            {
+                // Arrange
+                var dependencies = new[] {
+                    new PackageDependency { TargetFramework = null, Id = "Zebra" },
+                    new PackageDependency { TargetFramework = null, Id = "apple" },
+                    new PackageDependency { TargetFramework = null, Id = "Banana" },
+                    new PackageDependency { TargetFramework = null, Id = "cherry" }
+                };
+
+                // Act
+                var viewModel = new DependencySetsViewModel(dependencies);
+
+                // Assert
+                Assert.Single(viewModel.DependencySets);
+                Assert.Equal(4, viewModel.DependencySets.First().Value.Count());
+
+                var dependencyViewModels = viewModel.DependencySets.First().Value.ToList();
+
+                Assert.Equal("apple", dependencyViewModels[0].Id);
+                Assert.Equal("Banana", dependencyViewModels[1].Id);
+                Assert.Equal("cherry", dependencyViewModels[2].Id);
+                Assert.Equal("Zebra", dependencyViewModels[3].Id);
+            }
+
             [Fact]
             public void GivenAListOfDependenciesNet10WillBeOrderedAfterNet9()
             {