Skip to content

Commit 393f473

Browse files
authored
Fixed search page a11y bug (#9847)
1 parent 131bc50 commit 393f473

3 files changed

Lines changed: 20 additions & 3 deletions

File tree

src/NuGetGallery/Strings.Designer.cs

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/NuGetGallery/Strings.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1278,4 +1278,7 @@ The {1} Team</value>
12781278
<data name="SupportedFrameworks_EmptyVersion_Template_Tooltip" xml:space="preserve">
12791279
<value>This package is compatible with all versions of {0}.</value>
12801280
</data>
1281+
<data name="FrameworkFilters_Tooltip" xml:space="preserve">
1282+
<value>Filters packages based on the target frameworks they are compatible with. Click here to learn more.</value>
1283+
</data>
12811284
</root>

src/NuGetGallery/Views/Shared/ListPackages.cshtml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,11 @@
7474
@if (Model.IsAdvancedSearchFlightEnabled)
7575
{
7676
<div class="toggle-advanced-search-panel">
77-
Advanced search filters <button class ="advanced-search-toggle-button" aria-label="Toggles search filters on narrow screens" aria-expanded="false" aria-controls="advancedSearchToggleButton" tabindex="0" id="advancedSearchToggleButton" type="button">
78-
<i class="ms-Icon ms-Icon--ChevronDown" id="advancedSearchToggleChevron" ></i></button>
77+
Advanced search filters
78+
<button class="advanced-search-toggle-button" aria-label="Toggles search filters on narrow screens" aria-expanded="false"
79+
aria-controls="advancedSearchToggleButton" tabindex="0" id="advancedSearchToggleButton" type="button">
80+
<i class="ms-Icon ms-Icon--ChevronDown" id="advancedSearchToggleChevron"></i>
81+
</button>
7982
</div>
8083
<div class="row clearfix advanced-search-panel" id="advancedSearchPanel">
8184
<input type="text" hidden id="frameworks" name="frameworks" value="@Model.Frameworks">
@@ -86,7 +89,9 @@
8689
<fieldset id="frameworkfilters">
8790
<legend>
8891
Frameworks
89-
<a href="@(Model.FrameworksFilteringInformationLink)" class="frameworkfilters-info" data-content="Filters packages based on the target frameworks they are compatible with. Click here to learn more.">
92+
<a href="@(Model.FrameworksFilteringInformationLink)" class="frameworkfilters-info"
93+
data-content="@NuGetGallery.Strings.FrameworkFilters_Tooltip"
94+
aria-label="@NuGetGallery.Strings.FrameworkFilters_Tooltip">
9095
<i class="framework-filter-info-icon ms-Icon ms-Icon--Info"></i>
9196
</a>
9297
</legend>

0 commit comments

Comments
 (0)