Skip to content

Commit 2a9a353

Browse files
authored
[A11y] Fix Framework filter tooltip's confusing double behavior (#9454)
* Fixed tooltip's confusing double behavior (kinda) * removed extra tab index
1 parent 32e13ba commit 2a9a353

5 files changed

Lines changed: 3 additions & 18 deletions

File tree

src/NuGetGallery/Scripts/gallery/page-list-packages.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ $(function() {
22
'use strict';
33

44
$(".reserved-indicator").each(window.nuget.setPopovers);
5-
$(".framework-filter-info-icon").each(window.nuget.setPopovers);
65

76
const searchForm = document.forms.search;
87
const allFrameworks = document.querySelectorAll('.framework');

src/NuGetGallery/Strings.Designer.cs

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/NuGetGallery/Strings.resx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1254,7 +1254,4 @@ The {1} Team</value>
12541254
<data name="ForgotPassword_Disabled_Error" xml:space="preserve">
12551255
<value>Forgot password is disabled.</value>
12561256
</data>
1257-
<data name="FrameworkFilterInformation_Tooltip" xml:space="preserve">
1258-
<value>Filters packages based on the target frameworks included in the NuGet Package.</value>
1259-
</data>
12601257
</root>

src/NuGetGallery/ViewModels/PackageListViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,6 @@ public PackageListViewModel(
8484

8585
public Dictionary<string, FrameworkFilterHelper.FrameworkFilterGroup> FrameworkFilters = FrameworkFilterHelper.FrameworkFilters;
8686

87-
public string TargetFrameworkInformationLink = "https://learn.microsoft.com/en-us/dotnet/standard/frameworks";
87+
public string FrameworksFilteringInformationLink = "https://learn.microsoft.com/nuget/consume-packages/finding-and-choosing-packages#advanced-filtering-and-sorting";
8888
}
8989
}

src/NuGetGallery/Views/Shared/ListPackages.cshtml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,8 @@
8282
<fieldset id="frameworkfilters">
8383
<legend>
8484
Frameworks
85-
<a href="@(Model.TargetFrameworkInformationLink)" title="Frameworks filter information">
86-
<i class="framework-filter-info-icon ms-Icon ms-Icon--Info" tabindex="0"
87-
data-content="@Strings.FrameworkFilterInformation_Tooltip"
88-
alt="@Strings.FrameworkFilterInformation_Tooltip"></i>
85+
<a href="@(Model.FrameworksFilteringInformationLink)" title="Filters packages based on the target frameworks included in the NuGet Package. Click here to learn more.">
86+
<i class="framework-filter-info-icon ms-Icon ms-Icon--Info"></i>
8987
</a>
9088
</legend>
9189
@foreach (var framework in Model.FrameworkFilters.Values)

0 commit comments

Comments
 (0)