Skip to content

Commit 1eff45e

Browse files
Merge pull request #7073 from NuGet/dev
Dev to Master
2 parents 206c214 + d157ea7 commit 1eff45e

420 files changed

Lines changed: 7165 additions & 58482 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.nuget/packages.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3+
<package id="MicroBuild.Core" version="0.3.0" />
34
<package id="Microsoft.CodeAnalysis.BinSkim" version="1.3.6" />
45
<package id="xunit.runner.console" version="2.1.0" />
56
<package id="xunit.runner.visualstudio" version="2.1.0" />

build.ps1

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ param (
1010
[string]$PackageSuffix,
1111
[string]$Branch,
1212
[string]$CommitSHA,
13-
[string]$BuildBranch = '5fd8377a9abf3ff411918dbb973948a6677432db'
13+
[string]$BuildBranch = '2d8feecabe3aeaed7f5b4d50b9be78c94faf39ec'
1414
)
1515

1616
Set-StrictMode -Version 1.0
@@ -99,6 +99,11 @@ Invoke-BuildStep 'Creating artifacts' { `
9999
} `
100100
-ev +BuildErrors
101101

102+
Invoke-BuildStep 'Signing the packages' {
103+
Sign-Packages -Configuration $Configuration -BuildNumber $BuildNumber -MSBuildVersion "15" `
104+
} `
105+
-ev +BuildErrors
106+
102107
Trace-Log ('-' * 60)
103108

104109
## Calculating Build time

src/Bootstrap/.gitignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,15 @@ Thumbs.db
3737
docs/.jekyll-metadata
3838

3939
# Folders to ignore
40+
/.bundle/
41+
/vendor/
4042
bower_components
4143
node_modules
4244

4345
# .map files are currently unused and minification is done by MVC.
4446
dist/css/*.map
4547
dist/css/*.min.css
4648
dist/js/*.min.js
49+
50+
# we won't be distributing Bootstrap docs
51+
docs/dist

src/Bootstrap/.travis.yml

Lines changed: 0 additions & 41 deletions
This file was deleted.

src/Bootstrap/CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
Bootstrap uses [GitHub's Releases feature](https://github.com/blog/1547-release-your-software) for its changelogs.
1+
Bootstrap uses [GitHub's Releases feature](https://blog.github.com/2013-07-02-release-your-software/) for its changelogs.
22

33
See [the Releases section of our GitHub project](https://github.com/twbs/bootstrap/releases) for changelogs for each release version of Bootstrap.
44

5-
Release announcement posts on [the official Bootstrap blog](http://blog.getbootstrap.com) contain summaries of the most noteworthy changes made in each release.
5+
Release announcement posts on [the official Bootstrap blog](https://blog.getbootstrap.com/) contain summaries of the most noteworthy changes made in each release.

src/Bootstrap/CONTRIBUTING.md

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ restrictions:
2525
respect the opinions of others.
2626

2727
* Please **do not** post comments consisting solely of "+1" or ":thumbsup:".
28-
Use [GitHub's "reactions" feature](https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments)
28+
Use [GitHub's "reactions" feature](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/)
2929
instead. We reserve the right to delete comments which violate this rule.
3030

3131
* Please **do not** open issues or pull requests regarding the code in
3232
[`Normalize`](https://github.com/necolas/normalize.css) (open them in
3333
their respective repositories).
3434

35-
* Please **do not** open issues regarding the official themes offered on <http://themes.getbootstrap.com/>.
35+
* Please **do not** open issues regarding the official themes offered on <https://themes.getbootstrap.com/>.
3636
Instead, please email any questions or feedback regarding those themes to `themes AT getbootstrap DOT com`.
3737

3838

@@ -62,7 +62,7 @@ Good bug reports are extremely helpful, so thanks!
6262

6363
Guidelines for bug reports:
6464

65-
0. **Validate and lint your code** &mdash; [validate your HTML](http://html5.validator.nu)
65+
0. **Validate and lint your code** &mdash; [validate your HTML](https://html5.validator.nu/)
6666
and [lint your HTML](https://github.com/twbs/bootlint) to ensure your
6767
problem isn't caused by a simple error in your own code.
6868

@@ -105,7 +105,7 @@ Example:
105105
### Reporting upstream browser bugs
106106

107107
Sometimes bugs reported to us are actually caused by bugs in the browser(s) themselves, not bugs in Bootstrap per se.
108-
When feasible, we aim to report such upstream bugs to the relevant browser vendor(s), and then list them on our [Wall of Browser Bugs](http://getbootstrap.com/browser-bugs/) and [document them in MDN](https://developer.mozilla.org/en-US/docs/Web).
108+
When feasible, we aim to report such upstream bugs to the relevant browser vendor(s), and then list them on our [Wall of Browser Bugs](https://getbootstrap.com/docs/3.4/browser-bugs/) and [document them in MDN](https://developer.mozilla.org/en-US/docs/Web).
109109

110110
| Vendor(s) | Browser(s) | Rendering engine | Bug reporting website(s) | Notes |
111111
| ------------- | ---------------------------- | ---------------- | ------------------------------------------------------------------------------------- | -------------------------------------------------------- |
@@ -199,7 +199,7 @@ included in the project:
199199
4. Commit your changes in logical chunks. Please adhere to these [git commit
200200
message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
201201
or your code is unlikely to be merged into the main project. Use Git's
202-
[interactive rebase](https://help.github.com/articles/interactive-rebase)
202+
[interactive rebase](https://help.github.com/articles/about-git-rebase/)
203203
feature to tidy up your commits before making them public.
204204

205205
5. Locally merge (or rebase) the upstream development branch into your topic branch:
@@ -223,16 +223,6 @@ includes code changes) and under the terms of the
223223
[Creative Commons Attribution 3.0 Unported License](docs/LICENSE)
224224
(if it includes documentation changes).
225225

226-
### Pull request bots
227-
228-
[@twbs-rorschach](https://github.com/twbs-rorschach) is a Bootstrap bot that hangs out in our GitHub issue tracker and automatically checks all pull requests for a few simple common mistakes. It's possible that Rorschach might leave a comment on your pull request and then close it. If that happens, simply fix the problem(s) mentioned in the comment (there should be link(s) in the comment explaining the problem(s) in detail) and then either:
229-
230-
* Push the revised version to your pull request's branch and post a comment on the pull request saying that you've fixed the problem(s). One of the Bootstrap Core Team members will then come along and reopen your pull request.
231-
* Or you can just open a new pull request for your revised version.
232-
233-
[@twbs-savage](https://github.com/twbs-savage) is a Bootstrap bot that automatically runs cross-browser tests (via [Sauce](https://saucelabs.com) and Travis CI) on JavaScript pull requests. Savage will leave a comment on pull requests stating whether cross-browser JS tests passed or failed, with a link to the full Travis build details. If your pull request fails, check the Travis log to see which browser + OS combinations failed. Each browser test in the Travis log includes a link to a Sauce page with details about the test. On those details pages, you can watch a screencast of the test run to see exactly which unit tests failed.
234-
235-
236226
## Code guidelines
237227

238228
### HTML
@@ -247,16 +237,16 @@ includes code changes) and under the terms of the
247237

248238
[Adhere to the Code Guide.](http://codeguide.co/#css)
249239

250-
- When feasible, default color palettes should comply with [WCAG color contrast guidelines](http://www.w3.org/TR/WCAG20/#visual-audio-contrast).
251-
- Except in rare cases, don't remove default `:focus` styles (via e.g. `outline: none;`) without providing alternative styles. See [this A11Y Project post](http://a11yproject.com/posts/never-remove-css-outlines) for more details.
240+
- When feasible, default color palettes should comply with [WCAG color contrast guidelines](https://www.w3.org/TR/WCAG20/#visual-audio-contrast).
241+
- Except in rare cases, don't remove default `:focus` styles (via e.g. `outline: none;`) without providing alternative styles. See [this A11Y Project post](https://a11yproject.com/posts/never-remove-css-outlines/) for more details.
252242

253243
### JS
254244

255245
- No semicolons (in client-side JS)
256246
- 2 spaces (no tabs)
257247
- strict mode
258248
- "Attractive"
259-
- Don't use [jQuery event alias convenience methods](https://github.com/jquery/jquery/blob/master/src/event/alias.js) (such as `$().focus()`). Instead, use [`$().trigger(eventType, ...)`](http://api.jquery.com/trigger/) or [`$().on(eventType, ...)`](http://api.jquery.com/on/), depending on whether you're firing an event or listening for an event. (For example, `$().trigger('focus')` or `$().on('focus', function (event) { /* handle focus event */ })`) We do this to be compatible with custom builds of jQuery where the event aliases module has been excluded.
249+
- Don't use [jQuery event alias convenience methods](https://github.com/jquery/jquery/blob/master/src/event/alias.js) (such as `$().focus()`). Instead, use [`$().trigger(eventType, ...)`](https://api.jquery.com/trigger/) or [`$().on(eventType, ...)`](https://api.jquery.com/on/), depending on whether you're firing an event or listening for an event. (For example, `$().trigger('focus')` or `$().on('focus', function (event) { /* handle focus event */ })`) We do this to be compatible with custom builds of jQuery where the event aliases module has been excluded.
260250

261251
### Checking coding style
262252

0 commit comments

Comments
 (0)