[Upload UI]: Improve experience when package has no license (#9038)

* Improve warning if package has no license

* Tweak

* Tweak

Author: loic-sharma

src/NuGetGallery/NuGetGallery.csproj

@@ -331,6 +331,7 @@
     <Compile Include="Modules\CookieComplianceHttpModule.cs" />
     <Compile Include="RequestModels\DeletePackagesApiRequest.cs" />
     <Compile Include="RequestModels\UpdateListedRequest.cs" />
+    <Compile Include="Services\MissingLicenseValidationMessage.cs" />
     <Compile Include="Services\UploadPackageIdNamespaceConflict.cs" />
     <Compile Include="Services\ImageDomainValidator.cs" />
     <Compile Include="Services\IMarkdownService.cs" />

src/NuGetGallery/Services/InvalidLicenseUrlValidationMessage.cs

@@ -11,7 +11,7 @@ namespace NuGetGallery
     /// </summary>
     public class InvalidLicenseUrlValidationMessage : IValidationMessage
     {
-        private string DetailsLink => $"<a href=\"https://aka.ms/invalidNuGetLicenseUrl\" aria-label= \"{Strings.UploadPackage_LearMore_PackagingLicense}\">{Strings.UploadPackage_LearnMore}</a>.";
+        private string DetailsLink => $"<a href=\"https://aka.ms/invalidNuGetLicenseUrl\" aria-label= \"{Strings.UploadPackage_LearnMore_PackagingLicense}\">{Strings.UploadPackage_LearnMore}</a>.";
         private string DetailsPlainText => "https://aka.ms/invalidNuGetLicenseUrl";
 
         private readonly string _baseMessage;

src/NuGetGallery/Services/LicenseUrlDeprecationValidationMessage.cs

@@ -12,7 +12,7 @@ namespace NuGetGallery
     /// </summary>
     public class LicenseUrlDeprecationValidationMessage : IValidationMessage
     {
-        private string DeprecationLink => $"<a href=\"{GalleryConstants.LicenseDeprecationUrl}\" aria-label= \"{Strings.UploadPackage_LearnMore_LicenseUrlDreprecation}\">{Strings.UploadPackage_LearnMore}</a>.";
+        private string DeprecationLink => $"<a href=\"{GalleryConstants.LicenseDeprecationUrl}\" aria-label=\"{Strings.UploadPackage_LearnMore_LicenseUrlDreprecation}\">{Strings.UploadPackage_LearnMore}</a>.";
 
         private readonly string _baseMessage;
 

src/NuGetGallery/Services/MissingLicenseValidationMessage.cs

@@ -0,0 +1,38 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System;
+using System.Globalization;
+using System.Web;
+
+namespace NuGetGallery
+{
+    /// <summary>
+    /// A warning for packages that are missing licensing metadata.
+    /// </summary>
+    public class MissingLicenseValidationMessage : IValidationMessage
+    {
+        private string DocumentationLink => $"<a href=\"https://aka.ms/nuget/authoring-best-practices#licensing\" aria-label=\"{Strings.UploadPackage_LearnMore_PackagingLicense}\">{Strings.UploadPackage_LearnMore}</a>.";
+
+        private readonly string _baseMessage;
+
+        public MissingLicenseValidationMessage(string basePlainTextMessage)
+        {
+            if (string.IsNullOrWhiteSpace(basePlainTextMessage))
+            {
+                throw new ArgumentException(
+                    string.Format(CultureInfo.CurrentCulture, Strings.ParameterCannotBeNullOrEmpty, nameof(basePlainTextMessage)), nameof(basePlainTextMessage));
+            }
+
+            _baseMessage = basePlainTextMessage;
+            PlainTextMessage = $"{_baseMessage} {Strings.UploadPackage_LearnMore}: https://aka.ms/nuget/authoring-best-practices#licensing.";
+        }
+
+        public string PlainTextMessage { get; }
+
+        public bool HasRawHtmlRepresentation => true;
+
+        public string RawHtmlMessage
+            => HttpUtility.HtmlEncode(_baseMessage) + " " + DocumentationLink;
+    }
+}

src/NuGetGallery/Services/PackageMetadataValidationService.cs

@@ -211,7 +211,7 @@ private async Task<PackageValidationResult> CheckLicenseMetadataAsync(PackageArc
                     }
                     else
                     {
-                        warnings.Add(new LicenseUrlDeprecationValidationMessage(Strings.UploadPackage_LicenseShouldBeSpecified));
+                        warnings.Add(new MissingLicenseValidationMessage(Strings.UploadPackage_LicenseShouldBeSpecified));
                     }
                 }
 

src/NuGetGallery/Strings.Designer.cs

@@ -1190,7 +1190,7 @@ The {1} Team</value>
   <data name="ReadmeNotEditableWithEmbeddedReadme" xml:space="preserve">
     <value>The readme is not editable with the package has the embedded readme</value>
   </data>
-  <data name="UploadPackage_LearMore_PackagingLicense" xml:space="preserve">
+  <data name="UploadPackage_LearnMore_PackagingLicense" xml:space="preserve">
     <value>Learn more about including a license within the package</value>
   </data>
   <data name="UploadPackage_LearnMore_IconUrlDeprecation" xml:space="preserve">

src/NuGetGallery/Strings.resx

@@ -437,7 +437,7 @@ public async Task HandlesMissingLicenseAccordingToSettings(bool allowLicenseless
                     Assert.Equal(PackageValidationResultType.Accepted, result.Type);
                     Assert.Null(result.Message);
                     Assert.Single(result.Warnings);
-                    Assert.IsType<LicenseUrlDeprecationValidationMessage>(result.Warnings[0]);
+                    Assert.IsType<MissingLicenseValidationMessage>(result.Warnings[0]);
                     Assert.StartsWith("All published packages should have license information specified.", result.Warnings[0].PlainTextMessage);
                 }
             }