Cookie expiration fix (#10626) (#10627)

* Fix

* Fixed tests

Author: Lanaparezanin

src/NuGetGallery/Infrastructure/CookieTempDataProvider.cs

@@ -94,8 +94,16 @@ protected virtual IDictionary<string, object> LoadTempData(ControllerContext con
                 //silently ignore incorrect cookie values
             }
 
-            cookie.Expires = DateTime.MinValue;
-            cookie.Value = String.Empty;
+            if (_httpContext.Response != null && _httpContext.Response.Cookies != null)
+            {
+                var responseCookie = _httpContext.Response.Cookies.Get(TempDataCookieKey);
+                if (responseCookie != null)
+                {
+                    responseCookie.Expires = DateTime.MinValue;
+                    responseCookie.Value = String.Empty;
+                }
+            }
+
             return dictionary;
         }
 

tests/NuGetGallery.Facts/Infrastructure/CookieTempDataProviderFacts.cs

@@ -178,6 +178,7 @@ public void WithInitialStateAndNoValuesClearsCookie()
                 cookie["message"] = "clear";
                 var httpContext = new Mock<HttpContextBase>();
                 httpContext.Setup(c => c.Request.Cookies).Returns(cookies);
+                httpContext.Setup(c => c.Response.Cookies).Returns(cookies);
                 ITempDataProvider provider = new CookieTempDataProvider(httpContext.Object);
                 var controllerContext = new ControllerContext();