Remove automatic and manual package curation (#6483)

Remove curated feed search UI (OData is still supported)
Address #6469

Author: joelverhagen

src/Bootstrap/dist/css/bootstrap-theme.css

@@ -16,7 +16,6 @@
 @import "page-forgot-password.less";
 @import "page-home.less";
 @import "page-list-packages.less";
-@import "page-manage-curated-feed.less";
 @import "page-manage-organizations.less";
 @import "page-manage-owners.less";
 @import "page-manage-packages.less";

src/Bootstrap/less/theme/all.less

@@ -405,23 +405,6 @@ protected override void Load(ContainerBuilder builder)
                 .AsSelf()
                 .InstancePerLifetimeScope();
 
-            // todo: bind all package curators by convention
-            builder.RegisterType<WebMatrixPackageCurator>()
-                .AsSelf()
-                .As<IAutomaticPackageCurator>()
-                .InstancePerLifetimeScope();
-
-            builder.RegisterType<Windows8PackageCurator>()
-                .AsSelf()
-                .As<IAutomaticPackageCurator>()
-                .InstancePerLifetimeScope();
-
-            // todo: bind all commands by convention
-            builder.RegisterType<AutomaticallyCuratePackageCommand>()
-                .AsSelf()
-                .As<IAutomaticallyCuratePackageCommand>()
-                .InstancePerLifetimeScope();
-
             if (configuration.Current.Environment == Constants.DevelopmentEnvironment)
             {
                 builder.RegisterType<AllowLocalHttpRedirectPolicy>()

src/Bootstrap/less/theme/page-manage-curated-feed.less

@@ -533,31 +533,6 @@ public static void RegisterUIRoutes(RouteCollection routes)
                 new { controller = "Organizations", action = "ChangeEmailSubscription" },
                 new RouteExtensions.ObfuscatedPathMetadata(1, Obfuscator.DefaultTelemetryUserName));
 
-            routes.MapRoute(
-                RouteName.CuratedFeed,
-                "curated-feeds/{name}",
-                new { controller = "CuratedFeeds", action = "CuratedFeed" });
-
-            routes.MapRoute(
-                RouteName.CuratedFeedListPackages,
-                "curated-feeds/{curatedFeedName}/packages",
-                new { controller = "CuratedFeeds", action = "ListPackages" });
-
-            routes.MapRoute(
-                RouteName.CreateCuratedPackageForm,
-                "forms/add-package-to-curated-feed",
-                new { controller = "CuratedPackages", action = "CreateCuratedPackageForm" });
-
-            routes.MapRoute(
-                RouteName.CuratedPackage,
-                "curated-feeds/{curatedFeedName}/curated-packages/{curatedPackageId}",
-                new { controller = "CuratedPackages", action = "CuratedPackage" });
-
-            routes.MapRoute(
-                RouteName.CuratedPackages,
-                "curated-feeds/{curatedFeedName}/curated-packages",
-                new { controller = "CuratedPackages", action = "CuratedPackages" });
-
             routes.MapRoute(
                 RouteName.Downloads,
                 "downloads",

src/NuGetGallery/App_Start/DefaultDependenciesModule.cs

@@ -29,8 +29,6 @@ public class ViewMessages
 
         public AuthenticationService AuthenticationService { get; }
 
-        public ICuratedFeedService CuratedFeedService { get; }
-
         public IPackageService PackageService { get; }
 
         public IMessageService MessageService { get; }
@@ -47,7 +45,6 @@ public class ViewMessages
 
         public AccountsController(
             AuthenticationService authenticationService,
-            ICuratedFeedService curatedFeedService,
             IPackageService packageService,
             IMessageService messageService,
             IUserService userService,
@@ -57,7 +54,6 @@ public AccountsController(
             IContentObjectService contentObjectService)
         {
             AuthenticationService = authenticationService ?? throw new ArgumentNullException(nameof(authenticationService));
-            CuratedFeedService = curatedFeedService ?? throw new ArgumentNullException(nameof(curatedFeedService));
             PackageService = packageService ?? throw new ArgumentNullException(nameof(packageService));
             MessageService = messageService ?? throw new ArgumentNullException(nameof(messageService));
             UserService = userService ?? throw new ArgumentNullException(nameof(userService));
@@ -344,11 +340,6 @@ protected virtual void UpdateAccountViewModel(TUser account, TAccountViewModel m
             model.IsCertificatesUIEnabled = ContentObjectService.CertificatesConfiguration?.IsUIEnabledForUser(currentUser) ?? false;
             model.WasMultiFactorAuthenticated = User.WasMultiFactorAuthenticated();
 
-            model.CuratedFeeds = CuratedFeedService
-                .GetFeedsForManager(account.Key)
-                .Select(f => f.Name)
-                .ToList();
-
             model.HasPassword = account.Credentials.Any(c => c.IsPassword());
             model.CurrentEmailAddress = account.UnconfirmedEmailAddress ?? account.EmailAddress;
             model.HasConfirmedEmailAddress = !string.IsNullOrEmpty(account.EmailAddress);

src/NuGetGallery/App_Start/Routes.cs

@@ -43,7 +43,6 @@ public partial class ApiController
         public IContentService ContentService { get; set; }
         public ISearchService SearchService { get; set; }
         public IIndexingService IndexingService { get; set; }
-        public IAutomaticallyCuratePackageCommand AutoCuratePackage { get; set; }
         public IStatusService StatusService { get; set; }
         public IMessageService MessageService { get; set; }
         public IAuditingService AuditingService { get; set; }
@@ -72,7 +71,6 @@ public ApiController(
             IContentService contentService,
             IIndexingService indexingService,
             ISearchService searchService,
-            IAutomaticallyCuratePackageCommand autoCuratePackage,
             IStatusService statusService,
             IMessageService messageService,
             IAuditingService auditingService,
@@ -95,7 +93,6 @@ public ApiController(
             ContentService = contentService;
             IndexingService = indexingService;
             SearchService = searchService;
-            AutoCuratePackage = autoCuratePackage;
             StatusService = statusService;
             MessageService = messageService;
             AuditingService = auditingService;
@@ -120,7 +117,6 @@ public ApiController(
             IContentService contentService,
             IIndexingService indexingService,
             ISearchService searchService,
-            IAutomaticallyCuratePackageCommand autoCuratePackage,
             IStatusService statusService,
             IStatisticsService statisticsService,
             IMessageService messageService,
@@ -136,7 +132,7 @@ public ApiController(
             ISymbolPackageFileService symbolPackageFileService,
             ISymbolPackageUploadService symbolPackageUploadServivce)
             : this(apiScopeEvaluator, entitiesContext, packageService, packageFileService, userService, contentService,
-                  indexingService, searchService, autoCuratePackage, statusService, messageService, auditingService,
+                  indexingService, searchService, statusService, messageService, auditingService,
                   configurationService, telemetryService, authenticationService, credentialBuilder, securityPolicies,
                   reservedNamespaceService, packageUploadService, packageDeleteService, symbolPackageFileService, 
                   symbolPackageUploadServivce)
@@ -656,8 +652,6 @@ await PackageDeleteService.HardDeletePackagesAsync(
                                 return afterValidationActionResult;
                             }
 
-                            await AutoCuratePackage.ExecuteAsync(package, packageToPush, commitChanges: false);
-
                             PackageCommitResult commitResult;
                             using (Stream uploadStream = packageStream)
                             {