Skip to content

Commit 0587485

Browse files
authored
Small fixes to the framework filters (#9842)
1 parent 36b34a6 commit 0587485

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/NuGetGallery/Scripts/gallery/page-list-packages.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,4 +207,5 @@ $(function() {
207207
$(".frameworkfiltermode-info").each(window.nuget.setPopovers);
208208
$(".framework-badge-asset").each(window.nuget.setPopovers);
209209
$(".framework-badge-computed").each(window.nuget.setPopovers);
210+
$(".frameworkfilters-info").each(window.nuget.setPopovers);
210211
});

src/NuGetGallery/Views/Shared/ListPackages.cshtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,21 +86,21 @@
8686
<fieldset id="frameworkfilters">
8787
<legend>
8888
Frameworks
89-
<a href="@(Model.FrameworksFilteringInformationLink)" title="Filters packages based on the target frameworks included in the NuGet Package. Click here to learn more.">
89+
<a href="@(Model.FrameworksFilteringInformationLink)" class="frameworkfilters-info" data-content="Filters packages based on the target frameworks they are compatible with. Click here to learn more.">
9090
<i class="framework-filter-info-icon ms-Icon ms-Icon--Info"></i>
9191
</a>
9292
</legend>
9393
@if (Model.IsAdvancedFrameworkFilteringEnabled)
9494
{
9595
<div class="computed-frameworks-option">
96-
<label for="computed-frameworks-checkbox" aria-label="Include computed frameworks when filtering for packages.">Include computed frameworks</label>
96+
<label for="computed-frameworks-checkbox" aria-label="Include computed compatible frameworks when filtering for packages.">Include compatible frameworks</label>
9797
<input type="checkbox" id="computed-frameworks-checkbox" checked="@Model.IncludeComputedFrameworks">
9898
<input type="hidden" id="includeComputedFrameworks" name="includeComputedFrameworks" value="@Model.IncludeComputedFrameworks.ToString().ToLower()">
9999
</div>
100100
<div class="framework-filter-mode-option" aria-label="ALL/ANY toggle that decides whether to show packages matching ALL of the selected Target Frameworks (TFMs), or ANY of them.">
101101
<p>
102102
Framework Filter Mode
103-
<i class="frameworkfiltermode-info ms-Icon ms-Icon--Info" data-content="Decides whether to show packages matching ALL of the selected Target Frameworks (TFMs), or ANY of them."></i>
103+
<i class="frameworkfiltermode-info ms-Icon ms-Icon--Info" tabindex="0" data-content="Decides whether to show packages matching ALL of the selected Target Frameworks (TFMs), or ANY of them."></i>
104104
</p>
105105
<div class="toggle-switch-control">
106106
<input type="radio" id="all-selector" name="frameworkFilterMode" value="all" tabindex="0" @(Model.FrameworkFilterMode == "any" ? "" : "checked") />

0 commit comments

Comments
 (0)