Uploading large packages result in OutOfMemoryException

NuGet/NuGetGallery#3042

Author: maartenba

src/NuGet.Server/Infrastructure/ServerPackageRepository.cs

@@ -186,7 +186,7 @@ private void AddPackagesFromDropFolder()
                     try
                     {
                         // Create package
-                        var package = new ZipPackage(_fileSystem.OpenFile(packageFile));
+                        var package = new OptimizedZipPackage(_fileSystem, packageFile);
 
                         // Is it a symbols package?
                         if (IgnoreSymbolsPackages && package.IsSymbolsPackage())
@@ -235,6 +235,8 @@ private void AddPackagesFromDropFolder()
             }
             finally
             {
+                OptimizedZipPackage.PurgeCache();
+
                 MonitorFileSystem(true);
             }
         }
@@ -552,6 +554,8 @@ public void ClearCache()
             {
                 lock (_syncLock)
                 {
+                    OptimizedZipPackage.PurgeCache();
+
                     _serverPackageStore.Clear();
                     _serverPackageStore.Persist();
                     _logger.Log(LogLevel.Info, "Cleared package cache.");

src/NuGet.Server/Publishing/PackageService.cs

@@ -32,23 +32,43 @@ public void CreatePackage(HttpContextBase context)
 
             // Get the package from the request body
             // ReSharper disable once PossibleNullReferenceException
-            var stream = request.Files.Count > 0 ? request.Files[0].InputStream : request.InputStream;
+            var stream = request.Files.Count > 0
+                ? request.Files[0].InputStream 
+                : request.InputStream;
 
-            var package = new ZipPackage(stream);
+            // Copy the package to a temporary file
+            var temporaryFile = Path.GetTempFileName();
+            using (var temporaryFileStream = File.Open(temporaryFile, FileMode.OpenOrCreate, FileAccess.ReadWrite))
+            {
+                stream.CopyTo(temporaryFileStream);
+            }
+
+            var package = new OptimizedZipPackage(temporaryFile);
 
-            // Make sure they can access this package
+            // Make sure the user can access this package
             if (Authenticate(context, apiKey, package.Id))
             {
                 try
                 {
                     _serverRepository.AddPackage(package);
+
                     WriteStatus(context, HttpStatusCode.Created, "");
                 }
                 catch (InvalidOperationException ex)
                 {
                     WriteStatus(context, HttpStatusCode.InternalServerError, ex.Message);
                 }
             }
+
+            package = null;
+            try
+            {
+                File.Delete(temporaryFile);
+            }
+            catch (Exception)
+            {
+                WriteStatus(context, HttpStatusCode.InternalServerError, "Could not remove temporary upload file.");
+            }
         }
 
         public void PublishPackage(HttpContextBase context)