Refactor ExpandedPackageRepository out of ServerPackageRepository (#26)

Split a lot of logic out of ServerPackageRepository into another class so concerns are easier to understand
Add testing around package removal (both unlisting on and off).
Clean up implementations so we don't need to as cast IServerPackage to ServerPackage (strengthening the IServerPackage API)
Add missing test for NuGet/NuGetGallery#3277
Remove dead code.
Clean up some inconsistently styled code

Author: joelverhagen

src/NuGet.Server.Core/DataServices/ODataPackage.cs

@@ -1,16 +1,10 @@
 // Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. 
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
 using System;
-using System.Data.Services.Common;
 
 namespace NuGet.Server.Core.DataServices
 {
-    [DataServiceKey("Id", "Version")]
-    [EntityPropertyMapping("Id", SyndicationItemProperty.Title, SyndicationTextContentKind.Plaintext, keepInContent: false)]
-    [EntityPropertyMapping("Authors", SyndicationItemProperty.AuthorName, SyndicationTextContentKind.Plaintext, keepInContent: false)]
-    [EntityPropertyMapping("LastUpdated", SyndicationItemProperty.Updated, SyndicationTextContentKind.Plaintext, keepInContent: false)]
-    [EntityPropertyMapping("Summary", SyndicationItemProperty.Summary, SyndicationTextContentKind.Plaintext, keepInContent: false)]
-    [HasStream]
     public class ODataPackage
     {
         public string Id { get; set; }

src/NuGet.Server.Core/DataServices/PackageContext.cs

@@ -0,0 +1,31 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System.Collections.Generic;
+
+namespace NuGet.Server.Core.Infrastructure
+{
+    /// <summary>
+    /// This interface provides a relatively high performance view of the packages available on the server. The default
+    /// implementation of this interface stores package metadata in memory and persists it to disk as a JSON file, which
+    /// is much faster to read than opening up all of the .nupkg each time their metadata is needed.
+    /// </summary>
+    public interface IServerPackageCache
+    {
+        bool IsEmpty();
+
+        IEnumerable<ServerPackage> GetAll();
+
+        void Add(ServerPackage entity);
+
+        void AddRange(IEnumerable<ServerPackage> entities);
+
+        void Remove(string id, SemanticVersion version, bool enableDelisting);
+
+        void Persist();
+
+        void PersistIfDirty();
+
+        void Clear();
+    }
+}

src/NuGet.Server.Core/Infrastructure/IServerPackageCache.cs

@@ -3,7 +3,6 @@
 
 using System.Collections.Generic;
 using System.Linq;
-using System.Runtime.Versioning;
 
 namespace NuGet.Server.Core.Infrastructure
 {
@@ -15,13 +14,6 @@ public interface IServerPackageRepository
 
         IQueryable<IServerPackage> GetPackages();
 
-        IEnumerable<IServerPackage> GetUpdates(
-            IEnumerable<IPackageName> packages,
-            bool includePrerelease,
-            bool includeAllVersions,
-            IEnumerable<FrameworkName> targetFrameworks,
-            IEnumerable<IVersionSpec> versionConstraints);
-
         IQueryable<IServerPackage> Search(
             string searchTerm,
             IEnumerable<string> targetFrameworks,

src/NuGet.Server.Core/Infrastructure/IServerPackageRepository.cs

@@ -1,20 +1,23 @@
-// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. 
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
 using System.Collections.Generic;
-using System.Linq;
 
 namespace NuGet.Server.Core.Infrastructure
 {
+    /// <summary>
+    /// This interface provides a way to add and remove packages from disk. This store is meant to be the definitive
+    /// collection of packages available. If the metadata cache (see <see cref="IServerPackageCache"/>) is out of date
+    /// or corrupted, all metadata should be able to be rebuilt by enumerating a reading packages in this store.
+    /// </summary>
     public interface IServerPackageStore
     {
-        bool HasPackages();
-        IQueryable<ServerPackage> GetAll();
-        void Store(ServerPackage entity);
-        void StoreRange(IEnumerable<ServerPackage> entities);
-        void Remove(ServerPackage entity);
-        void Remove(string id, SemanticVersion version);
-        void Persist();
-        void PersistIfDirty();
-        void Clear();
+        ServerPackage Add(IPackage package, bool enableDelisting);
+
+        bool Exists(string id, SemanticVersion version);
+
+        HashSet<ServerPackage> GetAll(bool enableDelisting);
+
+        void Remove(string id, SemanticVersion version, bool enableDelisting);
     }
 }

src/NuGet.Server.Core/Infrastructure/IServerPackageStore.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Collections.Generic;
 using System.Globalization;
-using System.IO;
 using System.Linq;
 using System.Runtime.Versioning;
 using Newtonsoft.Json;
@@ -19,75 +18,8 @@ public ServerPackage()
         }
 
         public ServerPackage(
-            string id,
-            SemanticVersion version,
-            string title,
-            IEnumerable<string> authors,
-            IEnumerable<string> owners,
-            Uri iconUrl,
-            Uri licenseUrl,
-            Uri projectUrl,
-            bool requireLicenseAcceptance,
-            bool developmentDependency,
-            string description,
-            string summary,
-            string releaseNotes, 
-            string language, 
-            string tags, 
-            string copyright, 
-            string dependencies, 
-            Version minClientVersion, 
-            Uri reportAbuseUrl, 
-            int downloadCount, 
-            string supportedFrameworks, 
-            bool isAbsoluteLatestVersion, 
-            bool isLatestVersion, 
-            bool listed, 
-            DateTimeOffset? published, 
-            long packageSize,
-            string packageHash, 
-            string packageHashAlgorithm, 
-            DateTimeOffset lastUpdated, 
-            DateTimeOffset created,
-            string fullPath)
-        {
-            Id = id;
-            Version = version;
-            Title = title;
-            Authors = authors;
-            Owners = owners;
-            IconUrl = iconUrl;
-            LicenseUrl = licenseUrl;
-            ProjectUrl = projectUrl;
-            RequireLicenseAcceptance = requireLicenseAcceptance;
-            DevelopmentDependency = developmentDependency;
-            Description = description;
-            Summary = summary;
-            ReleaseNotes = releaseNotes;
-            Language = language;
-            Tags = tags;
-            Copyright = copyright;
-            Dependencies = dependencies;
-            MinClientVersion = minClientVersion;
-            ReportAbuseUrl = reportAbuseUrl;
-            DownloadCount = downloadCount;
-            SupportedFrameworks = supportedFrameworks;
-            IsAbsoluteLatestVersion = isAbsoluteLatestVersion;
-            IsLatestVersion = isLatestVersion;
-            Listed = listed;
-            PackageSize = packageSize;
-            PackageHash = packageHash;
-            PackageHashAlgorithm = packageHashAlgorithm;
-            LastUpdated = lastUpdated;
-            Created = created;
-            FullPath = fullPath;
-
-            // Preload collections
-            DependencySets.Any();
-            SupportedFrameworks.Any();
-        }
-
-        public ServerPackage(IPackage package, PackageDerivedData packageDerivedData)
+            IPackage package,
+            PackageDerivedData packageDerivedData)
         {
             Id = package.Id;
             Version = package.Version;