Do not overwrite packages when scanning drop folder for new packages

Author: maartenba

src/NuGet.Server/Infrastructure/ServerPackageRepository.cs

@@ -186,8 +186,20 @@ private void AddPackagesFromDropFolder()
                 {
                     try
                     {
-                        // Copy to correct filesystem location
+                        // Create package
                         var package = new ZipPackage(_fileSystem.OpenFile(packageFile));
+
+                        // Allow overwriting package? If not, skip this one.
+                        if (!AllowOverrideExistingPackageOnPush && _expandedPackageRepository.FindPackage(package.Id, package.Version) != null)
+                        {
+                            var message = string.Format(NuGetResources.Error_PackageAlreadyExists, package);
+
+                            _logger.Log(LogLevel.Error, message);
+
+                            continue;
+                        }
+
+                        // Copy to correct filesystem location
                         _expandedPackageRepository.AddPackage(package);
                         _fileSystem.DeleteFile(packageFile);
 

src/NuGet.Server/Web.config

@@ -6,41 +6,41 @@
 <configuration>
   <appSettings>
     <!--
-            Determines if an Api Key is required to push\delete packages from the server. 
+    Determines if an Api Key is required to push\delete packages from the server. 
     -->
     <add key="requireApiKey" value="true" />
 
     <!-- 
-            Set the value here to allow people to push/delete packages from the server.
-            NOTE: This is a shared key (password) for all users.
+    Set the value here to allow people to push/delete packages from the server.
+    NOTE: This is a shared key (password) for all users.
     -->
     <add key="apiKey" value="" />
 
     <!--
-            Change the path to the packages folder. Default is ~/Packages.
-            This can be a virtual or physical path.
+    Change the path to the packages folder. Default is ~/Packages.
+    This can be a virtual or physical path.
     -->
     <add key="packagesPath" value="" />
 
     <!--
-            Set allowOverrideExistingPackageOnPush to false if attempts to upload a package that already exists
-            (same id and same version) should fail.
+    Set allowOverrideExistingPackageOnPush to false if attempts to upload a package that already exists
+    (same id and same version) should fail.
     -->
-    <add key="allowOverrideExistingPackageOnPush" value="true" />
+    <add key="allowOverrideExistingPackageOnPush" value="false" />
 
     <!--
-            Set enableDelisting to true to enable delist instead of delete as a result of a "nuget delete" command.
-            - delete: package is deleted from the repository's local filesystem.
-            - delist: 
-              - "nuget delete": the "hidden" file attribute of the corresponding nupkg on the repository local filesystem is turned on instead of deleting the file.
-              - "nuget list" skips delisted packages, i.e. those that have the hidden attribute set on their nupkg.
-              - "nuget install packageid -version version" command will succeed for both listed and delisted packages.
-                 e.g. delisted packages can still be downloaded by clients that explicitly specify their version.
+    Set enableDelisting to true to enable delist instead of delete as a result of a "nuget delete" command.
+    - delete: package is deleted from the repository's local filesystem.
+    - delist: 
+      - "nuget delete": the "hidden" file attribute of the corresponding nupkg on the repository local filesystem is turned on instead of deleting the file.
+      - "nuget list" skips delisted packages, i.e. those that have the hidden attribute set on their nupkg.
+      - "nuget install packageid -version version" command will succeed for both listed and delisted packages.
+        e.g. delisted packages can still be downloaded by clients that explicitly specify their version.
     -->
     <add key="enableDelisting" value="false" />
-    
+
     <!--
-      Set enableFrameworkFiltering to true to enable filtering packages by their supported frameworks during search.
+    Set enableFrameworkFiltering to true to enable filtering packages by their supported frameworks during search.
     -->
     <add key="enableFrameworkFiltering" value="false" />
   </appSettings>