NuGet.Server error processing dropped package when ignoreSymbolsPackages=false NuGet/NuGetGallery#3069

maartenba · maartenba · commit 4271a8418c57 · 2016-06-14T12:25:02.000+02:00
diff --git a/src/NuGet.Server/Infrastructure/ServerPackageRepository.cs b/src/NuGet.Server/Infrastructure/ServerPackageRepository.cs
@@ -210,10 +210,12 @@ private void AddPackagesFromDropFolder()
 
                         // Copy to correct filesystem location
                         _expandedPackageRepository.AddPackage(package);
-                        _fileSystem.DeleteFile(packageFile);
 
                         // Mark for addition to metadata store
                         serverPackages.Add(CreateServerPackage(package, EnableDelisting));
+
+                        // Remove file from drop folder
+                        _fileSystem.DeleteFile(packageFile);
                     }
                     catch (UnauthorizedAccessException ex)
                     {

Original file line number	Diff line number	Diff line change
`@@ -210,10 +210,12 @@ private void AddPackagesFromDropFolder()`
`210`	`210`
`211`	`211`	`// Copy to correct filesystem location`
`212`	`212`	`_expandedPackageRepository.AddPackage(package);`
`213`		`- _fileSystem.DeleteFile(packageFile);`
`214`	`213`
`215`	`214`	`// Mark for addition to metadata store`
`216`	`215`	`serverPackages.Add(CreateServerPackage(package, EnableDelisting));`
	`216`	`+`
	`217`	`+ // Remove file from drop folder`
	`218`	`+ _fileSystem.DeleteFile(packageFile);`
`217`	`219`	`}`
`218`	`220`	`catch (UnauthorizedAccessException ex)`
`219`	`221`	`{`