[Package Signing] Add telemetry to Validate Certificate (#337)

Author: loic-sharma

src/Validation.PackageSigning.ValidateCertificate/CertificateValidationService.cs

@@ -6,7 +6,6 @@
 using System.Data.Entity;
 using System.Data.Entity.Infrastructure;
 using System.Linq;
-using System.Security.Cryptography.X509Certificates;
 using System.Threading.Tasks;
 using Microsoft.Extensions.Logging;
 using NuGet.Jobs.Validation.PackageSigning.Messages;

src/Validation.PackageSigning.ValidateCertificate/Job.cs

@@ -6,6 +6,7 @@
 using System.Threading.Tasks;
 using Autofac;
 using Autofac.Extensions.DependencyInjection;
+using Microsoft.ApplicationInsights;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
@@ -151,6 +152,7 @@ private void ConfigureJobServices(IServiceCollection services, IConfigurationRoo
             services.AddTransient<ICertificateVerifier, OnlineCertificateVerifier>();
             services.AddTransient<ICertificateValidationService, CertificateValidationService>();
             services.AddTransient<ITelemetryService, TelemetryService>();
+            services.AddSingleton(new TelemetryClient());
         }
 
         private static IServiceProvider CreateProvider(IServiceCollection services)

src/Validation.PackageSigning.ValidateCertificate/TelemetryService.cs

@@ -2,28 +2,67 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
+using System.Collections.Generic;
+using Microsoft.ApplicationInsights;
 using NuGet.Services.Validation;
 
 namespace Validation.PackageSigning.ValidateCertificate
 {
     public class TelemetryService : ITelemetryService
     {
+        private const string PackageSignatureMayBeInvalidated = "PackageSignatureMayBeInvalidated";
+        private const string PackageSignatureShouldBeInvalidated = "PackageSignatureShouldBeInvalidated";
+        private const string UnableToValidateCertificate = "UnableToValidateCertificate";
+
+        private const string PackageId = "PackageId";
+        private const string PackageNormalizedVersion = "PackageNormalizedVersion";
+        private const string PackageSignatureId = "PackageSignatureId";
+        private const string CertificateId = "CertificateId";
+        private const string CertificateThumbprint = "CertificateThumbprint";
+
+        private readonly TelemetryClient _telemetryClient;
+
+        public TelemetryService(TelemetryClient telemetryClient)
+        {
+            _telemetryClient = telemetryClient ?? throw new ArgumentNullException(nameof(telemetryClient));
+        }
+
         public void TrackPackageSignatureMayBeInvalidatedEvent(PackageSignature signature)
         {
-            // TODO
-            throw new NotImplementedException();
+            _telemetryClient.TrackMetric(
+                PackageSignatureMayBeInvalidated,
+                1,
+                new Dictionary<string, string>
+                {
+                    { PackageId, signature.PackageSigningState.PackageId },
+                    { PackageNormalizedVersion, signature.PackageSigningState.PackageNormalizedVersion },
+                    { PackageSignatureId, signature.Key.ToString() }
+                });
         }
 
         public void TrackPackageSignatureShouldBeInvalidatedEvent(PackageSignature signature)
         {
-            // TODO
-            throw new NotImplementedException();
+            _telemetryClient.TrackMetric(
+                PackageSignatureShouldBeInvalidated,
+                1,
+                new Dictionary<string, string>
+                {
+                    { PackageId, signature.PackageSigningState.PackageId },
+                    { PackageNormalizedVersion, signature.PackageSigningState.PackageNormalizedVersion },
+                    { PackageSignatureId, signature.Key.ToString() }
+                });
         }
 
         public void TrackUnableToValidateCertificateEvent(EndCertificate certificate)
         {
-            // TODO
-            throw new NotImplementedException();
+            _telemetryClient.TrackMetric(
+                PackageSignatureMayBeInvalidated,
+                1,
+                new Dictionary<string, string>
+                {
+                    { CertificateId, certificate.Key.ToString() },
+                    { CertificateThumbprint, certificate.Thumbprint }
+                });
         }
     }
 }

src/Validation.PackageSigning.ValidateCertificate/Validation.PackageSigning.ValidateCertificate.csproj

@@ -88,6 +88,9 @@
     <PackageReference Include="Autofac.Extensions.DependencyInjection">
       <Version>4.2.0</Version>
     </PackageReference>
+    <PackageReference Include="Microsoft.ApplicationInsights">
+      <Version>2.2.0</Version>
+    </PackageReference>
     <PackageReference Include="Microsoft.Extensions.Configuration">
       <Version>1.1.2</Version>
     </PackageReference>