Integrate orchestrator telemetry with Application Insights (#319)

Address NuGet/NuGetGallery#4652

Author: joelverhagen

src/NuGet.Services.Validation.Orchestrator/Job.cs

@@ -10,6 +10,7 @@
 using Autofac;
 using Autofac.Core;
 using Autofac.Extensions.DependencyInjection;
+using Microsoft.ApplicationInsights;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
@@ -22,6 +23,7 @@
 using NuGet.Jobs.Validation.PackageSigning.Storage;
 using NuGet.Services.Configuration;
 using NuGet.Services.KeyVault;
+using NuGet.Services.Logging;
 using NuGet.Services.ServiceBus;
 using NuGet.Services.Validation.Orchestrator.Telemetry;
 using NuGet.Services.Validation.PackageCertificates;
@@ -209,6 +211,7 @@ private void ConfigureJobServices(IServiceCollection services, IConfigurationRoo
             services.AddTransient<ICoreMessageService, CoreMessageService>();
             services.AddTransient<IMessageService, MessageService>();
             services.AddTransient<ITelemetryService, TelemetryService>();
+            services.AddSingleton(new TelemetryClient());
         }
 
         private static IServiceProvider CreateProvider(IServiceCollection services)

src/NuGet.Services.Validation.Orchestrator/Telemetry/TelemetryService.cs

@@ -2,46 +2,138 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
+using System.Collections.Generic;
+using Microsoft.ApplicationInsights;
 using NuGetGallery;
 
 namespace NuGet.Services.Validation.Orchestrator.Telemetry
 {
     public class TelemetryService : ITelemetryService
     {
+        private const string Prefix = "Orchestrator.";
+
+        private const string DurationToValidationSetCreationSeconds = Prefix + "DurationToValidationSetCreationSeconds";
+        private const string PackageStatusChange = Prefix + "PackageStatusChange";
+        private const string TotalValidationDurationSeconds = Prefix + "TotalValidationDurationSeconds";
+        private const string ValidationIssue = Prefix + "ValidationIssue";
+        private const string ValidationIssueCount = Prefix + "ValidationIssueCount";
+        private const string ValidatorTimeout = Prefix + "ValidatorTimeout";
+        private const string ValidatorDurationSeconds = Prefix + "ValidatorDurationSeconds";
+        private const string ValidatorStarted = Prefix + "ValidatorStarted";
+        private const string ClientValidationIssue = Prefix + "ClientValidationIssue";
+
+        private const string FromStatus = "FromStatus";
+        private const string ToStatus = "ToStatus";
+        private const string IsSuccess = "IsSuccess";
+        private const string ValidatorType = "ValidatorType";
+        private const string IssueCode = "IssueCode";
+        private const string ClientCode = "ClientCode";
+
+        private readonly TelemetryClient _telemetryClient;
+
+        public TelemetryService(TelemetryClient telemetryClient)
+        {
+            _telemetryClient = telemetryClient ?? throw new ArgumentNullException(nameof(telemetryClient));
+        }
+
         public void TrackDurationToValidationSetCreation(TimeSpan duration)
         {
+            _telemetryClient.TrackMetric(
+                DurationToValidationSetCreationSeconds,
+                duration.TotalSeconds);
         }
 
         public void TrackPackageStatusChange(PackageStatus fromStatus, PackageStatus toStatus)
         {
+            _telemetryClient.TrackMetric(
+                PackageStatusChange,
+                1,
+                new Dictionary<string, string>
+                {
+                    { FromStatus, fromStatus.ToString() },
+                    { ToStatus, toStatus.ToString() },
+                });
         }
 
         public void TrackTotalValidationDuration(TimeSpan duration, bool isSuccess)
         {
+            _telemetryClient.TrackMetric(
+                TotalValidationDurationSeconds,
+                duration.TotalSeconds,
+                new Dictionary<string, string>
+                {
+                    { IsSuccess, isSuccess.ToString() },
+                });
         }
 
         public void TrackValidationIssue(string validatorType, ValidationIssueCode code)
         {
+            _telemetryClient.TrackMetric(
+                ValidationIssue,
+                1,
+                new Dictionary<string, string>
+                {
+                    { ValidatorType, validatorType },
+                    { IssueCode, code.ToString() },
+                });
         }
 
         public void TrackValidationIssueCount(int count, string validatorType, bool isSuccess)
         {
+            _telemetryClient.TrackMetric(
+                ValidationIssueCount,
+                count,
+                new Dictionary<string, string>
+                {
+                    { ValidatorType, validatorType },
+                    { IsSuccess, isSuccess.ToString() },
+                });
         }
 
         public void TrackValidatorTimeout(string validatorType)
         {
+            _telemetryClient.TrackMetric(
+                ValidatorTimeout,
+                1,
+                new Dictionary<string, string>
+                {
+                    { ValidatorType, validatorType },
+                });
         }
 
         public void TrackValidatorDuration(TimeSpan duration, string validatorType, bool isSuccess)
         {
+            _telemetryClient.TrackMetric(
+                ValidatorDurationSeconds,
+                duration.TotalSeconds,
+                new Dictionary<string, string>
+                {
+                    { ValidatorType, validatorType },
+                    { IsSuccess, isSuccess.ToString() },
+                });
         }
 
         public void TrackValidatorStarted(string validatorType)
         {
+            _telemetryClient.TrackMetric(
+                ValidatorStarted,
+                1,
+                new Dictionary<string, string>
+                {
+                    { ValidatorType, validatorType },
+                });
         }
 
         public void TrackClientValidationIssue(string validatorType, string clientCode)
         {
+            _telemetryClient.TrackMetric(
+                ClientValidationIssue,
+                1,
+                new Dictionary<string, string>
+                {
+                    { ValidatorType, validatorType },
+                    { ClientCode, clientCode },
+                });
         }
     }
 }