Ignore support requests for which user data is removed when retrieving unresolved issues (#310)

* Ignore support requests for which user data is removed when retrieving unresolved issues.

* added comment

Author: xavierdecoster

src/NuGet.SupportRequests.Notifications/Job.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
-using Microsoft.Extensions.Logging;
 using NuGet.Jobs;
 
 namespace NuGet.SupportRequests.Notifications

src/NuGet.SupportRequests.Notifications/Program.cs

@@ -10,7 +10,7 @@ public class Program
         public static void Main(string[] args)
         {
             var job = new Job();
-            JobRunner.Run(job, args).Wait();
+            JobRunner.Run(job, args).GetAwaiter().GetResult();
         }
     }
 }

src/NuGet.SupportRequests.Notifications/SqlQuery.cs

@@ -7,8 +7,9 @@ internal static class SqlQuery
     {
         internal static string GetUnresolvedIssues(string onCallPagerDutyUserName = null)
         {
+            // If I.[CreatedBy] IS NULL, then the user data was deleted and the support request issue should be ignored.
             var query =
-                "SELECT I.[CreatedBy], I.[CreatedDate], I.[PackageId], I.[PackageVersion], I.[OwnerEmail], I.[Reason], I.[PackageRegistrationKey], ISNULL(A.[PagerDutyUsername], \'Unassigned\') AS \'AdminPagerDutyUsername\', ISNULL(A.[GalleryUsername], \'Unassigned\') AS \'AdminGalleryUsername\', I.[IssueStatusId] AS \'IssueStatus\' FROM [dbo].[Issues] AS I (NOLOCK) LEFT OUTER JOIN [dbo].[Admins] AS A (NOLOCK) ON I.[AssignedToId] = A.[Key] WHERE I.[IssueStatusId] <> 3 ";
+                "SELECT I.[CreatedBy], I.[CreatedDate], I.[PackageId], I.[PackageVersion], I.[OwnerEmail], I.[Reason], I.[PackageRegistrationKey], ISNULL(A.[PagerDutyUsername], \'Unassigned\') AS \'AdminPagerDutyUsername\', ISNULL(A.[GalleryUsername], \'Unassigned\') AS \'AdminGalleryUsername\', I.[IssueStatusId] AS \'IssueStatus\' FROM [dbo].[Issues] AS I (NOLOCK) LEFT OUTER JOIN [dbo].[Admins] AS A (NOLOCK) ON I.[AssignedToId] = A.[Key] WHERE I.[IssueStatusId] <> 3 AND I.[CreatedBy] IS NOT NULL";
 
             if (!string.IsNullOrEmpty(onCallPagerDutyUserName))
             {