[Package Signing] Make the Revalidate Certificate job initialize once per day (#405)

The Job infrastructure used to call the job's `Init` method on each invocation of the job loop, which caused the Revalidate job to load secrets repeatedly. This change adds the option to have a minimum wait time in between a job's `Init` calls.

Author: loic-sharma

src/NuGet.Jobs.Common/Configuration/JobArgumentNames.cs

@@ -14,6 +14,7 @@ public static class JobArgumentNames
         public const string Once = "Once";
         public const string Sleep = "Sleep";
         public const string Interval = "Interval";
+        public const string ReinitializeAfterSeconds = "ReinitializeAfterSeconds";
 
         public const string WhatIf = "WhatIf";
 

src/NuGet.Jobs.Common/JobRunner.cs

@@ -72,7 +72,9 @@ public static async Task Run(JobBase job, string[] commandLineArgs)
                 loggerFactory = ConfigureLogging(job);
 
                 var runContinuously = !JobConfigurationManager.TryGetBoolArgument(jobArgsDictionary, JobArgumentNames.Once);
+                var reinitializeAfterSeconds = JobConfigurationManager.TryGetIntArgument(jobArgsDictionary, JobArgumentNames.ReinitializeAfterSeconds);
                 var sleepDuration = JobConfigurationManager.TryGetIntArgument(jobArgsDictionary, JobArgumentNames.Sleep); // sleep is in milliseconds
+
                 if (!sleepDuration.HasValue)
                 {
                     sleepDuration = JobConfigurationManager.TryGetIntArgument(jobArgsDictionary, JobArgumentNames.Interval);
@@ -88,12 +90,19 @@ public static async Task Run(JobBase job, string[] commandLineArgs)
                     sleepDuration = 5000;
                 }
 
+                if (!reinitializeAfterSeconds.HasValue)
+                {
+                    _logger.LogInformation(
+                        $"{JobArgumentNames.ReinitializeAfterSeconds} command line argument is not provided or is not a valid integer. " +
+                        "The job will reinitialize on every iteration");
+                }
+
                 // Ensure that SSLv3 is disabled and that Tls v1.2 is enabled.
                 ServicePointManager.SecurityProtocol &= ~SecurityProtocolType.Ssl3;
                 ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls12;
 
                 // Run the job loop
-                await JobLoop(job, runContinuously, sleepDuration.Value, jobArgsDictionary);
+                await JobLoop(job, runContinuously, sleepDuration.Value, reinitializeAfterSeconds, jobArgsDictionary);
             }
             catch (Exception ex)
             {
@@ -123,22 +132,34 @@ private static string PrettyPrintTime(double milliSeconds)
                 $"'{milliSeconds:F3}' ms (or '{seconds:F3}' seconds or '{minutes:F3}' mins)";
         }
 
-        private static async Task JobLoop(JobBase job, bool runContinuously, int sleepDuration, IDictionary<string, string> jobArgsDictionary)
+        private static async Task JobLoop(
+            JobBase job,
+            bool runContinuously,
+            int sleepDuration,
+            int? reinitializeAfterSeconds,
+            IDictionary<string, string> jobArgsDictionary)
         {
             // Run the job now
             var stopWatch = new Stopwatch();
+            Stopwatch timeSinceInitialization = null;
 
             while (true)
             {
                 _logger.LogInformation("Running {RunType}", (runContinuously ? " continuously..." : " once..."));
                 _logger.LogInformation("SleepDuration is {SleepDuration}", PrettyPrintTime(sleepDuration));
                 _logger.LogInformation("Job run started...");
-                
+
                 var initialized = false;
                 stopWatch.Restart();
+
                 try
                 {
-                    job.Init(jobArgsDictionary);
+                    if (ShouldInitialize(reinitializeAfterSeconds, timeSinceInitialization))
+                    {
+                        job.Init(jobArgsDictionary);
+                        timeSinceInitialization = Stopwatch.StartNew();
+                    }
+
                     initialized = true;
 
                     await job.Run();
@@ -169,5 +190,23 @@ private static async Task JobLoop(JobBase job, bool runContinuously, int sleepDu
                 await Task.Delay(sleepDuration);
             }
         }
+
+        private static bool ShouldInitialize(int? reinitializeAfterSeconds, Stopwatch timeSinceInitialization)
+        {
+            // If there is no wait time between reinitializations, always reinitialize.
+            if (!reinitializeAfterSeconds.HasValue)
+            {
+                return true;
+            }
+
+            // A null time since last initialization indicates that the job hasn't been initialized yet.
+            if (timeSinceInitialization == null)
+            {
+                return true;
+            }
+
+            // Otherwise, only reinitialize if the reinitialization threshold has been reached.
+            return (timeSinceInitialization.Elapsed.TotalSeconds > reinitializeAfterSeconds.Value);
+        }
     }
 }

src/Validation.PackageSigning.RevalidateCertificate/Scripts/Validation.PackageSigning.RevalidateCertificate.cmd

@@ -9,7 +9,8 @@ title #{Jobs.validation.packagesigning.revalidatecertificate.Title}
 
 start /w Validation.PackageSigning.RevalidateCertificate.exe ^
     -Configuration #{Jobs.validation.packagesigning.revalidatecertificate.Configuration} ^
-    -InstrumentationKey "#{Jobs.validation.packagesigning.revalidatecertificate.InstrumentationKey}"
+    -InstrumentationKey "#{Jobs.validation.packagesigning.revalidatecertificate.InstrumentationKey}" ^
+    -ReinitializeAfterSeconds 86400
 
 echo "Finished #{Jobs.validation.packagesigning.revalidatecertificate.Title}"