Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Commit 77a4e36

Browse files
committed
Fixing file system watcher leak for PackageLag monitor.
1 parent 8a3b27d commit 77a4e36

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/PackageLagMonitor/Job.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ public class Job : JobBase
4040
private ICatalogClient _catalogClient;
4141
private IServiceProvider _serviceProvider;
4242
private PackageLagMonitorConfiguration _configuration;
43+
private IConfigurationBuilder _builder = null;
4344

4445
public override void Init(IServiceContainer serviceContainer, IDictionary<string, string> jobArgsDictionary)
4546
{
@@ -60,19 +61,19 @@ private IConfigurationRoot GetConfigurationRoot(string configurationFilename)
6061
Logger.LogInformation("Using the {ConfigurationFilename} configuration file", configurationFilename);
6162
var builder = new ConfigurationBuilder()
6263
.SetBasePath(Environment.CurrentDirectory)
63-
.AddJsonFile(configurationFilename, optional: false, reloadOnChange: true);
64+
.AddJsonFile(configurationFilename, optional: false, reloadOnChange: false);
6465

6566
var uninjectedConfiguration = builder.Build();
6667

6768
var secretReaderFactory = new ConfigurationRootSecretReaderFactory(uninjectedConfiguration);
6869
var cachingSecretReaderFactory = new CachingSecretReaderFactory(secretReaderFactory, KeyVaultSecretCachingTimeout);
6970
var secretInjector = cachingSecretReaderFactory.CreateSecretInjector(cachingSecretReaderFactory.CreateSecretReader());
7071

71-
builder = new ConfigurationBuilder()
72+
var injectedBuilder = new ConfigurationBuilder()
7273
.SetBasePath(Environment.CurrentDirectory)
7374
.AddInjectedJsonFile(configurationFilename, secretInjector);
7475

75-
return builder.Build();
76+
return injectedBuilder.Build();
7677
}
7778

7879
private IServiceProvider GetServiceProvider(IConfigurationRoot configurationRoot)

0 commit comments

Comments
 (0)