Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Commit 6050fc6

Browse files
authored
Add log on user notification (#379)
This can already be seen today by joining traces with custom metrics, but that isn't very convenient.
1 parent 9a4cf1c commit 6050fc6

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

src/NuGet.Services.Validation.Orchestrator/ValidationOutcomeProcessor.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,11 +148,16 @@ public async Task ProcessValidationOutcomeAsync(PackageValidationSet validationS
148148
previousDuration <= _validationConfiguration.ValidationSetNotificationTimeout &&
149149
await _validationStorageService.GetValidationSetCountAsync(package.Key) == 1)
150150
{
151+
_logger.LogWarning("Sending message that validation set {ValidationTrackingId} for package {PackageId} {PackageVersion} is taking too long",
152+
validationSet.ValidationTrackingId,
153+
validationSet.PackageId,
154+
validationSet.PackageNormalizedVersion);
155+
151156
_messageService.SendPackageValidationTakingTooLongMessage(package);
152157
_telemetryService.TrackSentValidationTakingTooLongMessage(package.PackageRegistration.Id, package.NormalizedVersion, validationSet.ValidationTrackingId);
153158
}
154159

155-
// Track any validations that have timed out.
160+
// Track any validations that are past their expected thresholds.
156161
var timedOutValidations = GetIncompleteTimedOutValidations(validationSet);
157162

158163
if (timedOutValidations.Any())

0 commit comments

Comments
 (0)