List -> IReadOnlyList for the EnqueueScanAndSignAsync parameter (#462)

agr · web-flow · commit 477de266cc9e · 2018-06-07T12:03:44.000-07:00
diff --git a/src/Validation.ScanAndSign.Core/IScanAndSignEnqueuer.cs b/src/Validation.ScanAndSign.Core/IScanAndSignEnqueuer.cs
@@ -23,6 +23,6 @@ public interface IScanAndSignEnqueuer
         /// <param name="nupkgUrl">Url of the package to scan and sign.</param>
         /// <param name="v3ServiceIndexUrl">The service index URL that should be put on the package's repository signature.</param>
         /// <param name="owners">The list of owners that should be put on the package's repository signature.</param>
-        Task EnqueueScanAndSignAsync(Guid validationId, string nupkgUrl, string v3ServiceIndexUrl, List<string> owners);
+        Task EnqueueScanAndSignAsync(Guid validationId, string nupkgUrl, string v3ServiceIndexUrl, IReadOnlyList<string> owners);
     }
 }
diff --git a/src/Validation.ScanAndSign.Core/ScanAndSignEnqueuer.cs b/src/Validation.ScanAndSign.Core/ScanAndSignEnqueuer.cs
@@ -53,7 +53,7 @@ public Task EnqueueScanAsync(Guid validationId, string nupkgUrl)
                     new Uri(nupkgUrl)));
         }
 
-        public Task EnqueueScanAndSignAsync(Guid validationId, string nupkgUrl, string v3ServiceIndexUrl, List<string> owners)
+        public Task EnqueueScanAndSignAsync(Guid validationId, string nupkgUrl, string v3ServiceIndexUrl, IReadOnlyList<string> owners)
         {
             if (nupkgUrl == null)
             {

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,6 @@ public interface IScanAndSignEnqueuer`
`23`	`23`	`/// <param name="nupkgUrl">Url of the package to scan and sign.</param>`
`24`	`24`	`/// <param name="v3ServiceIndexUrl">The service index URL that should be put on the package's repository signature.</param>`
`25`	`25`	`/// <param name="owners">The list of owners that should be put on the package's repository signature.</param>`
`26`		`- Task EnqueueScanAndSignAsync(Guid validationId, string nupkgUrl, string v3ServiceIndexUrl, List<string> owners);`
	`26`	`+ Task EnqueueScanAndSignAsync(Guid validationId, string nupkgUrl, string v3ServiceIndexUrl, IReadOnlyList<string> owners);`
`27`	`27`	`}`
`28`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public Task EnqueueScanAsync(Guid validationId, string nupkgUrl)`
`53`	`53`	`new Uri(nupkgUrl)));`
`54`	`54`	`}`
`55`	`55`
`56`		`- public Task EnqueueScanAndSignAsync(Guid validationId, string nupkgUrl, string v3ServiceIndexUrl, List<string> owners)`
	`56`	`+ public Task EnqueueScanAndSignAsync(Guid validationId, string nupkgUrl, string v3ServiceIndexUrl, IReadOnlyList<string> owners)`
`57`	`57`	`{`
`58`	`58`	`if (nupkgUrl == null)`
`59`	`59`	`{`