Added configurable batch size for the scan requests dequeuing (#287)

* Added configurable batch size for the scan requests dequeuing

* Actually passing the `BatchSize` argument to the job.

* Indentation fix.
Constant added.

Author: agr

src/NuGet.Jobs.Common/Configuration/JobArgumentNames.cs

@@ -101,6 +101,7 @@ public static class JobArgumentNames
         public const string RunValidationTasks = "RunValidationTasks";
         public const string RequestValidationTasks = "RequestValidationTasks";
         public const string PackageUrlTemplate = "PackageUrlTemplate";
+        public const string BatchSize = "BatchSize";
 
         // Arguments specific to VCS validation task
         public const string VcsValidatorServiceUrl = "VcsValidatorServiceUrl";

src/Validation.Runner/Job.cs

@@ -19,13 +19,15 @@ namespace NuGet.Jobs.Validation.Runner
     public class Job
         : JobBase
     {
+        private const int DefaultBatchSize = 10;
         private readonly List<IValidator> _validators = new List<IValidator>();
 
         private string _galleryBaseAddress;
         private CloudStorageAccount _cloudStorageAccount;
         private string _containerName;
         private string[] _runValidationTasks;
         private string[] _requestValidationTasks;
+        private int _batchSize;
 
         public override void Init(IDictionary<string, string> jobArgsDictionary)
         {
@@ -38,6 +40,7 @@ public override void Init(IDictionary<string, string> jobArgsDictionary)
 
             _runValidationTasks = JobConfigurationManager.GetArgument(jobArgsDictionary, JobArgumentNames.RunValidationTasks).Split(';');
             _requestValidationTasks = JobConfigurationManager.GetArgument(jobArgsDictionary, JobArgumentNames.RequestValidationTasks).Split(';');
+            _batchSize = JobConfigurationManager.TryGetIntArgument(jobArgsDictionary, JobArgumentNames.BatchSize) ?? DefaultBatchSize;
 
             // Add validators
             if (_runValidationTasks.Contains(VcsValidator.ValidatorName))
@@ -128,7 +131,7 @@ private async Task RunValidationsAsync(IValidator validator)
             var notificationService = new NotificationService(_cloudStorageAccount, _containerName);
 
             // Get messages to process
-            var messages = await packageValidationQueue.DequeueAsync(validator.Name, 16, validator.VisibilityTimeout);
+            var messages = await packageValidationQueue.DequeueAsync(validator.Name, _batchSize, validator.VisibilityTimeout);
             foreach (var message in messages)
             {
                 // Audit entry collection to which our validator can write

src/Validation.Runner/Scripts/Validation.Runner.cmd

@@ -23,7 +23,8 @@ start /w Validation.Runner.exe ^
     -verbose true ^
     -Interval #{Jobs.validation.Interval} ^
     -InstrumentationKey "#{Jobs.validation.ApplicationInsightsInstrumentationKey}" ^
-    -VcsContactAlias "#{Jobs.validation.NugetVcsContactAlias}"
+    -VcsContactAlias "#{Jobs.validation.NugetVcsContactAlias}" ^
+    -BatchSize "#{Jobs.validation.BatchSize}"
 
 echo "Finished #{Jobs.validation.Title}"