Skip to content

Commit f6f19d7

Browse files
elantiguamsftCopilot
elantiguamsft
and
Copilot
committed
Rename --allow-untrusted-signing to --allow-untrusted-root
Align CLI flag naming with existing dotnet nuget trust --allow-untrusted-root per reviewer feedback. Renames: - dotnet CLI: --allow-untrusted-signing -> --allow-untrusted-root - nuget.exe: -AllowUntrustedSigning -> -AllowUntrustedRoot - Resource keys: SignCommandAllowUntrustedSigningDescription -> SignCommandAllowUntrustedRootDescription Internal API property names (AllowUntrustedRoot on SignArgs, SignPackageRequest, CertificateSourceOptions) are unchanged - they were already correct. Co-authored-by: Copilot <[email protected]>
1 parent 3e442cc commit f6f19d7

34 files changed

Lines changed: 71 additions & 71 deletions

‎src/NuGet.Clients/NuGet.CommandLine/Commands/SignCommand.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ public SignCommand() : base()
6060
[Option(typeof(NuGetCommand), "SignCommandOverwriteDescription")]
6161
public bool Overwrite { get; set; }
6262

63-
[Option(typeof(NuGetCommand), "SignCommandAllowUntrustedSigningDescription")]
64-
public bool AllowUntrustedSigning { get; set; }
63+
[Option(typeof(NuGetCommand), "SignCommandAllowUntrustedRootDescription")]
64+
public bool AllowUntrustedRoot { get; set; }
6565

6666
public override async Task ExecuteCommandAsync()
6767
{
@@ -105,7 +105,7 @@ public SignArgs GetSignArgs()
105105
SignatureHashAlgorithm = hashAlgorithm,
106106
Logger = Console,
107107
Overwrite = Overwrite,
108-
AllowUntrustedRoot = AllowUntrustedSigning,
108+
AllowUntrustedRoot = AllowUntrustedRoot,
109109
NonInteractive = NonInteractive,
110110
Timestamper = Timestamper,
111111
TimestampHashAlgorithm = timestampHashAlgorithm,

‎src/NuGet.Clients/NuGet.CommandLine/NuGetCommand.Designer.cs‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/NuGet.Clients/NuGet.CommandLine/NuGetCommand.resx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,7 @@ nuget sign MyPackage.nupkg -CertificateFingerprint certificate_fingerprint -Outp
698698
<data name="SignCommandOverwriteDescription" xml:space="preserve">
699699
<value>Switch to indicate if the current signature should be overwritten. By default the command will fail if the package already has a signature.</value>
700700
</data>
701-
<data name="SignCommandAllowUntrustedSigningDescription" xml:space="preserve">
701+
<data name="SignCommandAllowUntrustedRootDescription" xml:space="preserve">
702702
<value>Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</value>
703703
</data>
704704
<data name="SignCommandHashAlgorithmDescription" xml:space="preserve">

‎src/NuGet.Clients/NuGet.CommandLine/xlf/NuGetCommand.cs.xlf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
33
<file datatype="xml" source-language="en" target-language="cs" original="../NuGetCommand.resx">
44
<body>
@@ -909,7 +909,7 @@ nuget setapikey 4003d786-cc37-4004-bfdf-c4f3e8ef9b3a -Source http://example.com/
909909
<target state="translated">&lt;API key&gt; [možnosti]</target>
910910
<note />
911911
</trans-unit>
912-
<trans-unit id="SignCommandAllowUntrustedSigningDescription">
912+
<trans-unit id="SignCommandAllowUntrustedRootDescription">
913913
<source>Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</source>
914914
<target state="new">Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</target>
915915
<note />

‎src/NuGet.Clients/NuGet.CommandLine/xlf/NuGetCommand.de.xlf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
33
<file datatype="xml" source-language="en" target-language="de" original="../NuGetCommand.resx">
44
<body>
@@ -909,7 +909,7 @@ nuget setapikey 4003d786-cc37-4004-bfdf-c4f3e8ef9b3a -Source http://example.com/
909909
<target state="translated">&lt;API key&gt; [options]</target>
910910
<note />
911911
</trans-unit>
912-
<trans-unit id="SignCommandAllowUntrustedSigningDescription">
912+
<trans-unit id="SignCommandAllowUntrustedRootDescription">
913913
<source>Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</source>
914914
<target state="new">Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</target>
915915
<note />

‎src/NuGet.Clients/NuGet.CommandLine/xlf/NuGetCommand.es.xlf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
33
<file datatype="xml" source-language="en" target-language="es" original="../NuGetCommand.resx">
44
<body>
@@ -909,7 +909,7 @@ nuget setapikey 4003d786-cc37-4004-bfdf-c4f3e8ef9b3a -Source http://example.com/
909909
<target state="translated">&lt;API key&gt; [options]</target>
910910
<note />
911911
</trans-unit>
912-
<trans-unit id="SignCommandAllowUntrustedSigningDescription">
912+
<trans-unit id="SignCommandAllowUntrustedRootDescription">
913913
<source>Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</source>
914914
<target state="new">Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</target>
915915
<note />

‎src/NuGet.Clients/NuGet.CommandLine/xlf/NuGetCommand.fr.xlf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
33
<file datatype="xml" source-language="en" target-language="fr" original="../NuGetCommand.resx">
44
<body>
@@ -909,7 +909,7 @@ nuget setapikey 4003d786-cc37-4004-bfdf-c4f3e8ef9b3a -Source http://example.com/
909909
<target state="translated">&lt;API key&gt; [options]</target>
910910
<note />
911911
</trans-unit>
912-
<trans-unit id="SignCommandAllowUntrustedSigningDescription">
912+
<trans-unit id="SignCommandAllowUntrustedRootDescription">
913913
<source>Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</source>
914914
<target state="new">Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</target>
915915
<note />

‎src/NuGet.Clients/NuGet.CommandLine/xlf/NuGetCommand.it.xlf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
33
<file datatype="xml" source-language="en" target-language="it" original="../NuGetCommand.resx">
44
<body>
@@ -909,7 +909,7 @@ nuget setapikey 4003d786-cc37-4004-bfdf-c4f3e8ef9b3a -Source http://example.com/
909909
<target state="translated">&lt;API key&gt; [opzioni]</target>
910910
<note />
911911
</trans-unit>
912-
<trans-unit id="SignCommandAllowUntrustedSigningDescription">
912+
<trans-unit id="SignCommandAllowUntrustedRootDescription">
913913
<source>Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</source>
914914
<target state="new">Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</target>
915915
<note />

‎src/NuGet.Clients/NuGet.CommandLine/xlf/NuGetCommand.ja.xlf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
33
<file datatype="xml" source-language="en" target-language="ja" original="../NuGetCommand.resx">
44
<body>
@@ -909,7 +909,7 @@ nuget setapikey 4003d786-cc37-4004-bfdf-c4f3e8ef9b3a -Source http://example.com/
909909
<target state="translated">&lt;API key&gt; [オプション]</target>
910910
<note />
911911
</trans-unit>
912-
<trans-unit id="SignCommandAllowUntrustedSigningDescription">
912+
<trans-unit id="SignCommandAllowUntrustedRootDescription">
913913
<source>Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</source>
914914
<target state="new">Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</target>
915915
<note />

‎src/NuGet.Clients/NuGet.CommandLine/xlf/NuGetCommand.ko.xlf‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
33
<file datatype="xml" source-language="en" target-language="ko" original="../NuGetCommand.resx">
44
<body>
@@ -909,7 +909,7 @@ nuget setapikey 4003d786-cc37-4004-bfdf-c4f3e8ef9feedb3a -Source http://example.
909909
<target state="translated">&lt;API 키&gt; [옵션]</target>
910910
<note />
911911
</trans-unit>
912-
<trans-unit id="SignCommandAllowUntrustedSigningDescription">
912+
<trans-unit id="SignCommandAllowUntrustedRootDescription">
913913
<source>Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</source>
914914
<target state="new">Allow signing with certificates whose root certificate is not in a trusted root store. The certificate chain is still built and validated for structure, but UntrustedRoot status is treated as a warning.</target>
915915
<note />

0 commit comments

Comments
 (0)