Correct message in the case that a higher version of package is already installed (#5743)

Author: hickford

src/NuGet.Clients/NuGet.CommandLine/Commands/InstallCommand.cs

@@ -350,18 +350,30 @@ private async Task InstallPackageAsync(
                     PackageSaveMode = EffectivePackageSaveMode;
                 }
 
-                // Check if the package already exists or a higher version exists already.
-                var skipInstall = project.PackageExists(packageIdentity, PackageSaveMode);
+                var exactVersionExists = project.PackageExists(packageIdentity, PackageSaveMode);
+                var higherVersionExists = alreadyInstalledVersions.Any(e => e >= version);
 
-                // For SxS allow other versions to install. For non-SxS skip if a higher version exists.
-                skipInstall |= (ExcludeVersion && alreadyInstalledVersions.Any(e => e >= version));
+                // For SxS skip if exact version exists. For non-SxS skip if a higher version exists.
+                var skipInstall = exactVersionExists || (ExcludeVersion && higherVersionExists);
 
                 if (skipInstall)
                 {
-                    var message = string.Format(
-                        CultureInfo.CurrentCulture,
-                        LocalizedResourceManager.GetString("InstallCommandPackageAlreadyExists"),
-                        packageIdentity);
+                    string message;
+                    if (exactVersionExists)
+                    {
+                        message = string.Format(
+                            CultureInfo.CurrentCulture,
+                            LocalizedResourceManager.GetString("InstallCommandPackageAlreadyExists"),
+                            packageIdentity);
+                    }
+                    else
+                    {
+                        var higherPackageIdentity = new PackageIdentity(packageId, alreadyInstalledVersions.FirstOrDefault(e => e >= version));
+                        message = string.Format(
+                            CultureInfo.CurrentCulture,
+                            LocalizedResourceManager.GetString("InstallCommandHigherVersionAlreadyExists"),
+                            packageIdentity, higherPackageIdentity);
+                    }
 
                     Console.LogMinimal(message);
                 }

src/NuGet.Clients/NuGet.CommandLine/NuGetResources.Designer.cs

@@ -303,6 +303,9 @@
   <data name="InstallCommandPackageAlreadyExists" xml:space="preserve">
     <value>Package "{0}" is already installed.</value>
   </data>
+  <data name="InstallCommandHigherVersionAlreadyExists" xml:space="preserve">
+    <value>Skipping installation of package "{0}" because higher version "{1}" is already installed.</value>
+  </data>
   <data name="PackageCommandNoFilesForLibPackage" xml:space="preserve">
     <value>Failed to build package. Ensure '{0}' includes assembly files. For help on building symbols package, visit {1}.</value>
   </data>

src/NuGet.Clients/NuGet.CommandLine/NuGetResources.resx

@@ -854,6 +854,35 @@ public void InstallCommand_PackageSaveModeNuspecReinstall()
             }
         }
 
+        [Fact]
+        public void InstallCommand_ExcludeVersion_HigherVersionAlreadyInstalled()
+        {
+            using (var pathContext = new SimpleTestPathContext())
+            {
+                var outputDirectory = pathContext.SolutionRoot;
+                var source = pathContext.PackageSource;
+                // Arrange
+                PackageCreator.CreatePackage("testPackage", "1.2.0", source);
+                PackageCreator.CreatePackage("testPackage", "1.1.0", source);
+
+                // Act
+                var r = RunInstall(pathContext, "testPackage", 0, new[] { "-OutputDirectory", outputDirectory, "-ExcludeVersion", "-Version", "1.2.0" });
+
+                // Assert
+                Assert.Equal(0, r.ExitCode);
+
+                // Act
+                var result = RunInstall(pathContext, "testPackage", 0, new[] { "-OutputDirectory", outputDirectory, "-ExcludeVersion", "-Version", "1.1.0" });
+
+                var output = result.Output;
+
+                // Assert
+                var alreadyInstalledMessage = string.Format(CultureInfo.CurrentCulture, NuGetResources.InstallCommandHigherVersionAlreadyExists, "testPackage.1.1.0", "testPackage.1.2.0");
+                Assert.Contains(alreadyInstalledMessage, output, StringComparison.OrdinalIgnoreCase);
+                r.ExitCode.Should().Be(0);
+            }
+        }
+
         // Test that PackageSaveMode specified in nuget.config file is used.
         [Fact]
         public void InstallCommand_PackageSaveModeInConfigFile()