Skip to content

Commit dff890b

Browse files
committed
Fix OptProf in release/7.0.x (#6861)
1 parent fb12995 commit dff890b

6 files changed

Lines changed: 12 additions & 16 deletions

File tree

eng/pipelines/official.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ variables:
5656
RunTestsOnLinux: ${{ parameters.RunTestsOnLinux }}
5757
RunTestsOnMac: ${{ parameters.RunTestsOnMac }}
5858
RunMonoTestsOnMac: ${{ parameters.RunMonoTestsOnMac }}
59+
SourceBranch: $[replace(variables['Build.SourceBranch'], 'refs/heads/', '')]
5960

6061
extends:
6162
template: azure-pipelines/MicroBuild.1ES.Official.yml@MicroBuildTemplate

eng/pipelines/optprof.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ stages:
130130
}
131131
catch {
132132
Write-Host $_
133-
Write-Error "Failed to set SourceBranchName pipeline variable"
133+
Write-Error "Failed to set RunSettingsURI pipeline variable"
134134
throw
135135
}
136136
displayName: 'Set RunSettingsURI variable'
@@ -146,7 +146,7 @@ stages:
146146
arguments: -BootstrapperInfoJsonURI '$(Pipeline.Workspace)\ComponentBuildUnderTest\MicroBuildOutputs\BootstrapperInfo.json' -VSBranch '$(VSBranch)' -OutVariableName 'VisualStudio.InstallationUnderTest.BootstrapperURL'
147147
# Remove this step hook and it's task if you don't want LKG support
148148
prePublishOptimizationInputsDropStepList:
149-
# Set parameter for PreviousOptimizationInputsDropName
149+
# Set parameter for PreviousOptimizationInputsDropName
150150
- powershell: |
151151
try {
152152
$artifactName = 'OptProf'
@@ -159,7 +159,7 @@ stages:
159159
160160
Write-Host "The content of the metadata.json file was $json"
161161
$dropname = $json.OptimizationData
162-
162+
163163
Write-Host "PreviousOptimizationInputsDropName: $dropname"
164164
Set-AzurePipelinesVariable 'PreviousOptimizationInputsDropName' $dropname
165165
}

eng/pipelines/pull_request.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ resources:
4545
type: git
4646
name: 1ESPipelineTemplates/MicroBuildTemplate
4747
ref: refs/tags/release
48+
4849
variables:
4950
BINLOG_DIRECTORY: $(Build.StagingDirectory)/binlog
5051
DOTNET_NOLOGO: 1
@@ -58,6 +59,8 @@ variables:
5859
RunTestsOnLinux: ${{ parameters.RunTestsOnLinux }}
5960
RunTestsOnMac: ${{ parameters.RunTestsOnMac }}
6061
RunMonoTestsOnMac: ${{ parameters.RunMonoTestsOnMac }}
62+
SourceBranch: $[replace(variables['Build.SourceBranch'], 'refs/heads/', '')]
63+
6164
extends:
6265
template: azure-pipelines/MicroBuild.1ES.Unofficial.yml@MicroBuildTemplate
6366
parameters:

eng/pipelines/templates/Build_and_UnitTest.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ steps:
1515
- task: PowerShell@1
1616
inputs:
1717
scriptName: "$(Build.Repository.LocalPath)\\scripts\\cibuild\\ConfigureVstsBuild.ps1"
18-
arguments: "-BuildRTM $(BuildRTM) -RepositoryPath $(Build.Repository.LocalPath) -BranchName $(Build.SourceBranchName) -CommitHash $(Build.SourceVersion) -BuildNumber $(Build.BuildNumber)"
18+
arguments: "-BuildRTM $(BuildRTM) -RepositoryPath $(Build.Repository.LocalPath) -BranchName $(SourceBranch) -CommitHash $(Build.SourceVersion) -BuildNumber $(Build.BuildNumber)"
1919
displayName: "Configure VSTS CI Environment"
2020

2121
- task: PowerShell@1
@@ -306,7 +306,7 @@ steps:
306306
displayName: "Generate .runsettings files"
307307
inputs:
308308
solution: 'build\runsettings.proj'
309-
msbuildArguments: '/restore:false /property:OutputPath="$(Build.Repository.LocalPath)\artifacts\RunSettings" /property:TestDrop="RunSettings/$(System.TeamProject)/$(Build.Repository.Name)/$(Build.SourceBranchName)/$(Build.BuildId)" /property:ProfilingInputsDrop="ProfilingInputs/$(System.TeamProject)/$(Build.Repository.Name)/$(Build.SourceBranchName)/$(Build.BuildId)" /binarylogger:$(Build.StagingDirectory)\\binlog\\18.GenerateRunSettings.binlog'
309+
msbuildArguments: '/restore:false /property:OutputPath="$(Build.Repository.LocalPath)\artifacts\RunSettings" /property:TestDrop="RunSettings/$(System.TeamProject)/$(Build.Repository.Name)/$(SourceBranch)/$(Build.BuildId)" /property:ProfilingInputsDrop="ProfilingInputs/$(System.TeamProject)/$(Build.Repository.Name)/$(SourceBranch)/$(Build.BuildId)" /binarylogger:$(Build.StagingDirectory)\\binlog\\18.GenerateRunSettings.binlog'
310310
condition: "and(succeeded(), eq(variables['BuildRTM'], 'false'))"
311311

312312
- task: PowerShell@1

eng/pipelines/templates/Initialize_Build.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,3 @@ steps:
3636
Write-Host "##vso[task.LogIssue type=error;]Unable to set build number"
3737
exit 1
3838
}
39-
40-
- task: PowerShell@1
41-
displayName: "Add Build Tags"
42-
inputs:
43-
scriptType: "inlineScript"
44-
inlineScript: |
45-
Write-Host "##vso[build.addbuildtag]${env:BUILD_SOURCEVERSIONAUTHOR}"
46-
Write-Host "##vso[build.addbuildtag]${env:BUILD_SOURCEBRANCHNAME}"

eng/pipelines/templates/pipeline.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ stages:
170170
displayName: "Publish the .runsettings files to artifact services"
171171
condition: "succeeded()"
172172
dropServiceURI: "https://devdiv.artifacts.visualstudio.com"
173-
buildNumber: "RunSettings/$(System.TeamProject)/$(Build.Repository.Name)/$(Build.SourceBranchName)/$(Build.BuildId)"
173+
buildNumber: "RunSettings/$(System.TeamProject)/$(Build.Repository.Name)/$(SourceBranch)/$(Build.BuildId)"
174174
sourcePath: 'artifacts\RunSettings'
175175
toLowerCase: false
176176
usePat: true
@@ -180,7 +180,7 @@ stages:
180180
displayName: "OptProfV2: publish profiling inputs to artifact services"
181181
condition: "and(succeeded(), eq(variables['IsOfficialBuild'], 'true'))"
182182
dropServiceURI: "https://devdiv.artifacts.visualstudio.com"
183-
buildNumber: "ProfilingInputs/$(System.TeamProject)/$(Build.Repository.Name)/$(Build.SourceBranchName)/$(Build.BuildId)"
183+
buildNumber: "ProfilingInputs/$(System.TeamProject)/$(Build.Repository.Name)/$(SourceBranch)/$(Build.BuildId)"
184184
sourcePath: '$(Build.ArtifactStagingDirectory)\OptProf\ProfilingInputs'
185185
toLowerCase: false
186186
usePat: true
@@ -210,7 +210,7 @@ stages:
210210
displayName: "Upload VSTS Drop"
211211
condition: "succeeded()"
212212
dropServiceURI: "https://devdiv.artifacts.visualstudio.com"
213-
buildNumber: "Products/$(System.TeamProject)/$(Build.Repository.Name)/$(Build.SourceBranchName)/$(Build.BuildNumber)"
213+
buildNumber: "Products/$(System.TeamProject)/$(Build.Repository.Name)/$(SourceBranch)/$(Build.BuildNumber)"
214214
sourcePath: "$(Build.Repository.LocalPath)\\artifacts\\VS15"
215215
toLowerCase: false
216216
usePat: true

0 commit comments

Comments
 (0)