Skip to content

Commit df6c51a

Browse files
zivkanzivkan
authored
Local tests don't run netfx signing tests needing admin access (#7303)
1 parent 01276fc commit df6c51a

25 files changed

Lines changed: 322 additions & 200 deletions

‎test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/AllowListVerificationProviderTests.cs‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public AllowListVerificationProviderTests(SigningTestFixture fixture)
3636
_trustedRepoTestCert = fixture.TrustedRepositoryCertificate;
3737
}
3838

39-
[Fact]
39+
[NetFxCIOnlyFact]
4040
public async Task GetTrustResultAsync_AuthorSignedPackage_WithCertificateInAllowList_SuccessAsync()
4141
{
4242
// Arrange
@@ -77,7 +77,7 @@ public async Task GetTrustResultAsync_AuthorSignedPackage_WithCertificateInAllow
7777
}
7878
}
7979

80-
[Theory]
80+
[NetFxCIOnlyTheory]
8181
[MemberData(nameof(EmptyNullAndRequiredListCombinations))]
8282
public async Task GetTrustResultAsync_AuthorSignedPackage_RequirementsAsync(
8383
SignedPackageVerifierSettings verifierSettings,
@@ -125,7 +125,7 @@ public async Task GetTrustResultAsync_AuthorSignedPackage_RequirementsAsync(
125125
}
126126
}
127127

128-
[Fact]
128+
[NetFxCIOnlyFact]
129129
public async Task GetTrustResultAsync_AuthorSignedPackage_VerifyWithoutCertificateInAllowList_AllowUntrusted_WarnAsync()
130130
{
131131
// Arrange
@@ -171,7 +171,7 @@ public async Task GetTrustResultAsync_AuthorSignedPackage_VerifyWithoutCertifica
171171
}
172172
}
173173

174-
[Fact]
174+
[NetFxCIOnlyFact]
175175
public async Task GetTrustResultAsync_AuthorSignedPackage_VerifyWithoutCertificateInAllowList_NotAllowUntrusted_ErrorAsync()
176176
{
177177
// Arrange
@@ -217,7 +217,7 @@ public async Task GetTrustResultAsync_AuthorSignedPackage_VerifyWithoutCertifica
217217
}
218218
}
219219

220-
[Fact]
220+
[NetFxCIOnlyFact]
221221
public async Task GetTrustResultAsync_RepositorySignedPackage_AllowListWithAuthorTarget_AndPrimaryPlacement_ErrorAsync()
222222
{
223223
// Arrange
@@ -265,7 +265,7 @@ public async Task GetTrustResultAsync_RepositorySignedPackage_AllowListWithAutho
265265
}
266266
}
267267

268-
[Fact]
268+
[NetFxCIOnlyFact]
269269
public async Task GetTrustResultAsync_RepositorySignedPackage_AllowListWithRepositoryTarget_AndCounterPlacementOnly_ErrorAsync()
270270
{
271271
// Arrange
@@ -313,7 +313,7 @@ public async Task GetTrustResultAsync_RepositorySignedPackage_AllowListWithRepos
313313
}
314314
}
315315

316-
[Fact]
316+
[NetFxCIOnlyFact]
317317
public async Task GetTrustResultAsync_RepositorySignedPackage_AllowListWithRepositoryTarget_AndPrimaryPlacement_SuccessAsync()
318318
{
319319
// Arrange
@@ -359,7 +359,7 @@ public async Task GetTrustResultAsync_RepositorySignedPackage_AllowListWithRepos
359359
}
360360
}
361361

362-
[Fact]
362+
[NetFxCIOnlyFact]
363363
public async Task GetTrustResultAsync_RepositoryCountersignedPackage_AllowListWithAuthorTarget_AndPrimaryPlacement_ErrorAsync()
364364
{
365365
// Arrange
@@ -409,7 +409,7 @@ public async Task GetTrustResultAsync_RepositoryCountersignedPackage_AllowListWi
409409
}
410410
}
411411

412-
[Fact]
412+
[NetFxCIOnlyFact]
413413
public async Task GetTrustResultAsync_RepositoryCountersignedPackage_AllowListWithRepositoryTarget_AndPrimaryPlacementOnly_ErrorAsync()
414414
{
415415
// Arrange
@@ -459,7 +459,7 @@ public async Task GetTrustResultAsync_RepositoryCountersignedPackage_AllowListWi
459459
}
460460
}
461461

462-
[Fact]
462+
[NetFxCIOnlyFact]
463463
public async Task GetTrustResultAsync_RepositoryCountersignedPackage_AllowListWithRepositoryTarget_AndCounterPlacement_SuccessAsync()
464464
{
465465
// Arrange
@@ -507,7 +507,7 @@ public async Task GetTrustResultAsync_RepositoryCountersignedPackage_AllowListWi
507507
}
508508
}
509509

510-
[Fact]
510+
[NetFxCIOnlyFact]
511511
public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSignedWithCertFromAllowList_RequireMode_SuccessAsync()
512512
{
513513
var nupkg = new SimpleTestPackageContext();
@@ -551,7 +551,7 @@ public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSign
551551
}
552552
}
553553

554-
[Fact]
554+
[NetFxCIOnlyFact]
555555
public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSignedWithCertNotFromAllowList_RequireMode_ErrorAsync()
556556
{
557557
var nupkg = new SimpleTestPackageContext();
@@ -602,7 +602,7 @@ public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSign
602602
}
603603
}
604604

605-
[Fact]
605+
[NetFxCIOnlyFact]
606606
public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSignedWithCertFromAllowList_WithOwnerInOwnersList_RequireMode_SuccessAsync()
607607
{
608608
var nupkg = new SimpleTestPackageContext();
@@ -652,7 +652,7 @@ public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSign
652652
}
653653
}
654654

655-
[Fact]
655+
[NetFxCIOnlyFact]
656656
public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSignedWithCertFromAllowList_WithOwnerNotInOwnersList_RequireMode_ErrorAsync()
657657
{
658658
var nupkg = new SimpleTestPackageContext();
@@ -703,7 +703,7 @@ public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSign
703703
}
704704
}
705705

706-
[Fact]
706+
[NetFxCIOnlyFact]
707707
public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSignedWithCertFromAllowList_WithNoOwnersInPackage_RequireMode_ErrorAsync()
708708
{
709709
var nupkg = new SimpleTestPackageContext();
@@ -752,7 +752,7 @@ public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSign
752752
}
753753
}
754754

755-
[Fact]
755+
[NetFxCIOnlyFact]
756756
public async Task GetTrustResultAsync_RepositoryCountersignedPackage_PackageSignedWithCertFromAllowList_WithOwnerInOwnersList_RequireMode_SuccessAsync()
757757
{
758758
var nupkg = new SimpleTestPackageContext();
@@ -804,7 +804,7 @@ public async Task GetTrustResultAsync_RepositoryCountersignedPackage_PackageSign
804804
}
805805
}
806806

807-
[Fact]
807+
[NetFxCIOnlyFact]
808808
public async Task GetTrustResultAsync_RepositoryCountersignedPackage_PackageSignedWithCertFromAllowList_WithOwnerNotInOwnersList_RequireMode_ErrorAsync()
809809
{
810810
var nupkg = new SimpleTestPackageContext();
@@ -857,7 +857,7 @@ public async Task GetTrustResultAsync_RepositoryCountersignedPackage_PackageSign
857857
}
858858
}
859859

860-
[Fact]
860+
[NetFxCIOnlyFact]
861861
public async Task GetTrustResultAsync_RepositoryCountersignedPackage_PackageSignedWithCertFromAllowList_WithOwnerNotInOwnersList_AuthorInList_RequireMode_SuccessAsync()
862862
{
863863
var nupkg = new SimpleTestPackageContext();
@@ -911,7 +911,7 @@ public async Task GetTrustResultAsync_RepositoryCountersignedPackage_PackageSign
911911
}
912912
}
913913

914-
[Fact]
914+
[NetFxCIOnlyFact]
915915
public async Task GetTrustResultAsync_RepositoryCountersignedPackage_PackageSignedWithCertFromAllowList_WithNoOwnersInPackage_RequireMode_ErrorAsync()
916916
{
917917
var nupkg = new SimpleTestPackageContext();
@@ -963,7 +963,7 @@ public async Task GetTrustResultAsync_RepositoryCountersignedPackage_PackageSign
963963
}
964964

965965

966-
[Fact]
966+
[NetFxCIOnlyFact]
967967
public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSignedWithCertFromAllowList_WithEmptyOwnersList_RequireMode_SuccessAsync()
968968
{
969969
var nupkg = new SimpleTestPackageContext();
@@ -1013,7 +1013,7 @@ public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSign
10131013
}
10141014
}
10151015

1016-
[Fact]
1016+
[NetFxCIOnlyFact]
10171017
public async Task GetTrustResultAsync_RepositoryPrimarySignedPackage_PackageSignedWithCertFromAllowList__WithNullOwnersList_RequireMode_SuccessAsync()
10181018
{
10191019
var nupkg = new SimpleTestPackageContext();

‎test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/ClientPolicyTests.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public void Dispose()
3636
_trustedRepoTestCert.Dispose();
3737
}
3838

39-
[Theory]
39+
[NetFxCIOnlyTheory]
4040
[InlineData(SigningTestType.Author, "accept", true, 0)]
4141
[InlineData(SigningTestType.Author, "require", false, 1)]
4242
[InlineData(SigningTestType.RepositoryPrimary, "accept", true, 0)]
@@ -91,7 +91,7 @@ public async Task ClientPolicies_WithNoTrustedSignersListAsync(SigningTestType s
9191
}
9292
}
9393

94-
[Theory]
94+
[NetFxCIOnlyTheory]
9595
[InlineData(SigningTestType.Author, "accept", true, 0, 1)]
9696
[InlineData(SigningTestType.Author, "require", false, 1, 0)]
9797
[InlineData(SigningTestType.RepositoryPrimary, "accept", true, 0, 1)]
@@ -152,7 +152,7 @@ public async Task ClientPolicies_WithSignerNotInTrustedSignersListAsync(SigningT
152152
}
153153
}
154154

155-
[Theory]
155+
[NetFxCIOnlyTheory]
156156
[InlineData(SigningTestType.Author, SignaturePlacement.PrimarySignature, "accept")]
157157
[InlineData(SigningTestType.Author, SignaturePlacement.PrimarySignature, "require")]
158158
[InlineData(SigningTestType.RepositoryPrimary, SignaturePlacement.PrimarySignature, "accept")]
@@ -223,7 +223,7 @@ public async Task ClientPolicies_WithSignerInTrustedSignersListAsync(SigningTest
223223
}
224224
}
225225

226-
[Theory]
226+
[NetFxCIOnlyTheory]
227227
[InlineData(SigningTestType.RepositoryPrimary, "accept")]
228228
[InlineData(SigningTestType.RepositoryPrimary, "require")]
229229
[InlineData(SigningTestType.RepositoryCountersigned, "accept")]
@@ -283,7 +283,7 @@ public async Task ClientPolicies_WithSignerInTrustedSignersList_WithMatchingOwne
283283
}
284284
}
285285

286-
[Theory]
286+
[NetFxCIOnlyTheory]
287287
[InlineData(SigningTestType.RepositoryPrimary, "accept", true, 0, 1)]
288288
[InlineData(SigningTestType.RepositoryPrimary, "require", false, 1, 0)]
289289
[InlineData(SigningTestType.RepositoryCountersigned, "accept", true, 0, 1)]
@@ -343,7 +343,7 @@ public async Task ClientPolicies_WithSignerInTrustedSignersList_WithoutMatchingO
343343
}
344344
}
345345

346-
[Theory]
346+
[NetFxCIOnlyTheory]
347347
[InlineData(SigningTestType.RepositoryPrimary, "accept", true, 0, 1)]
348348
[InlineData(SigningTestType.RepositoryPrimary, "require", false, 1, 0)]
349349
[InlineData(SigningTestType.RepositoryCountersigned, "accept", true, 0, 1)]

‎test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/IntegrityVerificationProviderTests.cs‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ private static SignedPackageVerifierSettings GetSettingsPolicy(string policyStri
6161
return SignedPackageVerifierSettings.GetDefault(TestEnvironmentVariableReader.EmptyInstance);
6262
}
6363

64-
[Theory]
64+
[NetFxCIOnlyTheory]
6565
[InlineData("command")]
6666
[InlineData("vs")]
6767
public async Task Signer_VerifyOnSignedPackageAsync(string policyString)
@@ -87,7 +87,7 @@ public async Task Signer_VerifyOnSignedPackageAsync(string policyString)
8787
}
8888
}
8989

90-
[Theory]
90+
[NetFxCIOnlyTheory]
9191
[InlineData("command")]
9292
[InlineData("vs")]
9393
public async Task Signer_VerifyOnTamperedPackage_FileDeletedAsync(string policyString)
@@ -121,7 +121,7 @@ public async Task Signer_VerifyOnTamperedPackage_FileDeletedAsync(string policyS
121121
}
122122
}
123123

124-
[Theory]
124+
[NetFxCIOnlyTheory]
125125
[InlineData("command")]
126126
[InlineData("vs")]
127127
public async Task Signer_VerifyOnTamperedPackage_FileAddedAsync(string policyString)
@@ -166,7 +166,7 @@ public async Task Signer_VerifyOnTamperedPackage_FileAddedAsync(string policyStr
166166
}
167167
}
168168

169-
[Theory]
169+
[NetFxCIOnlyTheory]
170170
[InlineData("command")]
171171
[InlineData("vs")]
172172
public async Task Signer_VerifyOnTamperedPackage_FileAppendedAsync(string policyString)
@@ -210,7 +210,7 @@ public async Task Signer_VerifyOnTamperedPackage_FileAppendedAsync(string policy
210210
}
211211
}
212212

213-
[Theory]
213+
[NetFxCIOnlyTheory]
214214
[InlineData("command")]
215215
[InlineData("vs")]
216216
public async Task Signer_VerifyOnTamperedPackage_FileTruncatedAsync(string policyString)
@@ -251,7 +251,7 @@ public async Task Signer_VerifyOnTamperedPackage_FileTruncatedAsync(string polic
251251
}
252252
}
253253

254-
[Theory]
254+
[NetFxCIOnlyTheory]
255255
[InlineData("command")]
256256
[InlineData("vs")]
257257
public async Task Signer_VerifyOnTamperedPackage_FileMetadataModifiedAsync(string policyString)
@@ -295,7 +295,7 @@ public async Task Signer_VerifyOnTamperedPackage_FileMetadataModifiedAsync(strin
295295
}
296296
}
297297

298-
[Theory]
298+
[NetFxCIOnlyTheory]
299299
[InlineData("command", false)]
300300
[InlineData("vs", true)]
301301
public async Task Signer_VerifyOnTamperedPackage_SignatureRemovedAsync(string policyString, bool expectedValidity)
@@ -339,7 +339,7 @@ public async Task Signer_VerifyOnTamperedPackage_SignatureRemovedAsync(string po
339339
}
340340
}
341341

342-
[Theory]
342+
[NetFxCIOnlyTheory]
343343
[InlineData("command", false)]
344344
[InlineData("vs", true)]
345345
public async Task Signer_VerifyOnTamperedPackage_SignatureTamperedAsync(string policyString, bool expectedValidity)

0 commit comments

Comments
 (0)