Reduce allocation in GetContentFileGroup by providing accurate capacity for List (#7037)

nareshjo · web-flow · commit d8e33ddc9f5a · 2026-01-14T09:16:30.000+10:30
diff --git a/src/NuGet.Core/NuGet.Commands/RestoreCommand/ContentFiles/ContentFileUtils.cs b/src/NuGet.Core/NuGet.Commands/RestoreCommand/ContentFiles/ContentFileUtils.cs
@@ -75,7 +75,6 @@ internal static List<LockFileContentFile> GetContentFileGroup(
             NuspecReader nuspec,
             List<ContentItemGroup> contentFileGroups)
         {
-            var results = new List<LockFileContentFile>(contentFileGroups.Count);
             var rootFolderPathLength = ContentFilesFolderName.Length;
 
             // Read the contentFiles section of the nuspec
@@ -148,6 +147,8 @@ internal static List<LockFileContentFile> GetContentFileGroup(
                 }
             }
 
+            var results = new List<LockFileContentFile>(entryMappings.Count);
+
             // Create lock file entries for each item in the contentFiles folder
             foreach ((var file, var entries) in entryMappings)
             {

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,6 @@ internal static List<LockFileContentFile> GetContentFileGroup(`
`75`	`75`	`NuspecReader nuspec,`
`76`	`76`	`List<ContentItemGroup> contentFileGroups)`
`77`	`77`	`{`
`78`		`- var results = new List<LockFileContentFile>(contentFileGroups.Count);`
`79`	`78`	`var rootFolderPathLength = ContentFilesFolderName.Length;`
`80`	`79`
`81`	`80`	`// Read the contentFiles section of the nuspec`
`@@ -148,6 +147,8 @@ internal static List<LockFileContentFile> GetContentFileGroup(`
`148`	`147`	`}`
`149`	`148`	`}`
`150`	`149`
	`150`	`+ var results = new List<LockFileContentFile>(entryMappings.Count);`
	`151`	`+`
`151`	`152`	`// Create lock file entries for each item in the contentFiles folder`
`152`	`153`	`foreach ((var file, var entries) in entryMappings)`
`153`	`154`	`{`