more annotations

Author: nkolev92

src/NuGet.Core/NuGet.Packaging/Core/PackageIdentity.cs

@@ -40,7 +40,7 @@ public PackageIdentity(string id, NuGetVersion? version)
         /// Package Version
         /// </summary>
         /// <remarks>can be null</remarks>
-        /// <remarks>This property is annotated as not nullable intentionally.
+        /// <remarks>NU_NULL_INC: This property is annotated as not nullable intentionally.
         /// The null is used in very few scenarios and practically illegal in cases dealing with an actual package identity. </remarks>
         public NuGetVersion Version
         {

src/NuGet.Core/NuGet.Packaging/NupkgMetadata/NupkgMetadataFile.cs

@@ -10,7 +10,7 @@ public class NupkgMetadataFile : IEquatable<NupkgMetadataFile>
     {
         public int Version { get; set; } = NupkgMetadataFileFormat.Version;
 
-        public string? ContentHash { get; set; }
+        public required string? ContentHash { get; set; }
 
         public string? Source { get; set; }
 

src/NuGet.Core/NuGet.Packaging/NuspecReader.cs

@@ -642,11 +642,8 @@ private static List<string> GetFlags(string? flags)
             // PERF: Avoid Linq on hot paths
             var splitFlags = flags!.Split(CommaArray, StringSplitOptions.RemoveEmptyEntries);
 
-#if NETSTANDARD2_0
-            var set = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
-#elif NET472_OR_GREATER || NET5_0_OR_GREATER
             var set = new HashSet<string>(splitFlags.Length, StringComparer.OrdinalIgnoreCase);
-#endif
+
             foreach (string flag in splitFlags)
             {
                 set.Add(flag.Trim());

src/NuGet.Core/NuGet.Packaging/PackageExtractor.cs

@@ -1144,7 +1144,7 @@ await logger.LogAsync(
 
             if (!string.IsNullOrEmpty(source))
             {
-                RepositorySignatureInfoProvider.Instance.TryGetRepositorySignatureInfo(source, out repositorySignatureInfo);
+                RepositorySignatureInfoProvider.Instance.TryGetRepositorySignatureInfo(source!, out repositorySignatureInfo);
             }
 
             return repositorySignatureInfo;

src/NuGet.Core/NuGet.Packaging/PublicAPI/net472/PublicAPI.Shipped.txt

@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 namespace NuGet.Packaging.Signing
 {
     public static class Oids

src/NuGet.Core/NuGet.Packaging/PublicAPI/net8.0/PublicAPI.Shipped.txt

@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System.Collections.Generic;
 using NuGet.Packaging.Core;
 

src/NuGet.Core/NuGet.Packaging/Signing/Oids.cs

@@ -1,10 +1,9 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using System.Collections.Concurrent;
+using System.Diagnostics.CodeAnalysis;
 
 namespace NuGet.Packaging
 {
@@ -23,7 +22,7 @@ public class RepositorySignatureInfoProvider
         /// <param name="source">Package source URL.</param>
         /// <param name="repositorySignatureInfo">Contains the RepositorySignatureInfo when the method returns. It is null if repository signature information is unavailable.</param>
         /// <returns>True if the repository signature information was found. Otherwise, False.</returns>
-        public bool TryGetRepositorySignatureInfo(string source, out RepositorySignatureInfo repositorySignatureInfo)
+        public bool TryGetRepositorySignatureInfo(string source, [NotNullWhen(returnValue: true)] out RepositorySignatureInfo? repositorySignatureInfo)
         {
             repositorySignatureInfo = null;
 

src/NuGet.Core/NuGet.Packaging/Signing/RepositorySignatureInfo.cs

@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using NuGet.Common;
@@ -15,9 +13,9 @@ public class SignatureException : PackagingException
         /// <summary>
         /// Individual trust results.
         /// </summary>
-        public IReadOnlyList<PackageVerificationResult> Results { get; }
+        public IReadOnlyList<PackageVerificationResult>? Results { get; }
 
-        public PackageIdentity PackageIdentity { get; }
+        public PackageIdentity? PackageIdentity { get; }
 
         public TimeSpan VerifyDuration { get; set; }