Fix false error for transitively pinned dependency with no version (#7004)

Author: jeffkl

src/NuGet.Core/NuGet.Commands/RestoreCommand/DependencyGraphResolver.cs

@@ -557,7 +557,12 @@ public async Task<ValueTuple<bool, List<RestoreTargetGraph>, RuntimeGraph>> Reso
                         currentGraphNode.InnerNodes.Add(newGraphNode);
                     }
 
-                    if (!childResolvedDependencyGraphItem.IsRootPackageReference && isCentralPackageTransitivePinningEnabled && childLibraryDependency.SuppressParent != LibraryIncludeFlags.All && !downgrades.ContainsKey(childResolvedLibraryRangeIndex) && !RemoteDependencyWalker.IsGreaterThanOrEqualTo(childResolvedDependencyGraphItem.LibraryDependency.LibraryRange.VersionRange, childLibraryDependency.LibraryRange.VersionRange))
+                    if (!childResolvedDependencyGraphItem.IsRootPackageReference
+                        && isCentralPackageTransitivePinningEnabled
+                        && childLibraryDependency.SuppressParent != LibraryIncludeFlags.All
+                        && !downgrades.ContainsKey(childResolvedLibraryRangeIndex)
+                        && childLibraryDependency.LibraryRange.VersionRange != VersionRange.All
+                        && !RemoteDependencyWalker.IsGreaterThanOrEqualTo(childResolvedDependencyGraphItem.LibraryDependency.LibraryRange.VersionRange, childLibraryDependency.LibraryRange.VersionRange))
                     {
                         // This is a downgrade if:
                         // 1. This is not a direct dependency
@@ -905,8 +910,7 @@ private async Task<Dictionary<LibraryDependencyIndex, ResolvedDependencyGraphIte
             FrameworkRuntimeDefinition pair,
             TargetFrameworkInformation projectTargetFramework,
             RuntimeGraph? runtimeGraph,
-            Dictionary<LibraryDependencyIndex,
-            VersionRange>? pinnedPackageVersions,
+            Dictionary<LibraryDependencyIndex, VersionRange>? pinnedPackageVersions,
             DependencyGraphItem rootProjectDependencyGraphItem,
             RemoteWalkContext context,
             CancellationToken token)

test/NuGet.Core.FuncTests/NuGet.Commands.FuncTest/RestoreCommand_AlgorithmEquivalencyTests.cs

@@ -2745,6 +2745,54 @@ await SimpleTestPackageUtility.CreateFolderFeedV3Async(
             result2.LockFile.Targets[0].Libraries[1].Version.Should().Be(new NuGetVersion("1.0.0"));
         }
 
+        // P -> A 1.0.0
+        //      -> B (no version)
+        // B is pinned to 1.0.0
+        [Fact]
+        public async Task RestoreCommand_WithTransitiveReferenceMissingVersion_VerifiesEquivalency()
+        {
+            // Arrange
+            using var pathContext = new SimpleTestPathContext();
+
+            var P = ProjectTestHelpers.GetPackageSpecWithProjectNameAndSpec(
+                "P",
+                pathContext.SolutionRoot,
+                @"
+{
+  ""restore"": {
+    ""centralPackageVersionsManagementEnabled"": true,
+    ""CentralPackageTransitivePinningEnabled"": true,
+  },
+  ""frameworks"": {
+    ""net472"": {
+      ""centralPackageVersions"": {
+            ""B"": ""[1.0.0,)"",
+      }
+    }
+  }
+}")
+                .WithDependency(new LibraryDependency()
+                {
+                    LibraryRange = new LibraryRange("A", VersionRange.Parse("1.0.0"), LibraryDependencyTarget.Package),
+                    VersionCentrallyManaged = true,
+                });
+
+            await SimpleTestPackageUtility.CreateFolderFeedV3Async(
+                pathContext.PackageSource,
+                new SimpleTestPackageContext("A", "1.0.0")
+                {
+                    Dependencies =
+                    [
+                        new SimpleTestPackageContext("B", "0.0.0"),
+                    ]
+                },
+                new SimpleTestPackageContext("B", "1.0.0"));
+
+            (var result, _) = await ValidateRestoreAlgorithmEquivalency(pathContext, P);
+            result.LockFile.Targets.Should().HaveCount(1);
+            result.LockFile.Targets[0].Libraries.Should().HaveCount(2);
+        }
+
         // Here's why package driven dependencies should flow.
         // Say we have P1 -> P2 -> P3 -> A 1.0.0 -> B 2.0.0
         //                            -> B 1.5.0

test/TestUtilities/Test.Utility/SimpleTestSetup/SimpleTestPackageUtility.cs

@@ -29,6 +29,8 @@ namespace NuGet.Test.Utility
 
     public static class SimpleTestPackageUtility
     {
+        private static NuGetVersion EmptyNuGetVersion = new NuGetVersion(0, 0, 0);
+
         public static async Task CreateFullPackagesAsync(string repositoryDir, IDictionary<string, IEnumerable<string>> packages)
         {
             if (packages == null)
@@ -222,7 +224,10 @@ public static async Task CreatePackageAsync(Stream stream, SimpleTestPackageCont
                             var node = new XElement(XName.Get("dependency"));
                             groupNode.Add(node);
                             node.Add(new XAttribute(XName.Get("id"), dependency.Id));
-                            node.Add(new XAttribute(XName.Get("version"), dependency.VersionRange.ToNormalizedString()));
+                            if (dependency.VersionRange.MinVersion != EmptyNuGetVersion)
+                            {
+                                node.Add(new XAttribute(XName.Get("version"), dependency.VersionRange.ToNormalizedString()));
+                            }
 
                             if (dependency.Include.Count > 0)
                             {