Change GetPackageMetadataAsync to internal and remove reflection from test

Co-authored-by: nkolev92 <[email protected]>

Author: Copilot

src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs

@@ -406,7 +406,7 @@ private static IEnumerable<InstalledPackageReference> GetInstalledPackageReferen
         /// <param name="targetFrameworks">A <see cref="FrameworkPackages"/> per project target framework</param>
         /// <param name="listPackageArgs">List command args</param>
         /// <returns>A dictionary where the key is the package id, and the value is a list of <see cref="IPackageSearchMetadata"/>.</returns>
-        private async Task<Dictionary<string, List<IPackageSearchMetadata>>> GetPackageMetadataAsync(
+        internal async Task<Dictionary<string, List<IPackageSearchMetadata>>> GetPackageMetadataAsync(
             List<FrameworkPackages> targetFrameworks,
             ListPackageArgs listPackageArgs)
         {

test/NuGet.Core.Tests/NuGet.CommandLine.Xplat.Tests/ListPackageCommandRunnerTests.cs

@@ -5,7 +5,6 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
-using System.Reflection;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
@@ -403,18 +402,10 @@ public async Task GetPackageMetadataAsync_WithEmptyPackageSources_DoesNotThrowDi
 
             var listPackageRunner = new ListPackageCommandRunner();
 
-            // Act & Assert - Test the private method using reflection
-            var getPackageMetadataAsyncMethod = typeof(ListPackageCommandRunner)
-                .GetMethod("GetPackageMetadataAsync", BindingFlags.NonPublic | BindingFlags.Instance);
-
-            Assert.NotNull(getPackageMetadataAsyncMethod);
-
-            // This should not throw DivideByZeroException
+            // Act & Assert - Call the method directly since it's now internal
             Exception exception = await Record.ExceptionAsync(async () =>
             {
-                var task = (Task<Dictionary<string, List<IPackageSearchMetadata>>>)getPackageMetadataAsyncMethod.Invoke(
-                    listPackageRunner, new object[] { allPackages, listPackageArgs });
-                await task;
+                await listPackageRunner.GetPackageMetadataAsync(allPackages, listPackageArgs);
             });
 
             Assert.Null(exception);