Skip to content

Commit a63ce8f

Browse files
authored
dotnet list package --format=json - remove redundant auto-referenced packages warning (#6997)
1 parent aea7daa commit a63ce8f

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/NuGet.Core/NuGet.CommandLine.XPlat/ListPackage/ListPackageJsonRenderer.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,6 @@ private void WriteJson(JsonWriter writer, ListPackageReportModel listPackageRepo
102102
writer.WritePropertyName(ParametersProperty);
103103
writer.WriteValue(PathUtility.GetPathWithForwardSlashes(listPackageArgs.ArgumentText));
104104

105-
if (listPackageReportModel.Projects.Any(p => p.AutoReferenceFound))
106-
{
107-
_problems.Add(new ReportProblem(ProblemType.Warning, string.Empty, Strings.ListPkg_AutoReferenceDescription));
108-
}
109-
110105
if (_problems?.Count > 0)
111106
{
112107
WriteProblems(writer, _problems);

test/NuGet.Core.FuncTests/NuGet.XPlat.FuncTest/XplatListPackageJsonRendererTests.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1403,6 +1403,11 @@ internal ListPackageReportModel CreateListReportModel(ListPackageArgs packageRef
14031403
{
14041404
var projectModel = new ListPackageProjectModel(project.projectPath);
14051405
projectModel.TargetFrameworkPackages = project.listPackageReportFrameworks;
1406+
var hasAutoReferencedTopLevelPackage = project.listPackageReportFrameworks?.Any(packageReportFramework =>
1407+
packageReportFramework.TopLevelPackages?.Any(topLevelPackage => topLevelPackage.AutoReference) ?? false) ??
1408+
false;
1409+
1410+
projectModel.AutoReferenceFound = hasAutoReferencedTopLevelPackage;
14061411

14071412
if (project.projectProblems != null)
14081413
{

0 commit comments

Comments
 (0)