Skip to content

Commit 870cea9

Browse files
Copilotjeffkl
andcommitted
Fix nullability annotations and localize strings
Co-authored-by: jeffkl <[email protected]>
1 parent 83d4a5f commit 870cea9

4 files changed

Lines changed: 29 additions & 2 deletions

File tree

src/NuGet.Core/NuGet.Protocol/Exceptions/QuotaExceededException.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
// Copyright (c) .NET Foundation. All rights reserved.
22
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
33

4+
#nullable enable
5+
46
using System;
57
using System.Runtime.Serialization;
68

src/NuGet.Core/NuGet.Protocol/Resources/PackageUpdateResource.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -546,8 +546,8 @@ await _httpSource.ProcessResponseAsync(
546546
{
547547
TimeSpan? retryAfter = GetRetryAfter(response.Headers.RetryAfter);
548548
string message = retryAfter.HasValue
549-
? string.Format(CultureInfo.CurrentCulture, "Quota exceeded. Retry after {0} seconds.", retryAfter.Value.TotalSeconds)
550-
: "Quota exceeded. Retry after the time specified in the Retry-After header.";
549+
? string.Format(CultureInfo.CurrentCulture, Strings.QuotaExceeded_RetryAfterSeconds, retryAfter.Value.TotalSeconds)
550+
: Strings.QuotaExceeded_RetryAfterHeader;
551551
throw new QuotaExceededException(message, retryAfter);
552552
}
553553

src/NuGet.Core/NuGet.Protocol/Strings.Designer.cs

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/NuGet.Core/NuGet.Protocol/Strings.resx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -539,4 +539,11 @@ The "s" should be localized to the abbreviation for seconds.</comment>
539539
<value>Invalid package id : `{0}`.</value>
540540
<comment>0 - package id.</comment>
541541
</data>
542+
<data name="QuotaExceeded_RetryAfterSeconds" xml:space="preserve">
543+
<value>Quota exceeded. Retry after {0} seconds.</value>
544+
<comment>{0} - number of seconds to wait before retrying.</comment>
545+
</data>
546+
<data name="QuotaExceeded_RetryAfterHeader" xml:space="preserve">
547+
<value>Quota exceeded. Retry after the time specified in the Retry-After header.</value>
548+
</data>
542549
</root>

0 commit comments

Comments
 (0)