Deprecate http usage: nuget list promote warning to error for http sources (#5694)

Author: Nigusu-Allehu

src/NuGet.Core/NuGet.Commands/ListCommand/ListCommandRunner.cs

@@ -49,7 +49,7 @@ public async Task ExecuteCommand(ListArgs listArgs)
                 }
             }
 
-            WarnForHTTPSources(listArgs);
+            AvoidHttpSources(listArgs);
 
             var allPackages = new List<IEnumerableAsync<IPackageSearchMetadata>>();
             var log = listArgs.IsDetailed ? listArgs.Logger : NullLogger.Instance;
@@ -64,7 +64,7 @@ await feed.ListAsync(listArgs.Arguments.FirstOrDefault(), listArgs.Prerelease, l
             await PrintPackages(listArgs, new AggregateEnumerableAsync<IPackageSearchMetadata>(allPackages, comparer, comparer).GetEnumeratorAsync());
         }
 
-        private static void WarnForHTTPSources(ListArgs listArgs)
+        private static void AvoidHttpSources(ListArgs listArgs)
         {
             List<PackageSource> httpPackageSources = null;
             foreach (PackageSource packageSource in listArgs.ListEndpoints)
@@ -83,17 +83,17 @@ private static void WarnForHTTPSources(ListArgs listArgs)
             {
                 if (httpPackageSources.Count == 1)
                 {
-                    listArgs.Logger.LogWarning(
+                    throw new ArgumentException(
                         string.Format(CultureInfo.CurrentCulture,
-                        Strings.Warning_HttpServerUsage,
+                        Strings.Error_HttpSource_Single,
                         "list",
                         httpPackageSources[0]));
                 }
                 else
                 {
-                    listArgs.Logger.LogWarning(
+                    throw new ArgumentException(
                         string.Format(CultureInfo.CurrentCulture,
-                        Strings.Warning_HttpServerUsage_MultipleSources,
+                        Strings.Error_HttpSources_Multiple,
                         "list",
                         Environment.NewLine + string.Join(Environment.NewLine, httpPackageSources.Select(e => e.Name))));
                 }

src/NuGet.Core/NuGet.Commands/Strings.Designer.cs

@@ -1099,4 +1099,12 @@ Non-HTTPS access will be removed in a future version. Consider migrating to 'HTT
   <data name="SourcesCommandValidProtocolVersion" xml:space="preserve">
     <value>The protocol version specified is invalid. Valid protocol versions are from {0} to {1}.</value>
   </data>
+  <data name="Error_HttpSources_Multiple" xml:space="preserve">
+    <value>You are running the '{0}' operation with 'HTTP' sources: {1}. NuGet requires HTTPS sources. To use HTTP sources, you must explicitly set 'allowInsecureConnections' to true in your NuGet.Config file. Please refer to https://aka.ms/nuget-https-everywhere.</value>
+    <comment>0 - The command name. Ex. Push/Delete. 1 - list of server URIs</comment>
+  </data>
+  <data name="Error_HttpSource_Single" xml:space="preserve">
+    <value>You are running the '{0}' operation with an 'HTTP' source: {1}. NuGet requires HTTPS sources. To use an HTTP source, you must explicitly set 'allowInsecureConnections' to true in your NuGet.Config file. Please refer to https://aka.ms/nuget-https-everywhere.</value>
+    <comment>0 - The command name. Ex. Push/Delete. 1 - server URI.</comment>
+  </data>
 </root>