start

Author: nkolev92

.github/copilot-instructions.md

@@ -1,9 +1,15 @@
 # Instructions
 
-When creating pull requests, always follow the [PR template](PULL_REQUEST_TEMPLATE.md).
+## General Guidelines
 
-Use the following coding guidelines: https://github.com/NuGet/NuGet.Client/blob/dev/docs/coding-guidelines.md
+- When creating pull requests, always follow the [PR template](PULL_REQUEST_TEMPLATE.md).
+- Always format before submitting a pull request.
 
-Always format before submitting a pull request.
+## Coding Standards
 
-Never use reflection.
+- Use the following coding guidelines: https://github.com/NuGet/NuGet.Client/blob/dev/docs/coding-guidelines.md
+- Never use reflection.
+
+## Project-Specific Rules
+
+- All files in the repository are nullable by default (project-level nullable enable). No need to add `#nullable enable` directives to individual files.

src/NuGet.Core/NuGet.ProjectModel/CircularMemoryStream.cs

@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using System.IO;
 
@@ -15,7 +13,7 @@ internal sealed class CircularMemoryStream : MemoryStream
     {
         private readonly byte[] _buffer;
 
-        internal event EventHandler<ArraySegment<byte>> OnFlush;
+        internal event EventHandler<ArraySegment<byte>>? OnFlush;
 
         internal CircularMemoryStream(byte[] buffer) : base(buffer)
         {

src/NuGet.Core/NuGet.ProjectModel/HashObjectWriter.cs

@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.IO;
@@ -134,7 +132,7 @@ public void WriteNameValue(string name, bool value)
             _writer.WriteValue(value);
         }
 
-        public void WriteNameValue(string name, string value)
+        public void WriteNameValue(string name, string? value)
         {
             if (name == null)
             {
@@ -260,11 +258,11 @@ public void WriteArrayEnd()
             --_nestLevel;
         }
 
-        private void OnFlush(object sender, ArraySegment<byte> bytes)
+        private void OnFlush(object? sender, ArraySegment<byte> bytes)
         {
             if (bytes.Count > 0)
             {
-                _hashFunc.Update(bytes.Array, bytes.Offset, bytes.Count);
+                _hashFunc.Update(bytes.Array!, bytes.Offset, bytes.Count);
             }
         }
 

src/NuGet.Core/NuGet.ProjectModel/PublicAPI.Shipped.txt

@@ -89,18 +89,18 @@ NuGet.ProjectModel.FileFormatException.Line.get -> int
 ~NuGet.ProjectModel.FileFormatException.Path.get -> string
 NuGet.ProjectModel.HashObjectWriter
 NuGet.ProjectModel.HashObjectWriter.Dispose() -> void
-~NuGet.ProjectModel.HashObjectWriter.GetHash() -> string
-~NuGet.ProjectModel.HashObjectWriter.HashObjectWriter(NuGet.Packaging.IHashFunction hashFunc) -> void
+NuGet.ProjectModel.HashObjectWriter.GetHash() -> string!
+NuGet.ProjectModel.HashObjectWriter.HashObjectWriter(NuGet.Packaging.IHashFunction! hashFunc) -> void
 NuGet.ProjectModel.HashObjectWriter.WriteArrayEnd() -> void
-~NuGet.ProjectModel.HashObjectWriter.WriteArrayStart(string name) -> void
-~NuGet.ProjectModel.HashObjectWriter.WriteNameArray(string name, System.Collections.Generic.IEnumerable<string> values) -> void
-~NuGet.ProjectModel.HashObjectWriter.WriteNameValue(string name, bool value) -> void
-~NuGet.ProjectModel.HashObjectWriter.WriteNameValue(string name, int value) -> void
-~NuGet.ProjectModel.HashObjectWriter.WriteNameValue(string name, string value) -> void
-~NuGet.ProjectModel.HashObjectWriter.WriteNonEmptyNameArray(string name, System.Collections.Generic.IEnumerable<string> values) -> void
+NuGet.ProjectModel.HashObjectWriter.WriteArrayStart(string! name) -> void
+NuGet.ProjectModel.HashObjectWriter.WriteNameArray(string! name, System.Collections.Generic.IEnumerable<string!>! values) -> void
+NuGet.ProjectModel.HashObjectWriter.WriteNameValue(string! name, bool value) -> void
+NuGet.ProjectModel.HashObjectWriter.WriteNameValue(string! name, int value) -> void
+NuGet.ProjectModel.HashObjectWriter.WriteNameValue(string! name, string? value) -> void
+NuGet.ProjectModel.HashObjectWriter.WriteNonEmptyNameArray(string! name, System.Collections.Generic.IEnumerable<string!>! values) -> void
 NuGet.ProjectModel.HashObjectWriter.WriteObjectEnd() -> void
 NuGet.ProjectModel.HashObjectWriter.WriteObjectStart() -> void
-~NuGet.ProjectModel.HashObjectWriter.WriteObjectStart(string name) -> void
+NuGet.ProjectModel.HashObjectWriter.WriteObjectStart(string! name) -> void
 NuGet.ProjectModel.IAssetsLogMessage
 NuGet.ProjectModel.IAssetsLogMessage.Code.get -> NuGet.Common.NuGetLogCode
 NuGet.ProjectModel.IAssetsLogMessage.EndColumnNumber.get -> int