feedback

Author: nkolev92

src/NuGet.Core/NuGet.Commands/RestoreCommand/Logging/TransitiveNoWarnUtils.cs

@@ -112,7 +112,8 @@ private static PackageSpecificWarningProperties ExtractTransitiveNoWarnPropertie
                 {
                     var localMatch = (LocalMatch)dependencyGraphItem.Data.Match;
                     var nodeProjectSpec = GetNodePackageSpec(localMatch);
-                    var nearestFramework = nodeProjectSpec.GetTargetFramework(parentTargetFramework).TargetAlias;
+                    TargetFrameworkInformation targetFrameworkInformation = nodeProjectSpec.GetTargetFramework(parentTargetFramework);
+                    string nearestFramework = targetFrameworkInformation.FrameworkName != null ? targetFrameworkInformation.TargetAlias : null;
 
                     if (nearestFramework != null)
                     {

test/NuGet.Core.FuncTests/NuGet.Commands.FuncTest/RestoreCommand_Aliases.cs

@@ -547,7 +547,7 @@ await SimpleTestPackageUtility.CreatePackagesAsync(
         [InlineData("apple", "net9.0", "banana", "net10.0")]
         [InlineData("apple", "net10.0", "banana", "net10.0")]
         [InlineData("banana", "net10.0", "apple", "net10.0")]
-        public async Task RestoreCommand_WithAliases_WithConditionalWarningSuppression_SupressesWarningsCorrectly(string firstAlias, string firstFramework, string secondAlias, string secondFramework)
+        public async Task RestoreCommand_WithAliases_WithConditionalWarningSuppression_SuppressesWarningsCorrectly(string firstAlias, string firstFramework, string secondAlias, string secondFramework)
         {
             using var pathContext = new SimpleTestPathContext();
             var rootProject = @"
@@ -600,7 +600,7 @@ await SimpleTestPackageUtility.CreatePackagesAsync(
         // P (apple) -> Project2 (apple) -> Package A
         // P (banana) -> Project2 (banana) -> Package B
         [Fact]
-        public async Task RestoreCommand_WithAliasesOfSameFrameworkAndProjectReferences_WithConditionalWarningSuppression_SupressesWarningsCorrectly()
+        public async Task RestoreCommand_WithAliasesOfSameFrameworkAndProjectReferences_WithConditionalWarningSuppression_SuppressesWarningsCorrectly()
         {
             using var pathContext = new SimpleTestPathContext();
 
@@ -675,7 +675,7 @@ public async Task RestoreCommand_WithAliasesOfSameFrameworkAndProjectReferences_
         }
 
         [Fact]
-        public async Task RestoreCommand_WithAliasesOfSameFrameworkAndProjectReferenceToASingleProject_WithConditionalWarningSuppression_SupressesWarningsCorrectly()
+        public async Task RestoreCommand_WithAliasesOfSameFrameworkAndProjectReferenceToASingleProject_WithConditionalWarningSuppression_SuppressesWarningsCorrectly()
         {
             using var pathContext = new SimpleTestPathContext();
 

test/TestUtilities/Test.Utility/Commands/ProjectTestHelpers.cs

@@ -155,7 +155,7 @@ public static PackageSpec WithTestRestoreMetadata(this PackageSpec spec)
             updated.RestoreMetadata.CentralPackageTransitivePinningEnabled = spec.RestoreMetadata?.CentralPackageTransitivePinningEnabled ?? false;
             if (spec.RestoreMetadata != null)
             {
-                updated.RestoreMetadata.ProjectWideWarningProperties = spec.RestoreMetadata.ProjectWideWarningProperties;
+                updated.RestoreMetadata.ProjectWideWarningProperties = spec.RestoreMetadata.ProjectWideWarningProperties.Clone();
             }
             updated.RestoreMetadata.RestoreAuditProperties = new RestoreAuditProperties()
             {