Cache NUGET_DISABLE_PACKAGEID_VALIDATION env var read in PackageIdValidator.Validate to eliminate per-call allocations (#7266)

Author: nareshjo

src/NuGet.Core/NuGet.Protocol/Utility/PackageIdValidator.cs

@@ -12,6 +12,11 @@ namespace NuGet.Protocol
 {
     internal static class PackageIdValidator
     {
+        private const string DisableValidationEnvVar = "NUGET_DISABLE_PACKAGEID_VALIDATION";
+
+        private static readonly Lazy<bool> IsValidationDisabled = new Lazy<bool>(() =>
+            IsPackageIdValidationDisabled(EnvironmentVariableWrapper.Instance));
+
         /// <summary>
         /// Validates the package ID content.
         /// </summary>
@@ -21,20 +26,20 @@ internal static class PackageIdValidator
         /// </exception>
         internal static void Validate(string packageId, IEnvironmentVariableReader env = null)
         {
-            if (env == null)
-            {
-                env = EnvironmentVariableWrapper.Instance;
-            }
-
-            string disableValidationEnvVarValue = env.GetEnvironmentVariable("NUGET_DISABLE_PACKAGEID_VALIDATION");
+            bool isDisabled = env == null
+                ? IsValidationDisabled.Value
+                : IsPackageIdValidationDisabled(env);
 
-            if (!string.Equals(disableValidationEnvVarValue, "true", StringComparison.OrdinalIgnoreCase))
+            if (!isDisabled)
             {
                 if (!Packaging.PackageIdValidator.IsValidPackageId(packageId))
                 {
                     throw new InvalidPackageIdException(string.Format(CultureInfo.CurrentCulture, Strings.Error_Invalid_package_id, packageId));
                 }
             }
         }
+
+        private static bool IsPackageIdValidationDisabled(IEnvironmentVariableReader env) =>
+            string.Equals(env.GetEnvironmentVariable(DisableValidationEnvVar), bool.TrueString, StringComparison.OrdinalIgnoreCase);
     }
 }