Fix cancellation token usage to prevent ObjectDisposedException (#7088)

Author: jebriede

src/NuGet.Clients/NuGet.PackageManagement.UI/GlobalSuppressions.cs

@@ -20,7 +20,6 @@
 [assembly: SuppressMessage("Build", "CA1062:In externally visible method 'AccessiblePackageIdentity.AccessiblePackageIdentity(PackageIdentity id)', validate parameter 'id' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.AccessiblePackageIdentity.#ctor(NuGet.Packaging.Core.PackageIdentity)")]
 [assembly: SuppressMessage("Build", "CA1062:In externally visible method 'object AdditionConverter.Convert(object[] values, Type targetType, object parameter, CultureInfo culture)', validate parameter 'values' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.AdditionConverter.Convert(System.Object[],System.Type,System.Object,System.Globalization.CultureInfo)~System.Object")]
 [assembly: SuppressMessage("Build", "CA1822:Member ExplainPackageDeprecationReasons does not access instance data and can be marked as static (Shared in VisualBasic)", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.DetailControlModel.ExplainPackageDeprecationReasons(System.Collections.Generic.IReadOnlyCollection{System.String})~System.String")]
-[assembly: SuppressMessage("Build", "CA1062:In externally visible method 'Task DetailControlModel.SetCurrentPackageAsync(PackageItemViewModel searchResultPackage, ItemFilter filter, Func<PackageItemViewModel> getPackageItemViewModel)', validate parameter 'getPackageItemViewModel' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.DetailControlModel.SetCurrentPackageAsync(NuGet.PackageManagement.UI.PackageItemViewModel,NuGet.PackageManagement.UI.ItemFilter,System.Func{NuGet.PackageManagement.UI.PackageItemViewModel})~System.Threading.Tasks.Task")]
 [assembly: SuppressMessage("Build", "CA1062:In externally visible method 'DisplayVersion.DisplayVersion(VersionRange range, string additionalInfo, bool isValidVersion = true, bool isCurrentInstalled = false, bool autoReferenced = false, bool isDeprecated = false, string versionFormat = \"N\")', validate parameter 'range' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.DisplayVersion.#ctor(NuGet.Versioning.VersionRange,System.String,System.Boolean,System.Boolean,System.Boolean,System.Boolean,System.String)")]
 [assembly: SuppressMessage("Build", "CA1822:Member WaitForInitialResultsAsync does not access instance data and can be marked as static (Shared in VisualBasic)", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.InfiniteScrollList.WaitForInitialResultsAsync(NuGet.PackageManagement.UI.IItemLoader{NuGet.PackageManagement.UI.PackageItemViewModel},System.IProgress{NuGet.PackageManagement.UI.IItemLoaderState},System.Threading.CancellationToken)~System.Threading.Tasks.Task")]
 [assembly: SuppressMessage("Build", "CA1303:Method 'object NotEqualConverter.Convert(object value, Type targetType, object parameter, CultureInfo culture)' passes a literal string as parameter 'message' of a call to 'ArgumentException.ArgumentException(string message)'. Retrieve the following string(s) from a resource table instead: \"Parameter should not be null and should inherit from IComparable\".", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.NotEqualConverter.Convert(System.Object,System.Type,System.Object,System.Globalization.CultureInfo)~System.Object")]
@@ -30,7 +29,6 @@
 [assembly: SuppressMessage("Build", "CA1062:In externally visible method 'Task<IModalProgressDialogSession> NuGetUIContext.StartModalProgressDialogAsync(string caption, ProgressDialogData initialData, INuGetUI uiService)', validate parameter 'initialData' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.NuGetUIContext.StartModalProgressDialogAsync(System.String,NuGet.PackageManagement.UI.ProgressDialogData,NuGet.PackageManagement.UI.INuGetUI)~System.Threading.Tasks.Task{NuGet.PackageManagement.UI.IModalProgressDialogSession}")]
 [assembly: SuppressMessage("Build", "CA1822:Member ShowFileConflictResolution does not access instance data and can be marked as static (Shared in VisualBasic)", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.NuGetUIProjectContext.ShowFileConflictResolution(System.String)~NuGet.ProjectManagement.FileConflictAction")]
 [assembly: SuppressMessage("Build", "CA1062:In externally visible method 'PackageDependencyMetadata.PackageDependencyMetadata(PackageDependency serverData)', validate parameter 'serverData' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.PackageDependencyMetadata.#ctor(NuGet.Packaging.Core.PackageDependency)")]
-[assembly: SuppressMessage("Build", "CA1062:In externally visible method 'Task PackageDetailControlModel.SetCurrentPackageAsync(PackageItemViewModel searchResultPackage, ItemFilter filter, Func<PackageItemViewModel> getPackageItemViewModel)', validate parameter 'getPackageItemViewModel' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.PackageDetailControlModel.SetCurrentPackageAsync(NuGet.PackageManagement.UI.PackageItemViewModel,NuGet.PackageManagement.UI.ItemFilter,System.Func{NuGet.PackageManagement.UI.PackageItemViewModel})~System.Threading.Tasks.Task")]
 [assembly: SuppressMessage("Build", "CA1062:In externally visible method 'int PackageInstallationInfo.CompareTo(PackageInstallationInfo other)', validate parameter 'other' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.PackageInstallationInfo.CompareTo(NuGet.PackageManagement.UI.PackageInstallationInfo)~System.Int32")]
 [assembly: SuppressMessage("Build", "CA1822:Member VersionEquals does not access instance data and can be marked as static (Shared in VisualBasic)", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.PackageItemViewModel.VersionEquals(NuGet.Versioning.NuGetVersion,NuGet.Versioning.NuGetVersion)~System.Boolean")]
 [assembly: SuppressMessage("Build", "CA1822:Member SetConsolidationAutomationProperties does not access instance data and can be marked as static (Shared in VisualBasic)", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.PackageManagement.UI.PackageManagerTopPanel.SetConsolidationAutomationProperties(System.Windows.Controls.TabItem,System.Int32)")]

src/NuGet.Clients/NuGet.PackageManagement.UI/Models/DetailControlModel.cs

@@ -137,10 +137,12 @@ public void SetCurrentSelectionInfo(
         /// </summary>
         /// <param name="searchResultPackage">The package to be displayed.</param>
         /// <param name="filter">The current filter. This will used to select the default action.</param>
+        /// <param name="cancellationToken">Cancellation token for async operations.</param>
         public async virtual Task SetCurrentPackageAsync(
             PackageItemViewModel searchResultPackage,
             ItemFilter filter,
-            Func<PackageItemViewModel> getPackageItemViewModel)
+            Func<PackageItemViewModel> getPackageItemViewModel,
+            CancellationToken cancellationToken)
         {
             // Clear old data
             ClearVersions();
@@ -156,7 +158,7 @@ public async virtual Task SetCurrentPackageAsync(
             OnPropertyChanged(nameof(IconBitmap));
             OnPropertyChanged(nameof(PrefixReserved));
 
-            Task<IReadOnlyCollection<VersionInfoContextInfo>> getVersionsTask = searchResultPackage.GetVersionsAsync(_nugetProjects);
+            Task<IReadOnlyCollection<VersionInfoContextInfo>> getVersionsTask = searchResultPackage.GetVersionsAsync(_nugetProjects, cancellationToken);
 
             _projectVersionConstraints = new List<ProjectVersionConstraint>();
 
@@ -235,7 +237,7 @@ public async virtual Task SetCurrentPackageAsync(
                 (searchResultPackage.Version, false, false)
             };
 
-            await CreateVersionsAsync(CancellationToken.None);
+            await CreateVersionsAsync(cancellationToken);
             NuGetUIThreadHelper.JoinableTaskFactory.RunAsync(OnCurrentPackageChanged)
                 .PostOnFailure(nameof(DetailControlModel), nameof(OnCurrentPackageChanged));
 
@@ -254,12 +256,12 @@ public async virtual Task SetCurrentPackageAsync(
                 .Select(GetVersion)
                 .ToList();
 
-            await CreateVersionsAsync(CancellationToken.None);
+            await CreateVersionsAsync(cancellationToken);
             NuGetUIThreadHelper.JoinableTaskFactory.RunAsync(OnCurrentPackageChanged)
                 .PostOnFailure(nameof(DetailControlModel), nameof(OnCurrentPackageChanged));
 
             (PackageSearchMetadataContextInfo packageSearchMetadata, PackageDeprecationMetadataContextInfo packageDeprecationMetadata) =
-                await searchResultPackage.GetDetailedPackageSearchMetadataAsync();
+                await searchResultPackage.GetDetailedPackageSearchMetadataAsync(cancellationToken);
 
             if (packageSearchMetadata != null)
             {
@@ -640,7 +642,7 @@ private async ValueTask SelectedVersionChangedAsync(PackageItemViewModel package
         {
             // Load the detailed metadata that we already have and check to see if this matches what is selected, we cannot use the _metadataDict here unfortunately as it won't be populated yet
             (PackageSearchMetadataContextInfo packageSearchMetadata, PackageDeprecationMetadataContextInfo packageDeprecationMetadata) =
-                await packageItemViewModel.GetDetailedPackageSearchMetadataAsync();
+                await packageItemViewModel.GetDetailedPackageSearchMetadataAsync(cancellationToken);
             if (packageSearchMetadata != null && packageSearchMetadata.Identity.Version.Equals(nugetVersion))
             {
                 if (_searchResultPackage != packageItemViewModel)

src/NuGet.Clients/NuGet.PackageManagement.UI/Models/PackageDetailControlModel.cs

@@ -38,7 +38,8 @@ public PackageDetailControlModel(
         public async override Task SetCurrentPackageAsync(
             PackageItemViewModel searchResultPackage,
             ItemFilter filter,
-            Func<PackageItemViewModel> getPackageItemViewModel)
+            Func<PackageItemViewModel> getPackageItemViewModel,
+            CancellationToken cancellationToken)
         {
             // Set InstalledVersion before fetching versions list.
             PackageLevel = searchResultPackage.PackageLevel;
@@ -55,7 +56,7 @@ public async override Task SetCurrentPackageAsync(
 
             OnPropertyChanged(nameof(VersionsView));
 
-            await base.SetCurrentPackageAsync(searchResultPackage, filter, getPackageItemViewModel);
+            await base.SetCurrentPackageAsync(searchResultPackage, filter, getPackageItemViewModel, cancellationToken);
 
             // SetCurrentPackage can take long time to return, user might changed selected package.
             // Check selected package.

src/NuGet.Clients/NuGet.PackageManagement.UI/PackageItemLoader.cs

@@ -329,13 +329,13 @@ public IEnumerable<PackageItemViewModel> GetCurrent()
 
                     if (listItem.PackageLevel == PackageLevel.TopLevel)
                     {
-                        listItem.UpdatePackageStatusAsync(_installedPackages)
+                        listItem.UpdatePackageStatusAsync(_installedPackages, CancellationToken.None)
                             .PostOnFailure(nameof(PackageItemLoader), nameof(GetCurrent));
                     }
                     else
                     {
                         listItem.UpdateTransitiveInfo(metadataContextInfo);
-                        listItem.UpdateTransitivePackageStatusAsync()
+                        listItem.UpdateTransitivePackageStatusAsync(CancellationToken.None)
                             .PostOnFailure(nameof(PackageItemLoader), nameof(GetCurrent));
                     }